From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46485C2BA19 for ; Mon, 6 Apr 2020 13:01:25 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EBC9822252 for ; Mon, 6 Apr 2020 13:01:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rrrAbP73" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EBC9822252 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 48wrJf627yzDr6D for ; Mon, 6 Apr 2020 23:01:22 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::543; helo=mail-pg1-x543.google.com; envelope-from=hqjagain@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=rrrAbP73; dkim-atps=neutral Received: from mail-pg1-x543.google.com (mail-pg1-x543.google.com [IPv6:2607:f8b0:4864:20::543]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 48wr705jmfzDqQX for ; Mon, 6 Apr 2020 22:53:00 +1000 (AEST) Received: by mail-pg1-x543.google.com with SMTP id r4so6034168pgg.4 for ; Mon, 06 Apr 2020 05:53:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=K7FMm9TMPU2qrk84mTQv2iPYDxxJSQ/dj4GfvVj1fPY=; b=rrrAbP73yD1ONDLTJHHC1edjnAz/00GjC3TLiTQauyplI1K0G6mcDZER5itCStgNul yEIizr773ToeQHFL7xgIGaMoJaElXJy+Fvo10z0KlxP5xwDR+AiVFVaAQQ8wt6vrZJuO E0MVHVBcVNw8JHGotScE7QKBMMHaIrEIrvp3s+pvNp36yxuwIf4yfhcZq9Kesu61IcD/ DE3V/TdKBQ0Nd0z2bSIOLQdjSc6d7iHJdM1MEqA11Wy/wkhNevInHzNMcwJzo22kAlyl 7eFZBJj3FPfdwewQVg/Kod4pAE/fqy9m7fJkmRgtI+FOmj1kf7++ZEl//uT4FwzeBuwb if6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=K7FMm9TMPU2qrk84mTQv2iPYDxxJSQ/dj4GfvVj1fPY=; b=kDqMyqhVVrR7yzyJyB7DOwXWbowobpnH5F5T7GNr4tivIvnc9XdZy2/D0Mi4v9Pxwn CpWcal15xNY7penhjoMyTnbY6i5665oZtp0MNLOj1p9Sbuyt49elW1fMY7MRJQcNDWDP 9vCrAHE5Bmw2l9vIOhQJ3Z9jDGJl++YHcU4lBzGNtTUES2/mxOtqWloYZvqG0Cisp1qq mlujgJ6HPAV9ccKBYH9MO5gChPeXYUrK9+RWydf4wkOA/guzBs44BInQFvtza3AYN6tQ /gQlv06OVwTLDiW5PvQcpYjGGu9b/lAc+DBT9/Iq3nNjSb97dReCOj28j+GKExyea80M U02Q== X-Gm-Message-State: AGi0PuYr4KXWjwYMIxmzWYgOuUOY0Syc8QFp7yHTQeAy6eVYSfxorjBQ BiXiaG3vGXb9KjweYm8mRnI= X-Google-Smtp-Source: APiQypJluYV8v1xRV51ls0+EjZR690Elsj1PdDoZoSspzpE1nvsNRa/80w2Kxh3Myp/I6Lbi7JZvDA== X-Received: by 2002:a62:1cf:: with SMTP id 198mr21700306pfb.246.1586177578658; Mon, 06 Apr 2020 05:52:58 -0700 (PDT) Received: from localhost (n112120135125.netvigator.com. [112.120.135.125]) by smtp.gmail.com with ESMTPSA id u129sm11493248pfb.101.2020.04.06.05.52.58 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 06 Apr 2020 05:52:58 -0700 (PDT) From: Qiujun Huang To: benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au, oohall@gmail.com Subject: [PATCH v5 2/2] powerpc/powernv: Add NULL check after kzalloc in opal_add_one_export Date: Mon, 6 Apr 2020 20:52:42 +0800 Message-Id: <20200406125242.4973-3-hqjagain@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200406125242.4973-1-hqjagain@gmail.com> References: <20200406125242.4973-1-hqjagain@gmail.com> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, Markus.Elfring@web.de, tglx@linutronix.de, linuxppc-dev@lists.ozlabs.org, Qiujun Huang Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Here needs a NULL check, as kzalloc may fail returning NULL. Issue was found by coccinelle. Generated by: scripts/coccinelle/null/kmerr.cocci Signed-off-by: Qiujun Huang Reviewed-by: Oliver O'Halloran --- arch/powerpc/platforms/powernv/opal.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/powerpc/platforms/powernv/opal.c b/arch/powerpc/platforms/powernv/opal.c index 71af1cbc6334..908d749bcef5 100644 --- a/arch/powerpc/platforms/powernv/opal.c +++ b/arch/powerpc/platforms/powernv/opal.c @@ -811,6 +811,9 @@ static int opal_add_one_export(struct kobject *parent, const char *export_name, return rc; attr = kzalloc(sizeof(*attr), GFP_KERNEL); + if (!attr) + return -ENOMEM; + name = kstrdup(export_name, GFP_KERNEL); if (!name) { rc = -ENOMEM; -- 2.17.1