linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Nicholas Piggin <npiggin@gmail.com>
To: linuxppc-dev@lists.ozlabs.org
Cc: Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com>,
	Ganesh Goudar <ganeshgr@linux.ibm.com>,
	Mahesh Salgaonkar <mahesh@linux.ibm.com>,
	Nicholas Piggin <npiggin@gmail.com>
Subject: [PATCH v3 09/15] powerpc/pseries: limit machine check stack to 4GB
Date: Tue,  7 Apr 2020 15:16:30 +1000	[thread overview]
Message-ID: <20200407051636.648369-10-npiggin@gmail.com> (raw)
In-Reply-To: <20200407051636.648369-1-npiggin@gmail.com>

This allows rtas_args to be put on the machine check stack, which
avoids a lot of complications with re-entrancy deadlocks.

Reviewed-by: Mahesh Salgaonkar <mahesh@linux.ibm.com>
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
 arch/powerpc/kernel/setup_64.c | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/arch/powerpc/kernel/setup_64.c b/arch/powerpc/kernel/setup_64.c
index 438a9befce41..defe05b6b7a9 100644
--- a/arch/powerpc/kernel/setup_64.c
+++ b/arch/powerpc/kernel/setup_64.c
@@ -709,7 +709,7 @@ void __init exc_lvl_early_init(void)
  */
 void __init emergency_stack_init(void)
 {
-	u64 limit;
+	u64 limit, mce_limit;
 	unsigned int i;
 
 	/*
@@ -726,7 +726,16 @@ void __init emergency_stack_init(void)
 	 * initialized in kernel/irq.c. These are initialized here in order
 	 * to have emergency stacks available as early as possible.
 	 */
-	limit = min(ppc64_bolted_size(), ppc64_rma_size);
+	limit = mce_limit = min(ppc64_bolted_size(), ppc64_rma_size);
+
+	/*
+	 * Machine check on pseries calls rtas, but can't use the static
+	 * rtas_args due to a machine check hitting while the lock is held.
+	 * rtas args have to be under 4GB, so the machine check stack is
+	 * limited to 4GB so args can be put on stack.
+	 */
+	if (firmware_has_feature(FW_FEATURE_LPAR) && mce_limit > SZ_4G)
+		mce_limit = SZ_4G;
 
 	for_each_possible_cpu(i) {
 		paca_ptrs[i]->emergency_sp = alloc_stack(limit, i) + THREAD_SIZE;
@@ -736,7 +745,7 @@ void __init emergency_stack_init(void)
 		paca_ptrs[i]->nmi_emergency_sp = alloc_stack(limit, i) + THREAD_SIZE;
 
 		/* emergency stack for machine check exception handling. */
-		paca_ptrs[i]->mc_emergency_sp = alloc_stack(limit, i) + THREAD_SIZE;
+		paca_ptrs[i]->mc_emergency_sp = alloc_stack(mce_limit, i) + THREAD_SIZE;
 #endif
 	}
 }
-- 
2.23.0


  parent reply	other threads:[~2020-04-07  5:36 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-07  5:16 [PATCH v3 00/15] powerpc/64: machine check and system reset fixes Nicholas Piggin
2020-04-07  5:16 ` [PATCH v3 01/15] powerpc/64s/exception: Fix machine check no-loss idle wakeup Nicholas Piggin
2020-04-07  5:16 ` [PATCH v3 02/15] powerpc/64s/exceptions: Fix in_mce accounting in unrecoverable path Nicholas Piggin
2020-04-07  5:16 ` [PATCH v3 03/15] powerpc/64s/exceptions: Change irq reconcile for NMIs from reusing _DAR to RESULT Nicholas Piggin
2020-04-07  5:16 ` [PATCH v3 04/15] powerpc/64s/exceptions: machine check reconcile irq state Nicholas Piggin
2020-04-07  5:16 ` [PATCH v3 05/15] powerpc/pseries/ras: avoid calling rtas_token in NMI paths Nicholas Piggin
2020-04-07  5:42   ` Christophe Leroy
2020-04-07  5:16 ` [PATCH v3 06/15] powerpc/pseries/ras: FWNMI_VALID off by one Nicholas Piggin
2020-04-07  5:16 ` [PATCH v3 07/15] powerpc/pseries/ras: fwnmi avoid modifying r3 in error case Nicholas Piggin
2020-04-07  5:16 ` [PATCH v3 08/15] powerpc/pseries/ras: fwnmi sreset should not interlock Nicholas Piggin
2020-04-07  5:41   ` Christophe Leroy
2020-04-07  5:16 ` Nicholas Piggin [this message]
2020-04-07  5:38   ` [PATCH v3 09/15] powerpc/pseries: limit machine check stack to 4GB Christophe Leroy
2020-04-07  5:16 ` [PATCH v3 10/15] powerpc/pseries: machine check use rtas_call_unlocked with args on stack Nicholas Piggin
2020-04-07  5:16 ` [PATCH v3 11/15] powerpc/64s: machine check interrupt update NMI accounting Nicholas Piggin
2020-04-07  5:37   ` Christophe Leroy
2020-05-06  3:50     ` Nicholas Piggin
2020-04-12  8:46   ` kbuild test robot
2020-04-07  5:16 ` [PATCH v3 12/15] powerpc: ftrace_enabled helper Nicholas Piggin
2020-04-07  5:45   ` Christophe Leroy
2020-04-07  5:16 ` [PATCH v3 13/15] powerpc/64s: machine check do not trace real-mode handler Nicholas Piggin
2020-04-07  5:45   ` Christophe Leroy
2020-04-07  5:16 ` [PATCH v3 14/15] powerpc/64s: system reset do not trace Nicholas Piggin
2020-04-07  5:45   ` Christophe Leroy
2020-04-07  5:16 ` [PATCH v3 15/15] powerpc: make unrecoverable NMIs die instead of panic Nicholas Piggin
2020-04-07  5:46   ` Christophe Leroy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200407051636.648369-10-npiggin@gmail.com \
    --to=npiggin@gmail.com \
    --cc=ganeshgr@linux.ibm.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mahesh@linux.ibm.com \
    --cc=mahesh@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).