linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Nicholas Piggin <npiggin@gmail.com>
To: linuxppc-dev@lists.ozlabs.org
Cc: Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com>,
	"Naveen N . Rao" <naveen.n.rao@linux.vnet.ibm.com>,
	Ganesh Goudar <ganeshgr@linux.ibm.com>,
	Nicholas Piggin <npiggin@gmail.com>
Subject: [PATCH v3 13/15] powerpc/64s: machine check do not trace real-mode handler
Date: Tue,  7 Apr 2020 15:16:34 +1000	[thread overview]
Message-ID: <20200407051636.648369-14-npiggin@gmail.com> (raw)
In-Reply-To: <20200407051636.648369-1-npiggin@gmail.com>

Rather than notrace annotations throughout a significant part of the
machine check code across kernel/ pseries/ and powernv/ which can
easily be broken and is infrequently tested, use paca->ftrace_enabled
to blanket-disable tracing of the real-mode non-maskable handler.

Acked-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
 arch/powerpc/kernel/mce.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/arch/powerpc/kernel/mce.c b/arch/powerpc/kernel/mce.c
index be7e3f92a7b5..fd90c0eda229 100644
--- a/arch/powerpc/kernel/mce.c
+++ b/arch/powerpc/kernel/mce.c
@@ -16,6 +16,7 @@
 #include <linux/export.h>
 #include <linux/irq_work.h>
 #include <linux/extable.h>
+#include <linux/ftrace.h>
 
 #include <asm/machdep.h>
 #include <asm/mce.h>
@@ -571,10 +572,14 @@ EXPORT_SYMBOL_GPL(machine_check_print_event_info);
  *
  * regs->nip and regs->msr contains srr0 and ssr1.
  */
-long machine_check_early(struct pt_regs *regs)
+long notrace machine_check_early(struct pt_regs *regs)
 {
 	long handled = 0;
 	bool nested = in_nmi();
+	u8 ftrace_enabled = this_cpu_get_ftrace_enabled();
+
+	this_cpu_set_ftrace_enabled(0);
+
 	if (!nested)
 		nmi_enter();
 
@@ -589,6 +594,8 @@ long machine_check_early(struct pt_regs *regs)
 	if (!nested)
 		nmi_exit();
 
+	this_cpu_set_ftrace_enabled(ftrace_enabled);
+
 	return handled;
 }
 
-- 
2.23.0


  parent reply	other threads:[~2020-04-07  5:43 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-07  5:16 [PATCH v3 00/15] powerpc/64: machine check and system reset fixes Nicholas Piggin
2020-04-07  5:16 ` [PATCH v3 01/15] powerpc/64s/exception: Fix machine check no-loss idle wakeup Nicholas Piggin
2020-04-07  5:16 ` [PATCH v3 02/15] powerpc/64s/exceptions: Fix in_mce accounting in unrecoverable path Nicholas Piggin
2020-04-07  5:16 ` [PATCH v3 03/15] powerpc/64s/exceptions: Change irq reconcile for NMIs from reusing _DAR to RESULT Nicholas Piggin
2020-04-07  5:16 ` [PATCH v3 04/15] powerpc/64s/exceptions: machine check reconcile irq state Nicholas Piggin
2020-04-07  5:16 ` [PATCH v3 05/15] powerpc/pseries/ras: avoid calling rtas_token in NMI paths Nicholas Piggin
2020-04-07  5:42   ` Christophe Leroy
2020-04-07  5:16 ` [PATCH v3 06/15] powerpc/pseries/ras: FWNMI_VALID off by one Nicholas Piggin
2020-04-07  5:16 ` [PATCH v3 07/15] powerpc/pseries/ras: fwnmi avoid modifying r3 in error case Nicholas Piggin
2020-04-07  5:16 ` [PATCH v3 08/15] powerpc/pseries/ras: fwnmi sreset should not interlock Nicholas Piggin
2020-04-07  5:41   ` Christophe Leroy
2020-04-07  5:16 ` [PATCH v3 09/15] powerpc/pseries: limit machine check stack to 4GB Nicholas Piggin
2020-04-07  5:38   ` Christophe Leroy
2020-04-07  5:16 ` [PATCH v3 10/15] powerpc/pseries: machine check use rtas_call_unlocked with args on stack Nicholas Piggin
2020-04-07  5:16 ` [PATCH v3 11/15] powerpc/64s: machine check interrupt update NMI accounting Nicholas Piggin
2020-04-07  5:37   ` Christophe Leroy
2020-05-06  3:50     ` Nicholas Piggin
2020-04-12  8:46   ` kbuild test robot
2020-04-07  5:16 ` [PATCH v3 12/15] powerpc: ftrace_enabled helper Nicholas Piggin
2020-04-07  5:45   ` Christophe Leroy
2020-04-07  5:16 ` Nicholas Piggin [this message]
2020-04-07  5:45   ` [PATCH v3 13/15] powerpc/64s: machine check do not trace real-mode handler Christophe Leroy
2020-04-07  5:16 ` [PATCH v3 14/15] powerpc/64s: system reset do not trace Nicholas Piggin
2020-04-07  5:45   ` Christophe Leroy
2020-04-07  5:16 ` [PATCH v3 15/15] powerpc: make unrecoverable NMIs die instead of panic Nicholas Piggin
2020-04-07  5:46   ` Christophe Leroy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200407051636.648369-14-npiggin@gmail.com \
    --to=npiggin@gmail.com \
    --cc=ganeshgr@linux.ibm.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mahesh@linux.vnet.ibm.com \
    --cc=naveen.n.rao@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).