From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAAAFC2BB86 for ; Fri, 10 Apr 2020 19:36:58 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6803A2145D for ; Fri, 10 Apr 2020 19:36:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="HTjtrTCP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6803A2145D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 48zSvC3glVzDr9y for ; Sat, 11 Apr 2020 05:36:55 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=redhat.com (client-ip=207.211.31.81; helo=us-smtp-delivery-1.mimecast.com; envelope-from=peterx@redhat.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=HTjtrTCP; dkim-atps=neutral Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 48zSrP5xpNzDqQk for ; Sat, 11 Apr 2020 05:34:28 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586547265; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pSDLH5WsDUY0Ls+Yi5DMpK6wFwspuCJoAo5jQ7V/Ijc=; b=HTjtrTCPCtqlucaZeYXO9hdRWKKNAckT7ekZDJXF4mJhpipaNA9I2CNaZ2kSj9hZ8JMDfd x8O+SqhSx6dStv8V30+AeWP2e15nVJrSHFhqsats/yWfEKX2i5V8jL8upV5bG1UT+dmM/5 7kohKTXNMLmKBR1LDF3Ev3cAOymTgN8= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-505-pV80qt3VOUSnsS_Rw6OHXw-1; Fri, 10 Apr 2020 15:34:23 -0400 X-MC-Unique: pV80qt3VOUSnsS_Rw6OHXw-1 Received: by mail-qk1-f197.google.com with SMTP id w21so2898663qkj.18 for ; Fri, 10 Apr 2020 12:34:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=dR0pnT92lTl7PiXH1/vycyqLlKqG/upjftJ1HpISkMA=; b=e5n612HzCtLX0ff95bO59RnYaF3dnfWTLKhYJqiVnhxIhkuY6vBcIn8PdEg39VqWNc we9uccQyg4P1LT71qJ4LzPJp/Rj15lQr3wkWxxLcrsZM47C8D3WPgd5gIAuWC4r2rk+c eAz0kzRzD706KkkLL1j5AvasbIrwUYBKt1Kt9sacskLRBMR+h7+N6y6ygb9DPclqVcY2 y95yIvVcowT3HgJTBqW9WTPLzTFQr6uwX5MPasFnm5WTEjlqiCSAX98M0hIr+M8rB6SU 4aNqMutnm6bqJw1rks4PSfqcTK7XnPO/R8aaVxg0JLUBNkfg9KrPYzOtZTq0QVYbOIYT PboQ== X-Gm-Message-State: AGi0PuY6ffXfviNZJgYNvh2q0QhM/ZfeD3DoIPx/PMpcK3bvssH3fE+1 +X2NMG3rFwiCujqDLY1hgBKgGPqIQJ3fOdQ4Ohy55fMHjktt59uQIuteXdqOqLJBlY9PmBm86F8 4yl7nxL2kbryWSXt/6kxjzUMhWw== X-Received: by 2002:ac8:6d06:: with SMTP id o6mr768745qtt.165.1586547263230; Fri, 10 Apr 2020 12:34:23 -0700 (PDT) X-Google-Smtp-Source: APiQypKE+9gdKAAzqM7E075abKl7yEhzpSisddiPAFgdbjLHprLwAVDEdymEnBo0qMB8GT4NFqVJjg== X-Received: by 2002:ac8:6d06:: with SMTP id o6mr768725qtt.165.1586547263017; Fri, 10 Apr 2020 12:34:23 -0700 (PDT) Received: from xz-x1 ([2607:9880:19c0:32::2]) by smtp.gmail.com with ESMTPSA id m11sm2214328qkg.130.2020.04.10.12.34.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Apr 2020 12:34:22 -0700 (PDT) Date: Fri, 10 Apr 2020 15:34:19 -0400 From: Peter Xu To: Mike Kravetz Subject: Re: [PATCH v2 3/4] hugetlbfs: remove hugetlb_add_hstate() warning for existing hstate Message-ID: <20200410193419.GF3172@xz-x1> References: <20200401183819.20647-1-mike.kravetz@oracle.com> <20200401183819.20647-4-mike.kravetz@oracle.com> MIME-Version: 1.0 In-Reply-To: <20200401183819.20647-4-mike.kravetz@oracle.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-doc@vger.kernel.org, Catalin Marinas , Dave Hansen , Heiko Carstens , linux-mm@kvack.org, Paul Mackerras , sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org, Will Deacon , Mina Almasry , linux-s390@vger.kernel.org, Jonathan Corbet , Christian Borntraeger , Ingo Molnar , Longpeng , Albert Ou , Vasily Gorbik , Paul Walmsley , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Palmer Dabbelt , Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S . Miller" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Wed, Apr 01, 2020 at 11:38:18AM -0700, Mike Kravetz wrote: [...] > @@ -3255,7 +3254,6 @@ void __init hugetlb_add_hstate(unsigned int order) > =09unsigned long i; > =20 > =09if (size_to_hstate(PAGE_SIZE << order)) { > -=09=09pr_warn("hugepagesz=3D specified twice, ignoring\n"); > =09=09return; > =09} Nitpick: I think the brackets need to be removed to follow linux coding style. With that: Reviewed-by: Peter Xu --=20 Peter Xu