From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DDA4C2BA19 for ; Wed, 15 Apr 2020 13:36:29 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 23C30206F9 for ; Wed, 15 Apr 2020 13:36:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IfPy7LVH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 23C30206F9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 492Nfy5q5szDqx2 for ; Wed, 15 Apr 2020 23:36:26 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::544; helo=mail-pg1-x544.google.com; envelope-from=aishwaryarj100@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=IfPy7LVH; dkim-atps=neutral Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 492NHb5jK4zDr31 for ; Wed, 15 Apr 2020 23:19:39 +1000 (AEST) Received: by mail-pg1-x544.google.com with SMTP id x26so1456886pgc.10 for ; Wed, 15 Apr 2020 06:19:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=mGivcgEJ6E876yj00y3QoKcNXlu3JKn22U740NPN6wE=; b=IfPy7LVHeMGkWmqorJ6OgR3uVTalPLTzftap1Wuz4dA3PVwCzEi0GBWkixQcOITQ/U /mx6tx5mAtFfpJr5K8A+uCNfaUXZKsPVrGiGnk+amCKDOLSRySJOPXRK+PdWkN6vnuI7 XmQsg5tBqG12SCEdkuYUkvSZz+1etZmwx6pqXbcIZlHOPZS4p3D/fTI2wtCl+Gpl9+X/ AYNFYNeduNCOdLZVzkcJZWRm6poyG/b2bKyQny9VrktjnvNY2LMtsSUn75VwvVcn6OV1 GD7c6FG8Yobax+jXnwLWKMHtvitBw0bxk9pLzmh20zRreyYASNDTT78JGpADNvwrgkJn JVpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=mGivcgEJ6E876yj00y3QoKcNXlu3JKn22U740NPN6wE=; b=XUngPyvj0XhgqviNF8Vr7bP3mjz26y3UAbA9/mh3sXRHhq3TPjqvd3YDxeVnM7qiHu leDx8MO0moIRuLgHu5BLxemYraW3wZ0pM3K/gJd+M1o1EmJVZvvyArspg7YWBND9qlA8 +8U+qN2PpMSzDkF2/PLqAsPGVMewQdpzSg1KrMs6OH6pX8KhnVO/N8vYQ24hQKFPzpAV +e3rkvVkWU+38F9ei/7jySqn5BN/z+wauoMr1ybGXEYzuRyF5fmPQReVsKc+ofcDDbux l2tU/S9cbKLobO7TtlayOJBZrfz7OlAYWMn2JJhtkQIr3Qsgde36NOuH95dbdYFkUocO Exgg== X-Gm-Message-State: AGi0Puag67HPgT28FsDax50pqm1EMnYD643+fdEpRciLbchSXb0ZLG+j 05X79hOs34Q6hgGBuaq5itE= X-Google-Smtp-Source: APiQypIBDKrme0mTxDjPnkAwvY8r34Ay4utm2CzhTMzkVCkR+WUfXWBN0Ic/WlLbhdK4/6ew0sMONg== X-Received: by 2002:a63:1a16:: with SMTP id a22mr20756378pga.264.1586956775700; Wed, 15 Apr 2020 06:19:35 -0700 (PDT) Received: from localhost.localdomain ([2409:4072:6e1c:dc2f:f465:67ce:fbea:c439]) by smtp.gmail.com with ESMTPSA id r9sm13403346pfg.2.2020.04.15.06.19.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2020 06:19:34 -0700 (PDT) From: Aishwarya R To: wsa@the-dreams.de Subject: [PATCH] i2c: powermac: Simplify reading the "reg" and "i2c-address" property Date: Wed, 15 Apr 2020 18:49:14 +0530 Message-Id: <20200415131916.23555-1-aishwaryarj100@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200408100354.17782-1-aishwaryarj100@gmail.com> References: <20200408100354.17782-1-aishwaryarj100@gmail.com> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kate Stewart , linux-kernel@vger.kernel.org, Richard Fontana , Paul Mackerras , linux-i2c@vger.kernel.org, Greg Kroah-Hartman , Thomas Gleixner , linuxppc-dev@lists.ozlabs.org, aishwaryarj100@gmail.com Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" >> Use of_property_read_u32 to read the "reg" and "i2c-address" property >> instead of using of_get_property to check the return values. >> >> Signed-off-by: Aishwarya R > This is quite a fragile driver. Have you tested it on HW? This change is not tested with the Hardware. But of_property_read_u32 is better here than generic of_get_property. This make sure that value read properly independent of system endianess.