From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B760C2BB85 for ; Thu, 16 Apr 2020 08:26:46 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 12481206B9 for ; Thu, 16 Apr 2020 08:26:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 12481206B9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 492sl76sC1zDrRW for ; Thu, 16 Apr 2020 18:26:43 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=209.85.210.194; helo=mail-pf1-f194.google.com; envelope-from=mcgrof@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=fail (p=none dis=none) header.from=kernel.org Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 492qfr3b33zDqgN for ; Thu, 16 Apr 2020 16:52:52 +1000 (AEST) Received: by mail-pf1-f194.google.com with SMTP id u9so1227896pfm.10 for ; Wed, 15 Apr 2020 23:52:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=u9FJuUtFkBVVe754ASFiMsIrGIfB932jO4gCk5SijoQ=; b=GsZN7EdiouDC3wpr+AMb1hBF48aJPP13P/jmS9NVB05jWto0ECOUdqAkGi6v1Ax0gf xnfurpbAA/+cHKjcX3IVTM2F434V3PY8Mx7dwfQp3Ym61qxQAS60KF6Io1WnIQvClFCZ IKWlyw8wkR2scHwN/QU43f7Zx6JphbuK2NC/5fjKYNtyYUUQRsf2DKJUbsRHtktO+R1s KC1Pk1dx+dEo0Pr9wQlSmvhKkNAyRPJWqGLMmP11E6BqqatCSAWy4Xw0iRU1GqjHoNBL MACTKcRmIT6Ktq7oj/3SzkMARYMA9GS6/A1OhdjBBJ2TeXf72mcQNqPnfXsfWPCkcyp7 x+zA== X-Gm-Message-State: AGi0PuZRwgw1I2yslgHg4tZbUryQHPptrPSJLUZkDxLiS07bOF3Epd6H edJXHH4jguSvD+mziTbJdvlE/4pc3BgxGA== X-Google-Smtp-Source: APiQypKByakqrvOibndG+UYJLRLNL9uRjqKma5zqDprpms3bUdiJFXDLYMCGhOmLou9lQzysqs9jaQ== X-Received: by 2002:a63:5f01:: with SMTP id t1mr29126955pgb.186.1587019969901; Wed, 15 Apr 2020 23:52:49 -0700 (PDT) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id o125sm14400027pgo.74.2020.04.15.23.52.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2020 23:52:48 -0700 (PDT) Received: by 42.do-not-panic.com (Postfix, from userid 1000) id 8222840277; Thu, 16 Apr 2020 06:52:47 +0000 (UTC) Date: Thu, 16 Apr 2020 06:52:47 +0000 From: Luis Chamberlain To: Emanuele Giuseppe Esposito Subject: Re: [PATCH 2/8] fs: extract simple_pin/release_fs to separate files Message-ID: <20200416065247.GR11244@42.do-not-panic.com> References: <20200414124304.4470-1-eesposit@redhat.com> <20200414124304.4470-3-eesposit@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200414124304.4470-3-eesposit@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Mailman-Approved-At: Thu, 16 Apr 2020 18:10:13 +1000 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Song Liu , linux-usb@vger.kernel.org, bpf@vger.kernel.org, "Rafael J. Wysocki" , David Airlie , Heiko Carstens , Alexei Starovoitov , dri-devel@lists.freedesktop.org, "J. Bruce Fields" , Joseph Qi , Hugh Dickins , Paul Mackerras , John Johansen , netdev@vger.kernel.org, linux-s390@vger.kernel.org, ocfs2-devel@oss.oracle.com, Christoph Hellwig , Andrew Donnellan , Matthew Garrett , linux-efi@vger.kernel.org, Arnd Bergmann , Daniel Borkmann , Christian Borntraeger , linux-rdma@vger.kernel.org, Mark Fasheh , Anton Vorontsov , John Fastabend , James Morris , Ard Biesheuvel , Jason Gunthorpe , Doug Ledford , oprofile-list@lists.sf.net, Yonghong Song , Ian Kent , Andrii Nakryiko , Alexey Dobriyan , "Serge E. Hallyn" , Robert Richter , Thomas Zimmermann , Vasily Gorbik , Tony Luck , Kees Cook , "James E.J. Bottomley" , autofs@vger.kernel.org, Maarten Lankhorst , Mike Marciniszyn , Maxime Ripard , linux-fsdevel@vger.kernel.org, "Manoj N. Kumar" , Uma Krishnan , Jakub Kicinski , KP Singh , Trond Myklebust , "Matthew R. Ochs" , "David S. Miller" , Felipe Balbi , linux-nfs@vger.kernel.org, Iurii Zaikin , linux-scsi@vger.kernel.org, "Martin K. Petersen" , linux-mm@kvack.org, Greg Kroah-Hartman , Dennis Dalessandro , Miklos Szeredi , linux-kernel@vger.kernel.org, Anna Schumaker , linux-security-module@vger.kernel.org, Chuck Lever , Jeremy Kerr , Daniel Vetter , Colin Cross , Frederic Barrat , Paolo Bonzini , Andrew Morton , Mike Kravetz , linuxppc-dev@lists.ozlabs.org, Martin KaFai Lau , Joel Becker , Alexander Viro Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, Apr 14, 2020 at 02:42:56PM +0200, Emanuele Giuseppe Esposito wrote: > We will augment this family of functions with inode management. To avoid > littering include/linux/fs.h and fs/libfs.c, move them to a separate header, > with a Kconfig symbol to enable them. If there are no functional changes, indicating that on the commit log will make the review much easier. > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug > index d1398cef3b18..fc38a6f0fc11 100644 > --- a/lib/Kconfig.debug > +++ b/lib/Kconfig.debug > @@ -288,12 +288,16 @@ config STRIP_ASM_SYMS > > config READABLE_ASM > bool "Generate readable assembler code" > - depends on DEBUG_KERNEL > - help > - Disable some compiler optimizations that tend to generate human unreadable > - assembler output. This may make the kernel slightly slower, but it helps > - to keep kernel developers who have to stare a lot at assembler listings > - sane. > + depends on DEBUG_KERNEL > + help > + Disable some compiler optimizations that tend to generate human unreadable > + assembler output. This may make the kernel slightly slower, but it helps > + to keep kernel developers who have to stare a lot at assembler listings > + sane. > + This minor change above should just be a separate patch. Its just noise otherwise. > +config DEBUG_FS > + bool "Debug Filesystem" > + select SIMPLEFS I'm at a loss reviewing this, my lib/Kconfig.debug already has a config DEBUG_FS. But above I see it is being added for the very first time. I'm sure there is some odd conditional which is obscuring this, can this be explained in the commit log? Luis