From: Luis Chamberlain <mcgrof@kernel.org>
To: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Cc: Song Liu <songliubraving@fb.com>,
linux-usb@vger.kernel.org, bpf@vger.kernel.org,
"Rafael J. Wysocki" <rafael@kernel.org>,
David Airlie <airlied@linux.ie>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Alexei Starovoitov <ast@kernel.org>,
dri-devel@lists.freedesktop.org,
"J. Bruce Fields" <bfields@fieldses.org>,
Joseph Qi <joseph.qi@linux.alibaba.com>,
Hugh Dickins <hughd@google.com>,
Paul Mackerras <paulus@samba.org>,
John Johansen <john.johansen@canonical.com>,
netdev@vger.kernel.org, linux-s390@vger.kernel.org,
ocfs2-devel@oss.oracle.com, Christoph Hellwig <hch@lst.de>,
Andrew Donnellan <ajd@linux.ibm.com>,
Matthew Garrett <matthew.garrett@nebula.com>,
linux-efi@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Daniel Borkmann <daniel@iogearbox.net>,
Christian Borntraeger <borntraeger@de.ibm.com>,
linux-rdma@vger.kernel.org, Mark Fasheh <mark@fasheh.com>,
Anton Vorontsov <anton@enomsg.org>,
John Fastabend <john.fastabend@gmail.com>,
James Morris <jmorris@namei.org>,
Ard Biesheuvel <ardb@kernel.org>, Jason Gunthorpe <jgg@ziepe.ca>,
Doug Ledford <dledford@redhat.com>,
oprofile-list@lists.sf.net, Yonghong Song <yhs@fb.com>,
Ian Kent <raven@themaw.net>, Andrii Nakryiko <andriin@fb.com>,
Alexey Dobriyan <adobriyan@gmail.com>,
"Serge E. Hallyn" <serge@hallyn.com>,
Robert Richter <rric@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Vasily Gorbik <gor@linux.ibm.com>,
Tony Luck <tony.luck@intel.com>,
Kees Cook <keescook@chromium.org>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
autofs@vger.kernel.org,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Mike Marciniszyn <mike.marciniszyn@intel.com>,
Maxime Ripard <mripard@kernel.org>,
linux-fsdevel@vger.kernel.org,
"Manoj N. Kumar" <manoj@linux.ibm.com>,
Uma Krishnan <ukrishn@linux.ibm.com>,
Jakub Kicinski <kuba@kernel.org>, KP Singh <kpsingh@chromium.org>,
Trond Myklebust <trond.myklebust@hammerspace.com>,
"Matthew R. Ochs" <mrochs@linux.ibm.com>,
"David S. Miller" <davem@davemloft.net>,
Felipe Balbi <balbi@kernel.org>,
linux-nfs@vger.kernel.org, Iurii Zaikin <yzaikin@google.com>,
linux-scsi@vger.kernel.org,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-mm@kvack.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Dennis Dalessandro <dennis.dalessandro@intel.com>,
Miklos Szeredi <miklos@szeredi.hu>,
linux-kernel@vger.kernel.org,
Anna Schumaker <anna.schumaker@netapp.com>,
linux-security-module@vger.kernel.org,
Chuck Lever <chuck.lever@oracle.com>, Jeremy Kerr <jk@ozlabs.org>,
Daniel Vetter <daniel@ffwll.ch>, Colin Cross <ccross@android.com>,
Frederic Barrat <fbarrat@linux.ibm.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Mike Kravetz <mike.kravetz@oracle.com>,
linuxppc-dev@lists.ozlabs.org, Martin KaFai Lau <kafai@fb.com>,
Joel Becker <jlbec@evilplan.org>,
Alexander Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH 0/8] Simplefs: group and simplify linux fs code
Date: Thu, 16 Apr 2020 06:59:22 +0000 [thread overview]
Message-ID: <20200416065922.GS11244@42.do-not-panic.com> (raw)
In-Reply-To: <20200414124304.4470-1-eesposit@redhat.com>
On Tue, Apr 14, 2020 at 02:42:54PM +0200, Emanuele Giuseppe Esposito wrote:
> This series of patches introduce wrappers for functions,
> arguments simplification in functions calls and most importantly
> groups duplicated code in a single header, simplefs, to avoid redundancy
> in the linux fs, especially debugfs and tracefs.
The general goal seems worthy, but here I don't see explained why hasn't
this gone through libfs, and what the intention was long term. For
instance, you added some other generalizations which you have found. It
was not clear that this was the goal here, to expand on these paths.
What if common code on fs is found which are not part of debugfs and
tracefs, how does one decide if to move to libfs or simplefs?
Luis
next prev parent reply other threads:[~2020-04-16 8:28 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-14 12:42 [PATCH 0/8] Simplefs: group and simplify linux fs code Emanuele Giuseppe Esposito
2020-04-14 12:42 ` [PATCH 1/8] apparmor: just use vfs_kern_mount to make .null Emanuele Giuseppe Esposito
2020-04-16 6:44 ` Luis Chamberlain
2020-04-20 14:00 ` Emanuele Giuseppe Esposito
2020-04-14 12:42 ` [PATCH 2/8] fs: extract simple_pin/release_fs to separate files Emanuele Giuseppe Esposito
2020-04-14 12:54 ` Greg Kroah-Hartman
2020-04-16 6:52 ` Luis Chamberlain
2020-04-21 11:19 ` Frederic Barrat
2020-04-21 11:26 ` Emanuele Giuseppe Esposito
2020-04-14 12:42 ` [PATCH 3/8] fs: wrap simple_pin_fs/simple_release_fs arguments in a struct Emanuele Giuseppe Esposito
2020-04-14 13:03 ` Greg Kroah-Hartman
2020-04-14 12:42 ` [PATCH 4/8] fs: introduce simple_new_inode Emanuele Giuseppe Esposito
2020-04-14 13:01 ` Greg Kroah-Hartman
2020-04-20 13:58 ` Emanuele Giuseppe Esposito
2020-04-14 12:42 ` [PATCH 5/8] simplefs: add alloc_anon_inode wrapper Emanuele Giuseppe Esposito
2020-04-14 12:55 ` Greg Kroah-Hartman
2020-04-14 12:43 ` [PATCH 6/8] simplefs: add file creation functions Emanuele Giuseppe Esposito
2020-04-14 12:56 ` Greg Kroah-Hartman
2020-04-20 13:57 ` Emanuele Giuseppe Esposito
2020-04-20 14:28 ` Greg Kroah-Hartman
2020-04-20 14:33 ` Paolo Bonzini
2020-04-14 12:43 ` [PATCH 7/8] debugfs: switch to simplefs inode creation API Emanuele Giuseppe Esposito
2020-04-14 12:43 ` [PATCH 8/8] tracefs: " Emanuele Giuseppe Esposito
2020-04-16 6:59 ` Luis Chamberlain [this message]
2020-04-20 14:01 ` [PATCH 0/8] Simplefs: group and simplify linux fs code Emanuele Giuseppe Esposito
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200416065922.GS11244@42.do-not-panic.com \
--to=mcgrof@kernel.org \
--cc=adobriyan@gmail.com \
--cc=airlied@linux.ie \
--cc=ajd@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=andriin@fb.com \
--cc=anna.schumaker@netapp.com \
--cc=anton@enomsg.org \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=ast@kernel.org \
--cc=autofs@vger.kernel.org \
--cc=balbi@kernel.org \
--cc=bfields@fieldses.org \
--cc=borntraeger@de.ibm.com \
--cc=bpf@vger.kernel.org \
--cc=ccross@android.com \
--cc=chuck.lever@oracle.com \
--cc=daniel@ffwll.ch \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dennis.dalessandro@intel.com \
--cc=dledford@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=eesposit@redhat.com \
--cc=fbarrat@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=heiko.carstens@de.ibm.com \
--cc=hughd@google.com \
--cc=jejb@linux.ibm.com \
--cc=jgg@ziepe.ca \
--cc=jk@ozlabs.org \
--cc=jlbec@evilplan.org \
--cc=jmorris@namei.org \
--cc=john.fastabend@gmail.com \
--cc=john.johansen@canonical.com \
--cc=joseph.qi@linux.alibaba.com \
--cc=kafai@fb.com \
--cc=keescook@chromium.org \
--cc=kpsingh@chromium.org \
--cc=kuba@kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=manoj@linux.ibm.com \
--cc=mark@fasheh.com \
--cc=martin.petersen@oracle.com \
--cc=matthew.garrett@nebula.com \
--cc=mike.kravetz@oracle.com \
--cc=mike.marciniszyn@intel.com \
--cc=miklos@szeredi.hu \
--cc=mripard@kernel.org \
--cc=mrochs@linux.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=ocfs2-devel@oss.oracle.com \
--cc=oprofile-list@lists.sf.net \
--cc=paulus@samba.org \
--cc=pbonzini@redhat.com \
--cc=rafael@kernel.org \
--cc=raven@themaw.net \
--cc=rric@kernel.org \
--cc=serge@hallyn.com \
--cc=songliubraving@fb.com \
--cc=tony.luck@intel.com \
--cc=trond.myklebust@hammerspace.com \
--cc=tzimmermann@suse.de \
--cc=ukrishn@linux.ibm.com \
--cc=viro@zeniv.linux.org.uk \
--cc=yhs@fb.com \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).