From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D287C2BB55 for ; Thu, 16 Apr 2020 19:04:52 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CFA4320786 for ; Thu, 16 Apr 2020 19:04:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CFA4320786 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4937vN5LYzzDrqB for ; Fri, 17 Apr 2020 05:04:48 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=permerror (SPF Permanent Error: Unknown mechanism found: ip:192.40.192.88/32) smtp.mailfrom=kernel.crashing.org (client-ip=63.228.1.57; helo=gate.crashing.org; envelope-from=segher@kernel.crashing.org; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by lists.ozlabs.org (Postfix) with ESMTP id 4937rT6fdLzDrT3 for ; Fri, 17 Apr 2020 05:02:17 +1000 (AEST) Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 03GJ20UU003931; Thu, 16 Apr 2020 14:02:00 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 03GJ1wgI003930; Thu, 16 Apr 2020 14:01:59 -0500 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Thu, 16 Apr 2020 14:01:58 -0500 From: Segher Boessenkool To: Christophe Leroy Subject: Re: [PATCH v2] powerpc/uaccess: Implement unsafe_put_user() using 'asm goto' Message-ID: <20200416190158.GC26902@gate.crashing.org> References: <20200415223747.GX26902@gate.crashing.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.4.2.3i X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, npiggin@gmail.com, Paul Mackerras , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, Apr 16, 2020 at 02:41:56PM +0200, Christophe Leroy wrote: > Le 16/04/2020 à 00:37, Segher Boessenkool a écrit : > >>+ __put_user_nocheck_goto((__typeof__(*(ptr)))(x), (ptr), > >>sizeof(*(ptr)), label) > > > >This line gets too long, can you break it up somehow? > > This line has 86 chars. (And your mail program has wrapped it ;-) ) > powerpc arch tolerates lines with up to 90 chars, see > arch/powerpc/tools/checkpatch.sh I *tolerate* it as well, sure, but long lines are bad for readability. Like, I noticed it because it wrapped :-) That "90" thing is just dumb, we should get rid of it. Sometimes you can have long lines, if that is better than the alternatives. There does not need to be a ridiculous "rule" that is unhappy *both* ways! (This is true for many things in checkpatch, btw... Rules of thumb, not rules). Segher