From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 743F3C2BB55 for ; Fri, 17 Apr 2020 09:03:37 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CE571207FC for ; Fri, 17 Apr 2020 09:03:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Ku4XU1bB"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Ku4XU1bB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CE571207FC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 493VWB3PXSzDrP3 for ; Fri, 17 Apr 2020 19:03:34 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=redhat.com (client-ip=205.139.110.61; helo=us-smtp-delivery-1.mimecast.com; envelope-from=mst@redhat.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Ku4XU1bB; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Ku4XU1bB; dkim-atps=neutral Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 493VSg5Rx6zDqGx for ; Fri, 17 Apr 2020 19:01:23 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587114081; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xBKPlLo6+sI2A/2RB1s4usLW0rCSt9Xj5ScVMSMT1UE=; b=Ku4XU1bBkUE/Nn3IPWAtJUW5VSl3hfD29TOEgVyWs7vK9UD33Ajr9FiBy2Psj/uk6cJBj/ ybx8tlVIrbbThoDriOuhvFSUr6y6f5g3BuWJNLjQnaBxFHdlqvB851ji8E743vYIJfHkeV dt8RoQeiab95bL2RKybQ26nw2bGpP7I= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587114081; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xBKPlLo6+sI2A/2RB1s4usLW0rCSt9Xj5ScVMSMT1UE=; b=Ku4XU1bBkUE/Nn3IPWAtJUW5VSl3hfD29TOEgVyWs7vK9UD33Ajr9FiBy2Psj/uk6cJBj/ ybx8tlVIrbbThoDriOuhvFSUr6y6f5g3BuWJNLjQnaBxFHdlqvB851ji8E743vYIJfHkeV dt8RoQeiab95bL2RKybQ26nw2bGpP7I= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-78-MKgqzgalM_eQZqc8RRQy6w-1; Fri, 17 Apr 2020 05:01:19 -0400 X-MC-Unique: MKgqzgalM_eQZqc8RRQy6w-1 Received: by mail-wr1-f71.google.com with SMTP id 11so680748wrc.3 for ; Fri, 17 Apr 2020 02:01:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=+LYdr3kSxXBMDicQAv0M7nkPT5YyAgLG/RWsjILE6Rk=; b=dfolBOhx8D61Y0s983m3jPFXS7gLG1kL3fx0/fjHF98cajsj8gxa91Hpby+DVe8Upq WBUFWVczZktqOXQhH5JhDeS8lm7sT3nVIAwrmao7y1lcCcF4PCJaEQNGB/3W4cZPV8i6 DIdWuLnkQsqjNEdud0Dj4yjqTFRkGZMn/kbvFpaT9Ox3i5MqBhAOavXmmOPSUSCSjm4+ Qulv7uOmeN7eizUJVK1ReTKI4gmn2FIZbLH1mdRzi59HDZf5Fibprwt5yyTU4ZxVRDYK nLScipAILBskOLYqAbxua4yqLCPvzYtkwjfSnMU6rDj8ADRym7iav0R55a4IOyBRy1Gi m0UQ== X-Gm-Message-State: AGi0Pub1FOPMiUUciRxpLxY17O3sOeGNx+UCyfZC38KzZE+4s37iEcZc 3MFKsihgjoVPgd+1SdFzULnwVrV1lFWbfWg6J2K12AHtfOh1OX2QoEmdsbdU5l+fPPyf8wGlLQm bA9+af5P0i7eUc/WUgUYnTY7APA== X-Received: by 2002:a1c:7c18:: with SMTP id x24mr2155031wmc.146.1587114077406; Fri, 17 Apr 2020 02:01:17 -0700 (PDT) X-Google-Smtp-Source: APiQypK2vbW1OnmBJFQVh7bub7YEhkI6cUby2dGaO6wz+YQlB7a8+Q2NUcfxoXyc58GWwBIeKSXJyQ== X-Received: by 2002:a1c:7c18:: with SMTP id x24mr2155008wmc.146.1587114077204; Fri, 17 Apr 2020 02:01:17 -0700 (PDT) Received: from redhat.com (bzq-79-183-51-3.red.bezeqint.net. [79.183.51.3]) by smtp.gmail.com with ESMTPSA id c20sm7408863wmd.36.2020.04.17.02.01.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Apr 2020 02:01:16 -0700 (PDT) Date: Fri, 17 Apr 2020 05:01:13 -0400 From: "Michael S. Tsirkin" To: Jason Wang Subject: Re: [PATCH V2] vhost: do not enable VHOST_MENU by default Message-ID: <20200417050029-mutt-send-email-mst@kernel.org> References: <20200415024356.23751-1-jasowang@redhat.com> <20200416185426-mutt-send-email-mst@kernel.org> <20200417022929-mutt-send-email-mst@kernel.org> <4274625d-6feb-81b6-5b0a-695229e7c33d@redhat.com> <20200417042912-mutt-send-email-mst@kernel.org> <20200417044230-mutt-send-email-mst@kernel.org> <73843240-3040-655d-baa9-683341ed4786@redhat.com> MIME-Version: 1.0 In-Reply-To: <73843240-3040-655d-baa9-683341ed4786@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-s390@vger.kernel.org, tsbogend@alpha.franken.de, gor@linux.ibm.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, heiko.carstens@de.ibm.com, linux-mips@vger.kernel.org, virtualization@lists.linux-foundation.org, borntraeger@de.ibm.com, geert@linux-m68k.org, netdev@vger.kernel.org, paulus@samba.org, linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, Apr 17, 2020 at 04:51:19PM +0800, Jason Wang wrote: >=20 > On 2020/4/17 =E4=B8=8B=E5=8D=884:46, Michael S. Tsirkin wrote: > > On Fri, Apr 17, 2020 at 04:39:49PM +0800, Jason Wang wrote: > > > On 2020/4/17 =E4=B8=8B=E5=8D=884:29, Michael S. Tsirkin wrote: > > > > On Fri, Apr 17, 2020 at 03:36:52PM +0800, Jason Wang wrote: > > > > > On 2020/4/17 =E4=B8=8B=E5=8D=882:33, Michael S. Tsirkin wrote: > > > > > > On Fri, Apr 17, 2020 at 11:12:14AM +0800, Jason Wang wrote: > > > > > > > On 2020/4/17 =E4=B8=8A=E5=8D=886:55, Michael S. Tsirkin wrote= : > > > > > > > > On Wed, Apr 15, 2020 at 10:43:56AM +0800, Jason Wang wrote: > > > > > > > > > We try to keep the defconfig untouched after decoupling C= ONFIG_VHOST > > > > > > > > > out of CONFIG_VIRTUALIZATION in commit 20c384f1ea1a > > > > > > > > > ("vhost: refine vhost and vringh kconfig") by enabling VH= OST_MENU by > > > > > > > > > default. Then the defconfigs can keep enabling CONFIG_VHO= ST_NET > > > > > > > > > without the caring of CONFIG_VHOST. > > > > > > > > >=20 > > > > > > > > > But this will leave a "CONFIG_VHOST_MENU=3Dy" in all defc= onfigs and even > > > > > > > > > for the ones that doesn't want vhost. So it actually shif= ts the > > > > > > > > > burdens to the maintainers of all other to add "CONFIG_VH= OST_MENU is > > > > > > > > > not set". So this patch tries to enable CONFIG_VHOST expl= icitly in > > > > > > > > > defconfigs that enables CONFIG_VHOST_NET and CONFIG_VHOST= _VSOCK. > > > > > > > > >=20 > > > > > > > > > Acked-by: Christian Borntraeger = (s390) > > > > > > > > > Acked-by: Michael Ellerman (powerpc= ) > > > > > > > > > Cc: Thomas Bogendoerfer > > > > > > > > > Cc: Benjamin Herrenschmidt > > > > > > > > > Cc: Paul Mackerras > > > > > > > > > Cc: Michael Ellerman > > > > > > > > > Cc: Heiko Carstens > > > > > > > > > Cc: Vasily Gorbik > > > > > > > > > Cc: Christian Borntraeger > > > > > > > > > Reported-by: Geert Uytterhoeven > > > > > > > > > Signed-off-by: Jason Wang > > > > > > > > I rebased this on top of OABI fix since that > > > > > > > > seems more orgent to fix. > > > > > > > > Pushed to my vhost branch pls take a look and > > > > > > > > if possible test. > > > > > > > > Thanks! > > > > > > > I test this patch by generating the defconfigs that wants vho= st_net or > > > > > > > vhost_vsock. All looks fine. > > > > > > >=20 > > > > > > > But having CONFIG_VHOST_DPN=3Dy may end up with the similar s= ituation that > > > > > > > this patch want to address. > > > > > > > Maybe we can let CONFIG_VHOST depends on !ARM || AEABI then a= dd another > > > > > > > menuconfig for VHOST_RING and do something similar? > > > > > > >=20 > > > > > > > Thanks > > > > > > Sorry I don't understand. After this patch CONFIG_VHOST_DPN is = just > > > > > > an internal variable for the OABI fix. I kept it separate > > > > > > so it's easy to revert for 5.8. Yes we could squash it into > > > > > > VHOST directly but I don't see how that changes logic at all. > > > > > Sorry for being unclear. > > > > >=20 > > > > > I meant since it was enabled by default, "CONFIG_VHOST_DPN=3Dy" w= ill be left > > > > > in the defconfigs. > > > > But who cares? > > > FYI, please seehttps://www.spinics.net/lists/kvm/msg212685.html > > The complaint was not about the symbol IIUC. It was that we caused > > everyone to build vhost unless they manually disabled it. >=20 >=20 > There could be some misunderstanding here. I thought it's somehow similar= : a > CONFIG_VHOST_MENU=3Dy will be left in the defconfigs even if CONFIG_VHOST= is > not set. >=20 > Thanks >=20 BTW do entries with no prompt actually appear in defconfig? > >=20