From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D24CC55185 for ; Thu, 23 Apr 2020 03:17:27 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C5E4F2073A for ; Thu, 23 Apr 2020 03:17:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="fbSWHJCC"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="fbSWHJCC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C5E4F2073A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4972Xz30ZTzDr3G for ; Thu, 23 Apr 2020 13:17:23 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=redhat.com (client-ip=207.211.31.120; helo=us-smtp-1.mimecast.com; envelope-from=bhe@redhat.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=fbSWHJCC; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=fbSWHJCC; dkim-atps=neutral Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4972VW15vkzDqjX for ; Thu, 23 Apr 2020 13:15:13 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587611710; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fUgyxTdqEN6SINdaIWtc3kKJE7aXkFDNuKscYDglBVE=; b=fbSWHJCCIvuuzV1NwtAhStDr/8Yo3K7FzO6B0H87qbAGX/6eudb59E6ecVe7Lz9MZkJgRX wuN9HEiQEJa9IYbWGLWP+xpndvqFdB55tkfBLgRZOlM8RBOb/YvuSNy/11C4KthVD8oNtk 2XJ+iJZYI+sm0F7D7BUju1JM+kVTjkg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587611710; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fUgyxTdqEN6SINdaIWtc3kKJE7aXkFDNuKscYDglBVE=; b=fbSWHJCCIvuuzV1NwtAhStDr/8Yo3K7FzO6B0H87qbAGX/6eudb59E6ecVe7Lz9MZkJgRX wuN9HEiQEJa9IYbWGLWP+xpndvqFdB55tkfBLgRZOlM8RBOb/YvuSNy/11C4KthVD8oNtk 2XJ+iJZYI+sm0F7D7BUju1JM+kVTjkg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-43-i0UUQLvzOLSX62nPLmus1g-1; Wed, 22 Apr 2020 23:15:07 -0400 X-MC-Unique: i0UUQLvzOLSX62nPLmus1g-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9BFAA1005510; Thu, 23 Apr 2020 03:15:01 +0000 (UTC) Received: from localhost (ovpn-12-37.pek2.redhat.com [10.72.12.37]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8185D19C69; Thu, 23 Apr 2020 03:14:58 +0000 (UTC) Date: Thu, 23 Apr 2020 11:14:54 +0800 From: Baoquan He To: Mike Rapoport Subject: Re: [PATCH 18/21] mm: rename free_area_init_node() to free_area_init_memoryless_node() Message-ID: <20200423031454.GB4247@MiWiFi-R3L-srv> References: <20200412194859.12663-1-rppt@kernel.org> <20200412194859.12663-19-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200412194859.12663-19-rppt@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rich Felker , linux-ia64@vger.kernel.org, linux-doc@vger.kernel.org, Catalin Marinas , Heiko Carstens , Michal Hocko , "James E.J. Bottomley" , Max Filippov , Guo Ren , linux-csky@vger.kernel.org, linux-parisc@vger.kernel.org, sparclinux@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-riscv@lists.infradead.org, Greg Ungerer , linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-c6x-dev@linux-c6x.org, Brian Cain , Jonathan Corbet , linux-sh@vger.kernel.org, Helge Deller , x86@kernel.org, Russell King , Ley Foon Tan , Mike Rapoport , Geert Uytterhoeven , linux-arm-kernel@lists.infradead.org, Mark Salter , Matt Turner , linux-mips@vger.kernel.org, uclinux-h8-devel@lists.sourceforge.jp, linux-xtensa@linux-xtensa.org, linux-alpha@vger.kernel.org, linux-um@lists.infradead.org, linux-m68k@lists.linux-m68k.org, Tony Luck , Greentime Hu , Paul Walmsley , Stafford Horne , Guan Xuetao , Hoan Tran , Michal Simek , Thomas Bogendoerfer , Yoshinori Sato , Nick Hu , linux-mm@kvack.org, Vineet Gupta , linux-kernel@vger.kernel.org, openrisc@lists.librecores.org, Richard Weinberger , Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S. Miller" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 04/12/20 at 10:48pm, Mike Rapoport wrote: > From: Mike Rapoport > > The free_area_init_node() is only used by x86 to initialize a memory-less > nodes. > Make its name reflect this and drop all the function parameters except node > ID as they are anyway zero. > > Signed-off-by: Mike Rapoport > --- > arch/x86/mm/numa.c | 5 +---- > include/linux/mm.h | 9 +++------ > mm/page_alloc.c | 7 ++----- > 3 files changed, 6 insertions(+), 15 deletions(-) > > diff --git a/arch/x86/mm/numa.c b/arch/x86/mm/numa.c > index fe024b2ac796..8ee952038c80 100644 > --- a/arch/x86/mm/numa.c > +++ b/arch/x86/mm/numa.c > @@ -737,12 +737,9 @@ void __init x86_numa_init(void) > > static void __init init_memory_less_node(int nid) > { > - unsigned long zones_size[MAX_NR_ZONES] = {0}; > - unsigned long zholes_size[MAX_NR_ZONES] = {0}; > - > /* Allocate and initialize node data. Memory-less node is now online.*/ > alloc_node_data(nid); > - free_area_init_node(nid, zones_size, 0, zholes_size); > + free_area_init_memoryless_node(nid); > > /* > * All zonelists will be built later in start_kernel() after per cpu > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 1c2ecb42e043..27660f6cf26e 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -2272,8 +2272,7 @@ static inline spinlock_t *pud_lock(struct mm_struct *mm, pud_t *pud) > } > > extern void __init pagecache_init(void); > -extern void __init free_area_init_node(int nid, unsigned long * zones_size, > - unsigned long zone_start_pfn, unsigned long *zholes_size); > +extern void __init free_area_init_memoryless_node(int nid); > extern void free_initmem(void); > > /* > @@ -2345,10 +2344,8 @@ static inline unsigned long get_num_physpages(void) > > /* > * Using memblock node mappings, an architecture may initialise its > - * zones, allocate the backing mem_map and account for memory holes in a more > - * architecture independent manner. This is a substitute for creating the > - * zone_sizes[] and zholes_size[] arrays and passing them to > - * free_area_init_node() > + * zones, allocate the backing mem_map and account for memory holes in an > + * architecture independent manner. > * > * An architecture is expected to register range of page frames backed by > * physical memory with memblock_add[_node]() before calling > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 376434c7a78b..e46232ec4849 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -6979,12 +6979,9 @@ static void __init __free_area_init_node(int nid, unsigned long *zones_size, > free_area_init_core(pgdat); > } > > -void __init free_area_init_node(int nid, unsigned long *zones_size, > - unsigned long node_start_pfn, > - unsigned long *zholes_size) > +void __init free_area_init_memoryless_node(int nid) > { > - __free_area_init_node(nid, zones_size, node_start_pfn, zholes_size, > - true); > + __free_area_init_node(nid, NULL, 0, NULL, false); Can we move free_area_init_memoryless_node() definition into arch/x86/mm/numa.c since there's only one caller there? And I am also wondering if adding a wrapper free_area_init_memoryless_node() is necessary if it's only called the function free_area_init_node(). > } > > #if !defined(CONFIG_FLAT_NODE_MEM_MAP) > -- > 2.25.1 >