From: Steven Rostedt <rostedt@goodmis.org>
To: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 3/3] powerpc/kprobes: Check return value of patch_instruction()
Date: Fri, 24 Apr 2020 14:31:19 -0400 [thread overview]
Message-ID: <20200424143119.4d9b159c@gandalf.local.home> (raw)
In-Reply-To: <1587751684.agx3nt8uvf.naveen@linux.ibm.com>
On Fri, 24 Apr 2020 23:56:25 +0530
"Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> wrote:
> > #define PATCH_INSN(addr, instr) \
> > ({
> > int rc = patch_instruction((unsigned int *)(addr), instr); \
> > if (rc) \
> > pr_err("%s:%d Error patching instruction at 0x%pK (%pS): %d\n", \
> > __func__, __LINE__, \
> > (void *)(addr), (void *)(addr), rc); \
> > rc; \
> > })
> >
> >
> > Then you can just do:
> >
> > ret = PATCH_INSN(...);
> > if (ret)
> > return ret;
> >
> > in the code.
>
> That's really nice. However, in this case, I guess I can simply use an
> inline function? The primary reason I used the macro was for including a
> 'return' statement in it.
I thought the primary reason was the __func__, __LINE__ which wont work as
expected as an inline.
-- Steve
next prev parent reply other threads:[~2020-04-24 18:34 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-23 15:09 [PATCH 0/3] powerpc: Enhance error handling with patch_instruction() Naveen N. Rao
2020-04-23 15:09 ` [PATCH 1/3] powerpc: Properly return error code from do_patch_instruction() Naveen N. Rao
2020-04-23 16:21 ` Christophe Leroy
2020-04-24 13:15 ` Steven Rostedt
2020-04-24 18:07 ` Naveen N. Rao
2020-04-24 18:29 ` Steven Rostedt
2020-04-24 19:26 ` Christopher M. Riedl
2020-04-25 14:10 ` Steven Rostedt
2020-04-25 14:11 ` Steven Rostedt
2020-04-27 17:14 ` Naveen N. Rao
2020-04-24 18:02 ` Naveen N. Rao
2022-01-14 16:19 ` Christophe Leroy
2020-04-23 15:09 ` [PATCH 2/3] powerpc/ftrace: Simplify error checking when patching instructions Naveen N. Rao
2020-04-23 15:44 ` Christophe Leroy
2020-04-23 15:09 ` [PATCH 3/3] powerpc/kprobes: Check return value of patch_instruction() Naveen N. Rao
2020-04-23 15:41 ` Christophe Leroy
2020-04-24 13:22 ` Steven Rostedt
2020-04-24 18:26 ` Naveen N. Rao
2020-04-24 18:31 ` Steven Rostedt [this message]
2020-04-24 19:38 ` Naveen N. Rao
2020-04-25 10:11 ` Christophe Leroy
2020-04-25 14:06 ` Steven Rostedt
2020-04-27 17:13 ` Naveen N. Rao
2020-04-27 17:11 ` Naveen N. Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200424143119.4d9b159c@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=naveen.n.rao@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).