From: Borislav Petkov <bp@alien8.de>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: "Jakub Jelinek" <jakub@redhat.com>,
jgross@suse.com, "Michael Matz" <matz@suse.de>,
"Kees Cook" <keescook@chromium.org>,
"Peter Zijlstra" <peterz@infradead.org>,
"Martin Liška" <mliska@suse.cz>,
x86@kernel.org, "Nick Desaulniers" <ndesaulniers@google.com>,
LKML <linux-kernel@vger.kernel.org>,
"Sergei Trofimovich" <slyfox@gentoo.org>,
clang-built-linux <clang-built-linux@googlegroups.com>,
"Arvind Sankar" <nivedita@alum.mit.edu>,
"Ingo Molnar" <mingo@redhat.com>,
"Paul Mackerras" <paulus@samba.org>,
"Andy Lutomirski" <luto@kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
"Frédéric Pierret (fepitre)" <frederic.pierret@qubes-os.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
linuxppc-dev@lists.ozlabs.org, boris.ostrovsky@oracle.com
Subject: Re: [PATCH] x86: Fix early boot crash on gcc-10, next try
Date: Sat, 25 Apr 2020 20:53:13 +0200 [thread overview]
Message-ID: <20200425185313.GD24294@zn.tnic> (raw)
In-Reply-To: <20200425183701.GE17645@gate.crashing.org>
On Sat, Apr 25, 2020 at 01:37:01PM -0500, Segher Boessenkool wrote:
> That is a lot more typing then
> asm("");
That's why a macro with a hopefully more descriptive name would be
telling more than a mere asm("").
> but more seriously, you probably should explain why you do not want a
> tail call *anyway*, and in such a comment you can say that is what the
> asm is for.
Yes, the final version will have a comment and the whole spiel. This
diff is just me polling the maintainers: "do you want this for your arch
too?" Well, the PPC maintainers only, actually.
The other call in init/main.c would be for everybody.
> I don't see anything that prevents the tailcall in current code either,
> fwiw.
Right, and I don't see a reason why gcc-10 would do that optimization on
x86 only but I better ask first.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2020-04-25 18:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200422102309.GA26846@zn.tnic>
[not found] ` <CAKwvOd=Dza3UBfeUzs2RW6ko5fDr3jYeGQAYpJXqyEVns6DJHg@mail.gmail.com>
[not found] ` <20200422192113.GG26846@zn.tnic>
[not found] ` <CAKwvOdkbcO8RzoafON2mGiSy5P96P5+aY8GySysF2my7q+nTqw@mail.gmail.com>
[not found] ` <20200422212605.GI26846@zn.tnic>
[not found] ` <CAKwvOd=exxhfb8N6=1Q=wBUaYcRDEq3L1+TiHDLz+pxWg8OuwQ@mail.gmail.com>
[not found] ` <20200423125300.GC26021@zn.tnic>
[not found] ` <20200423161126.GD26021@zn.tnic>
[not found] ` <20200425014657.GA2191784@rani.riverdale.lan>
[not found] ` <20200425085759.GA24294@zn.tnic>
2020-04-25 15:04 ` [PATCH] x86: Fix early boot crash on gcc-10, next try Arvind Sankar
2020-04-25 17:31 ` Borislav Petkov
2020-04-25 17:52 ` Borislav Petkov
2020-04-27 17:07 ` David Laight
2020-04-25 18:37 ` Segher Boessenkool
2020-04-25 18:53 ` Borislav Petkov [this message]
2020-04-25 19:15 ` Segher Boessenkool
2020-04-25 22:17 ` Borislav Petkov
2020-04-25 22:25 ` Arvind Sankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200425185313.GD24294@zn.tnic \
--to=bp@alien8.de \
--cc=boris.ostrovsky@oracle.com \
--cc=clang-built-linux@googlegroups.com \
--cc=frederic.pierret@qubes-os.org \
--cc=hpa@zytor.com \
--cc=jakub@redhat.com \
--cc=jgross@suse.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=luto@kernel.org \
--cc=matz@suse.de \
--cc=mingo@redhat.com \
--cc=mliska@suse.cz \
--cc=ndesaulniers@google.com \
--cc=nivedita@alum.mit.edu \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=segher@kernel.crashing.org \
--cc=slyfox@gentoo.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).