From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0F54C83003 for ; Wed, 29 Apr 2020 09:44:02 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1E3FE2073E for ; Wed, 29 Apr 2020 09:44:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1E3FE2073E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 49BtrG6kmnzDr1D for ; Wed, 29 Apr 2020 19:43:58 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lst.de (client-ip=213.95.11.211; helo=verein.lst.de; envelope-from=hch@lst.de; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=lst.de Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 49Btp8042qzDqyk for ; Wed, 29 Apr 2020 19:42:06 +1000 (AEST) Received: by verein.lst.de (Postfix, from userid 2407) id 8CE8668BFE; Wed, 29 Apr 2020 11:42:01 +0200 (CEST) Date: Wed, 29 Apr 2020 11:42:01 +0200 From: Christoph Hellwig To: Arnd Bergmann Subject: Re: [PATCH] fixup! signal: factor copy_siginfo_to_external32 from copy_siginfo_to_user32 Message-ID: <20200429094201.GA2557@lst.de> References: <20200428074827.GA19846@lst.de> <20200428195645.1365019-1-arnd@arndb.de> <20200429064458.GA31717@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-kernel@vger.kernel.org" , Alexander Viro , Jeremy Kerr , Linux FS-devel Mailing List , Andrew Morton , linuxppc-dev , Christoph Hellwig , "Eric W . Biederman" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Wed, Apr 29, 2020 at 10:07:11AM +0200, Arnd Bergmann wrote: > > What do you think of this version? This one always overrides > > copy_siginfo_to_user32 for the x86 compat case to keep the churn down, > > and improves the copy_siginfo_to_external32 documentation a bit. > > Looks good to me. I preferred checking for X32 explicitly (so we can > find and kill off the #ifdef if we ever remove X32 for good), but there is > little difference in the end. Is there any realistic chance we'll get rid of x32?