From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92AE5C47253 for ; Fri, 1 May 2020 08:40:14 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EC61C206D9 for ; Fri, 1 May 2020 08:40:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="LnfHuCMs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EC61C206D9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 49D5Kl1hPxzDrNP for ; Fri, 1 May 2020 18:40:11 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=bombadil.srs.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=batv+bcc6e49d8bb843eac143+6095+infradead.org+hch@bombadil.srs.infradead.org; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=bombadil.20170209 header.b=LnfHuCMs; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 49D5GK2GmszDrFP for ; Fri, 1 May 2020 18:37:13 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=jKY1/bxDwr65Net/8sGi43OjOzcOv/5LLiEA/MRVa7g=; b=LnfHuCMsjAn7lOVXQydmH2t5si oPrUOIAZBU69U3kxhYWOANIfs8sSq7V5rgpE4ZxiIoWGEnykSuEDSxDvClNdGSYNx2G1osiR/puVz vgIaIuZOZyW9jBnkBLJ6r5i6tLyAxZblilADgyJLJV4+N4meitaZBLfRUI0a4fxymxFMD3+VyTqyo +vMvkFxU/283QoM9IH5fUYBB5pQQi/e8qMy6dpFODRnRjVGnWJ8u5mmXkXxzS2T1a4uEkoddoaCgw R74KDtckF4JuDY5oASfn6waLSohpXnCj+DuFgl8ZqIwEn1Rn7773SDmHASfwd+QuYsBAHeRvwTN2/ RlOwTGbg==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jURAB-0003tJ-II; Fri, 01 May 2020 08:36:51 +0000 Date: Fri, 1 May 2020 01:36:51 -0700 From: Christoph Hellwig To: ira.weiny@intel.com Subject: Re: [PATCH V1 02/10] arch/xtensa: Move kmap build bug out of the way Message-ID: <20200501083651.GB27858@infradead.org> References: <20200430203845.582900-1-ira.weiny@intel.com> <20200430203845.582900-3-ira.weiny@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200430203845.582900-3-ira.weiny@intel.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Zijlstra , Dave Hansen , dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org, "James E.J. Bottomley" , Max Filippov , Huang Rui , Paul Mackerras , "H. Peter Anvin" , sparclinux@vger.kernel.org, Dan Williams , Helge Deller , x86@kernel.org, linux-csky@vger.kernel.org, Ingo Molnar , linux-snps-arc@lists.infradead.org, linux-xtensa@linux-xtensa.org, Borislav Petkov , Andy Lutomirski , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Chris Zankel , Thomas Bogendoerfer , linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org, "David S. Miller" , Andrew Morton , linuxppc-dev@lists.ozlabs.org, Christian Koenig Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, Apr 30, 2020 at 01:38:37PM -0700, ira.weiny@intel.com wrote: > @@ -88,6 +88,11 @@ void __init kmap_init(void) > { > unsigned long kmap_vstart; > > + /* Check if this memory layout is broken because PKMAP overlaps > + * page table. > + */ > + BUILD_BUG_ON(PKMAP_BASE < > + TLBTEMP_BASE_1 + TLBTEMP_SIZE); This can fit on a single line. Otherwise looks good: Reviewed-by: Christoph Hellwig