From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94F55C38A24 for ; Thu, 7 May 2020 06:46:47 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1105B2078C for ; Thu, 7 May 2020 06:46:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1105B2078C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 49HkX46VhwzDqts for ; Thu, 7 May 2020 16:46:44 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=209.85.208.195; helo=mail-lj1-f195.google.com; envelope-from=jhovold@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=fail (p=none dis=none) header.from=kernel.org Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com [209.85.208.195]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 49HkTS2kgwzDqvg for ; Thu, 7 May 2020 16:44:24 +1000 (AEST) Received: by mail-lj1-f195.google.com with SMTP id y4so5058943ljn.7 for ; Wed, 06 May 2020 23:44:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=KPHo05lQ60Sgmm/o6B6Lw5R77cey+JqtyoXZZ3TP7Og=; b=YASIYdKd7QQEP9saW3BzN8sz0TvK9sgUnohwEcRB3F1cUiqYODNKrp4b9iyNKBsNSw MjT1aEJerfgc3Ok/xPW4sJpJmyzxiWktaKTvUc7rVSV8699gA5x8e9lwsnZhC++6y6Nu U9EnSZ/WdhMD8VQC5IzYwGLk0hFU3NhMr3ZE1v0Hjh0RENl48557MoEkygxZzH/QlwgR XJpL2bmJ95bdysspAFd7ELBVzBDOUbJprrHp8w3Kd33zbc2qOzLmektlbZdbvTyTWH3H vIFAAnLSXEHfG+oBONmBvbCvOfbPbTGdRayeF8pRAboHz3h0K9BS5SZPT0sCqNkB8806 pixw== X-Gm-Message-State: AGi0PuabAjxuwpa7lUASAFy/eMY8k/FVMASOg87MQHO7tDXW4Ipjtzj1 kmUzRvT+9aBH6ZWXZ39FxWI= X-Google-Smtp-Source: APiQypIpQr2fTJp7sK/Z45NvIbcu6kYbSACpGgviZMKo6vxLEoYdxdc72K9eQNDS8kRJ9TzuUBJ2bQ== X-Received: by 2002:a2e:b44c:: with SMTP id o12mr6880195ljm.240.1588833860796; Wed, 06 May 2020 23:44:20 -0700 (PDT) Received: from xi.terra (c-beaee455.07-184-6d6c6d4.bbcust.telenor.se. [85.228.174.190]) by smtp.gmail.com with ESMTPSA id o20sm3131820lfc.39.2020.05.06.23.44.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 May 2020 23:44:19 -0700 (PDT) Received: from johan by xi.terra with local (Exim 4.92.3) (envelope-from ) id 1jWaGS-0008Rt-A0; Thu, 07 May 2020 08:44:12 +0200 Date: Thu, 7 May 2020 08:44:12 +0200 From: Johan Hovold To: Naresh Kamboju , Greg Kroah-Hartman Subject: Re: [PATCH net 11/16] net: ethernet: marvell: mvneta: fix fixed-link phydev leaks Message-ID: <20200507064412.GL2042@localhost> References: <1480357509-28074-1-git-send-email-johan@kernel.org> <1480357509-28074-12-git-send-email-johan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , lkft-triage@lists.linaro.org, Frank Rowand , Sasha Levin , Felix Fietkau , Florian Fainelli , Claudiu Manoil , Li Yang , Mugunthan V N , Grygorii Strashko , Johan Hovold , Rob Herring , linux-mediatek@lists.infradead.org, Lars Persson , Matthias Brugger , linux-omap@vger.kernel.org, John Crispin , Thomas Petazzoni , Fugang Duan , Sergei Shtylyov , Vivien Didelot , Greg Kroah-Hartman , linuxppc-dev@lists.ozlabs.org, open list , linux- stable , linux-renesas-soc@vger.kernel.org, Vitaly Bordug , Netdev , nios2-dev@lists.rocketboards.org, Vince Bridgers , "David S. Miller" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, May 07, 2020 at 12:27:53AM +0530, Naresh Kamboju wrote: > On Tue, 29 Nov 2016 at 00:00, Johan Hovold wrote: > > > > Make sure to deregister and free any fixed-link PHY registered using > > of_phy_register_fixed_link() on probe errors and on driver unbind. > > > > Fixes: 83895bedeee6 ("net: mvneta: add support for fixed links") > > Signed-off-by: Johan Hovold > > --- > > drivers/net/ethernet/marvell/mvneta.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c > > index 0c0a45af950f..707bc4680b9b 100644 > > --- a/drivers/net/ethernet/marvell/mvneta.c > > +++ b/drivers/net/ethernet/marvell/mvneta.c > > @@ -4191,6 +4191,8 @@ static int mvneta_probe(struct platform_device *pdev) > > clk_disable_unprepare(pp->clk); > > err_put_phy_node: > > of_node_put(phy_node); > > + if (of_phy_is_fixed_link(dn)) > > + of_phy_deregister_fixed_link(dn); > > While building kernel Image for arm architecture on stable-rc 4.4 branch > the following build error found. > > drivers/net/ethernet/marvell/mvneta.c:3442:3: error: implicit > declaration of function 'of_phy_deregister_fixed_link'; did you mean > 'of_phy_register_fixed_link'? [-Werror=implicit-function-declaration] > | of_phy_deregister_fixed_link(dn); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ > | of_phy_register_fixed_link > > ref: > https://gitlab.com/Linaro/lkft/kernel-runs/-/jobs/541374729 Greg, 3f65047c853a ("of_mdio: add helper to deregister fixed-link PHYs") needs to be backported as well for these. Original series can be found here: https://lkml.kernel.org/r/1480357509-28074-1-git-send-email-johan@kernel.org Johan