From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99912C38A24 for ; Thu, 7 May 2020 06:49:51 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 44E812078C for ; Thu, 7 May 2020 06:49:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="dCZ6mLUc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 44E812078C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 49Hkbd1QydzDqxd for ; Thu, 7 May 2020 16:49:49 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linuxfoundation.org (client-ip=198.145.29.99; helo=mail.kernel.org; envelope-from=gregkh@linuxfoundation.org; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=default header.b=dCZ6mLUc; dkim-atps=neutral Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 49HkY86xFhzDqKN for ; Thu, 7 May 2020 16:47:38 +1000 (AEST) Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D794F2078C; Thu, 7 May 2020 06:47:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588834056; bh=hUD5exA4dNKvCcKV83BYNh5VFO685TqU5GU5ToDg3us=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dCZ6mLUcN1lIcruUpjFnEcOhlyrmSgxjeyHHlnFw/4co12Hwb9W/Qsgzq6nZ+HnJp DibKlr9P4RQGxGYL3/8X8BfHpXRz53ezegCOp/1lVZvRByJvVXChNS4+D1DL4tpB3T fOVh6T5cCACfVwnSp8ZDtkKBDaj/Y7C6rRFAF5rg= Date: Thu, 7 May 2020 08:47:34 +0200 From: Greg Kroah-Hartman To: Johan Hovold Subject: Re: [PATCH net 11/16] net: ethernet: marvell: mvneta: fix fixed-link phydev leaks Message-ID: <20200507064734.GA798308@kroah.com> References: <1480357509-28074-1-git-send-email-johan@kernel.org> <1480357509-28074-12-git-send-email-johan@kernel.org> <20200507064412.GL2042@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200507064412.GL2042@localhost> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , lkft-triage@lists.linaro.org, Frank Rowand , Sasha Levin , Felix Fietkau , Florian Fainelli , Naresh Kamboju , Claudiu Manoil , Li Yang , Mugunthan V N , Grygorii Strashko , linuxppc-dev@lists.ozlabs.org, Rob Herring , linux-mediatek@lists.infradead.org, Lars Persson , Matthias Brugger , linux-omap@vger.kernel.org, John Crispin , Thomas Petazzoni , Fugang Duan , Sergei Shtylyov , Vivien Didelot , Netdev , open list , linux- stable , linux-renesas-soc@vger.kernel.org, Vitaly Bordug , nios2-dev@lists.rocketboards.org, Vince Bridgers , "David S. Miller" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, May 07, 2020 at 08:44:12AM +0200, Johan Hovold wrote: > On Thu, May 07, 2020 at 12:27:53AM +0530, Naresh Kamboju wrote: > > On Tue, 29 Nov 2016 at 00:00, Johan Hovold wrote: > > > > > > Make sure to deregister and free any fixed-link PHY registered using > > > of_phy_register_fixed_link() on probe errors and on driver unbind. > > > > > > Fixes: 83895bedeee6 ("net: mvneta: add support for fixed links") > > > Signed-off-by: Johan Hovold > > > --- > > > drivers/net/ethernet/marvell/mvneta.c | 5 +++++ > > > 1 file changed, 5 insertions(+) > > > > > > diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c > > > index 0c0a45af950f..707bc4680b9b 100644 > > > --- a/drivers/net/ethernet/marvell/mvneta.c > > > +++ b/drivers/net/ethernet/marvell/mvneta.c > > > @@ -4191,6 +4191,8 @@ static int mvneta_probe(struct platform_device *pdev) > > > clk_disable_unprepare(pp->clk); > > > err_put_phy_node: > > > of_node_put(phy_node); > > > + if (of_phy_is_fixed_link(dn)) > > > + of_phy_deregister_fixed_link(dn); > > > > While building kernel Image for arm architecture on stable-rc 4.4 branch > > the following build error found. > > > > drivers/net/ethernet/marvell/mvneta.c:3442:3: error: implicit > > declaration of function 'of_phy_deregister_fixed_link'; did you mean > > 'of_phy_register_fixed_link'? [-Werror=implicit-function-declaration] > > | of_phy_deregister_fixed_link(dn); > > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > | of_phy_register_fixed_link > > > > ref: > > https://gitlab.com/Linaro/lkft/kernel-runs/-/jobs/541374729 > > Greg, 3f65047c853a ("of_mdio: add helper to deregister fixed-link > PHYs") needs to be backported as well for these. > > Original series can be found here: > > https://lkml.kernel.org/r/1480357509-28074-1-git-send-email-johan@kernel.org Ah, thanks for that, I thought I dropped all of the ones that caused build errors, but missed the above one. I'll go take the whole series instead. greg k-h