* [PATCH 4/5] powerpc/mpc85xx: Add Cyrus HDD LED
@ 2020-05-07 21:15 Darren Stevens
2020-05-08 20:37 ` Scott Wood
0 siblings, 1 reply; 2+ messages in thread
From: Darren Stevens @ 2020-05-07 21:15 UTC (permalink / raw)
To: linuxppc-dev, oss; +Cc: chzigotzky
The Cyrus board has its HDD LED connected to a GPIO pin. Add a device
tree entry for this.
Signed-off-By: Darren Stevens <darren@stevens-zone.net>
---
arch/powerpc/boot/dts/fsl/cyrus_p5020.dts | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/powerpc/boot/dts/fsl/cyrus_p5020.dts
b/arch/powerpc/boot/dts/fsl/cyrus_p5020.dts index f0548fe..74c100f
100644 --- a/arch/powerpc/boot/dts/fsl/cyrus_p5020.dts
+++ b/arch/powerpc/boot/dts/fsl/cyrus_p5020.dts
@@ -83,6 +83,16 @@
gpios = <&gpio0 2 1>;
};
+ leds {
+ compatible = "gpio-leds";
+
+ hdd {
+ label = "Disk Activity";
+ gpios = <&gpio0 5 0>;
+ linux,default-trigger =
"disk-activity";
+ };
+ };
+
fman@400000 {
mdio@e1120 {
phy3: ethernet-phy@3 {
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH 4/5] powerpc/mpc85xx: Add Cyrus HDD LED
2020-05-07 21:15 [PATCH 4/5] powerpc/mpc85xx: Add Cyrus HDD LED Darren Stevens
@ 2020-05-08 20:37 ` Scott Wood
0 siblings, 0 replies; 2+ messages in thread
From: Scott Wood @ 2020-05-08 20:37 UTC (permalink / raw)
To: Darren Stevens, linuxppc-dev; +Cc: chzigotzky
On Thu, 2020-05-07 at 22:15 +0100, Darren Stevens wrote:
> The Cyrus board has its HDD LED connected to a GPIO pin. Add a device
> tree entry for this.
>
> Signed-off-By: Darren Stevens <darren@stevens-zone.net>
>
> ---
> arch/powerpc/boot/dts/fsl/cyrus_p5020.dts | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/powerpc/boot/dts/fsl/cyrus_p5020.dts
> b/arch/powerpc/boot/dts/fsl/cyrus_p5020.dts index f0548fe..74c100f
> 100644 --- a/arch/powerpc/boot/dts/fsl/cyrus_p5020.dts
> +++ b/arch/powerpc/boot/dts/fsl/cyrus_p5020.dts
> @@ -83,6 +83,16 @@
> gpios = <&gpio0 2 1>;
> };
>
> + leds {
> + compatible = "gpio-leds";
> +
> + hdd {
> + label = "Disk Activity";
> + gpios = <&gpio0 5 0>;
> + linux,default-trigger =
> "disk-activity";
> + };
Documentation/devicetree/bindings/leds/common.yaml says that label is
deprecated, and to "use 'function' and 'color' properties instead".
Also, please CC devicetree@vger.kernel.org on these patches.
-Scott
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-08 20:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-07 21:15 [PATCH 4/5] powerpc/mpc85xx: Add Cyrus HDD LED Darren Stevens
2020-05-08 20:37 ` Scott Wood
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).