From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA6F7C35280 for ; Thu, 7 May 2020 22:52:51 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2BDA82083B for ; Thu, 7 May 2020 22:52:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2BDA82083B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 49J7yn11vDzDqjn for ; Fri, 8 May 2020 08:52:49 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=intel.com (client-ip=192.55.52.120; helo=mga04.intel.com; envelope-from=ira.weiny@intel.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=intel.com Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 49J7wX5H54zDqdL for ; Fri, 8 May 2020 08:50:45 +1000 (AEST) IronPort-SDR: VC/VbOD5w0A9QWWQgJMNw49Fj3moe3AAhfzeKPvn+7EhlHryzk4xhHdheySdFMmUW0+rBEWTo5 OXY8CBgodqhQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 May 2020 15:50:41 -0700 IronPort-SDR: A94YOimG+GBTCtRnotihIHXo/4uYOm9rsXy8xtuLX5Aw2+CVkRWX3diLimU1sfCOXtFd1OcX1r bTWfMT7evkVA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,365,1583222400"; d="scan'208";a="278753786" Received: from iweiny-desk2.sc.intel.com ([10.3.52.147]) by orsmga002.jf.intel.com with ESMTP; 07 May 2020 15:50:40 -0700 Date: Thu, 7 May 2020 15:50:40 -0700 From: Ira Weiny To: Andrew Morton Subject: Re: [PATCH V3 13/15] parisc/kmap: Remove duplicate kmap code Message-ID: <20200507225039.GA1428632@iweiny-DESK2.sc.intel.com> References: <20200507150004.1423069-1-ira.weiny@intel.com> <20200507150004.1423069-14-ira.weiny@intel.com> <20200507135258.f430182578c0d63b7488916e@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200507135258.f430182578c0d63b7488916e@linux-foundation.org> User-Agent: Mutt/1.11.1 (2018-12-01) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Zijlstra , Dave Hansen , dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org, "James E.J. Bottomley" , Max Filippov , Paul Mackerras , "H. Peter Anvin" , sparclinux@vger.kernel.org, Thomas Gleixner , Helge Deller , x86@kernel.org, linux-csky@vger.kernel.org, Christoph Hellwig , Ingo Molnar , linux-snps-arc@lists.infradead.org, linux-xtensa@linux-xtensa.org, Borislav Petkov , Al Viro , Andy Lutomirski , Dan Williams , linux-arm-kernel@lists.infradead.org, Chris Zankel , Thomas Bogendoerfer , linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org, Christian Koenig , linuxppc-dev@lists.ozlabs.org, "David S. Miller" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, May 07, 2020 at 01:52:58PM -0700, Andrew Morton wrote: > On Thu, 7 May 2020 08:00:01 -0700 ira.weiny@intel.com wrote: > > > parisc reimplements the kmap calls except to flush it's dcache. This is > > arguably an abuse of kmap but regardless it is messy and confusing. > > > > Remove the duplicate code and have parisc define > > ARCH_HAS_FLUSH_ON_KUNMAP for a kunmap_flush_on_unmap() architecture > > specific call to flush the cache. > > checkpatch says: > > ERROR: #define of 'ARCH_HAS_FLUSH_ON_KUNMAP' is wrong - use Kconfig variables or standard guards instead > #69: FILE: arch/parisc/include/asm/cacheflush.h:103: > +#define ARCH_HAS_FLUSH_ON_KUNMAP > > which is fair enough, I guess. More conventional would be > > arch/parisc/include/asm/cacheflush.h: > > static inline void kunmap_flush_on_unmap(void *addr) > { > ... > } > #define kunmap_flush_on_unmap kunmap_flush_on_unmap > > > include/linux/highmem.h: > > #ifndef kunmap_flush_on_unmap > static inline void kunmap_flush_on_unmap(void *addr) > { > } > #define kunmap_flush_on_unmap kunmap_flush_on_unmap > #endif > > > static inline void kunmap_atomic_high(void *addr) > { > /* Mostly nothing to do in the CONFIG_HIGHMEM=n case as kunmap_atomic() > * handles re-enabling faults + preemption */ > kunmap_flush_on_unmap(addr); > } > > > but I don't really think it's worth bothering changing it. > > (Ditto patch 3/15) Yes I was following the pattern already there. I'll fix up the last patch now. Ira