From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA5CBC38A2A for ; Fri, 8 May 2020 06:26:07 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D7D9320708 for ; Fri, 8 May 2020 06:26:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D7D9320708 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 49JL1m0j0bzDqGc for ; Fri, 8 May 2020 16:26:04 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=209.85.208.195; helo=mail-lj1-f195.google.com; envelope-from=jhovold@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=fail (p=none dis=none) header.from=kernel.org Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com [209.85.208.195]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 49JKwT0jrhzDqV3 for ; Fri, 8 May 2020 16:21:28 +1000 (AEST) Received: by mail-lj1-f195.google.com with SMTP id l19so436358lje.10 for ; Thu, 07 May 2020 23:21:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=l07sjg7wad11JybQiwBPplAsmA/VCV2GQr8sTEyBm88=; b=arMgVPOOta/G47ixuK143JIy8hNiXqQc8VJYQLnKqXEsvxbN4VapEmlAtwZu6yYMjD 759LdVMG09VMreFSz48bDTD65vAiEvspVLXPw03XixNsMYpVwU2R6TCZ+cUExkUbAzdW /yZVZ8urK7kAvOjPcO1O/+3APkhdV+96ui2UIMp74DlhO45bpldr4QTd71fKYh0dX9y/ T1cf3tLO2lYHX3GOMVZTdAEz2AQK0GzmzhkOCsvc+YAzthJVrjpX8hOoDM7aA+S+Ir/7 cz7fYiZgoo8OUQWxjbF5QiT4ZpV0jyagH20anfVQaBP+H5PONjS4QsmMaXDQIhKV5pX9 CQkA== X-Gm-Message-State: AOAM530YLzvpiRMbWiGpDBs0z8nsRZOKJMwevLdo1ANicoOeIWolyT/H BbZytcduVETWHCOvES1Euoc= X-Google-Smtp-Source: ABdhPJzQwccjomPZVXTofZDq7QNMtMm+acyePCPBUNykc5Wt6G9pf/ArU7L/ehrFMv9M6FmHt7FVvw== X-Received: by 2002:a05:651c:549:: with SMTP id q9mr624525ljp.236.1588918884533; Thu, 07 May 2020 23:21:24 -0700 (PDT) Received: from xi.terra (c-beaee455.07-184-6d6c6d4.bbcust.telenor.se. [85.228.174.190]) by smtp.gmail.com with ESMTPSA id z64sm428692lfa.50.2020.05.07.23.21.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2020 23:21:23 -0700 (PDT) Received: from johan by xi.terra with local (Exim 4.92.3) (envelope-from ) id 1jWwNr-0001TQ-0H; Fri, 08 May 2020 08:21:19 +0200 Date: Fri, 8 May 2020 08:21:19 +0200 From: Johan Hovold To: Naresh Kamboju Subject: Re: [PATCH net 11/16] net: ethernet: marvell: mvneta: fix fixed-link phydev leaks Message-ID: <20200508062119.GE25962@localhost> References: <1480357509-28074-1-git-send-email-johan@kernel.org> <1480357509-28074-12-git-send-email-johan@kernel.org> <20200507064412.GL2042@localhost> <20200507064734.GA798308@kroah.com> <20200507111312.GA1497799@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , lkft-triage@lists.linaro.org, Frank Rowand , Sasha Levin , Florian Fainelli , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Grygorii Strashko , Johan Hovold , Rob Herring , linux-mediatek@lists.infradead.org, Lars Persson , Matthias Brugger , linux-omap@vger.kernel.org, Thomas Petazzoni , Fugang Duan , Sergei Shtylyov , Greg Kroah-Hartman , open list , linux- stable , linux-renesas-soc@vger.kernel.org, Netdev , nios2-dev@lists.rocketboards.org, linuxppc-dev@lists.ozlabs.org, "David S. Miller" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, May 08, 2020 at 03:35:02AM +0530, Naresh Kamboju wrote: > On Thu, 7 May 2020 at 16:43, Greg Kroah-Hartman > wrote: > > > > > > > > > > > Greg, 3f65047c853a ("of_mdio: add helper to deregister fixed-link > > > > PHYs") needs to be backported as well for these. > > > > > > > > Original series can be found here: > > > > > > > > https://lkml.kernel.org/r/1480357509-28074-1-git-send-email-johan@kernel.org > > > > > > Ah, thanks for that, I thought I dropped all of the ones that caused > > > build errors, but missed the above one. I'll go take the whole series > > > instead. > > > > This should now all be fixed up, thanks. > > While building kernel Image for arm architecture on stable-rc 4.4 branch > the following build error found. > > of_mdio: add helper to deregister fixed-link PHYs > commit 3f65047c853a2a5abcd8ac1984af3452b5df4ada upstream. > > Add helper to deregister fixed-link PHYs registered using > of_phy_register_fixed_link(). > > Convert the two drivers that care to deregister their fixed-link PHYs to > use the new helper, but note that most drivers currently fail to do so. > > Signed-off-by: Johan Hovold > Signed-off-by: David S. Miller > [only take helper function for 4.4.y - gregkh] > > # make -sk KBUILD_BUILD_USER=TuxBuild -C/linux -j16 ARCH=arm > CROSS_COMPILE=arm-linux-gnueabihf- HOSTCC=gcc CC="sccache > arm-linux-gnueabihf-gcc" O=build zImage > 70 # > 71 ../drivers/of/of_mdio.c: In function ‘of_phy_deregister_fixed_link’: > 72 ../drivers/of/of_mdio.c:379:2: error: implicit declaration of > function ‘fixed_phy_unregister’; did you mean ‘fixed_phy_register’? > [-Werror=implicit-function-declaration] > 73 379 | fixed_phy_unregister(phydev); > 74 | ^~~~~~~~~~~~~~~~~~~~ > 75 | fixed_phy_register > 76 ../drivers/of/of_mdio.c:381:22: error: ‘struct phy_device’ has no > member named ‘mdio’; did you mean ‘mdix’? > 77 381 | put_device(&phydev->mdio.dev); /* of_phy_find_device() */ > 78 | ^~~~ > 79 | mdix Another dependency: 5bcbe0f35fb1 ("phy: fixed: Fix removal of phys.") Greg, these patches are from four years ago so can't really remember if there are other dependencies or reasons against backporting them (the missing stable tags are per Dave's preference), sorry. The cover letter also mentions another dependency, but that may just have been some context conflict. Perhaps you better drop these unless you want to review them closer. Johan