* [PATCH fixes] powerpc/vdso32: Fallback on getres syscall when clock is unknown
@ 2020-05-09 9:42 Christophe Leroy
2020-05-10 22:15 ` Aurelien Jarno
2020-05-13 12:43 ` Michael Ellerman
0 siblings, 2 replies; 3+ messages in thread
From: Christophe Leroy @ 2020-05-09 9:42 UTC (permalink / raw)
To: Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman,
Aurelien Jarno
Cc: linuxppc-dev, linux-kernel
There are other clocks than the standard ones, for instance
per process clocks. Therefore, being above the last standard clock
doesn't mean it is a bad clock. So, fallback to syscall instead
of returning -EINVAL inconditionaly.
Fixes: e33ffc956b08 ("powerpc/vdso32: implement clock_getres entirely")
Cc: stable@vger.kernel.org
Reported-by: Aurelien Jarno <aurelien@aurel32.net>
Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
---
arch/powerpc/kernel/vdso32/gettimeofday.S | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/powerpc/kernel/vdso32/gettimeofday.S b/arch/powerpc/kernel/vdso32/gettimeofday.S
index a3951567118a..e7f8f9f1b3f4 100644
--- a/arch/powerpc/kernel/vdso32/gettimeofday.S
+++ b/arch/powerpc/kernel/vdso32/gettimeofday.S
@@ -218,11 +218,11 @@ V_FUNCTION_BEGIN(__kernel_clock_getres)
blr
/*
- * invalid clock
+ * syscall fallback
*/
99:
- li r3, EINVAL
- crset so
+ li r0,__NR_clock_getres
+ sc
blr
.cfi_endproc
V_FUNCTION_END(__kernel_clock_getres)
--
2.25.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH fixes] powerpc/vdso32: Fallback on getres syscall when clock is unknown
2020-05-09 9:42 [PATCH fixes] powerpc/vdso32: Fallback on getres syscall when clock is unknown Christophe Leroy
@ 2020-05-10 22:15 ` Aurelien Jarno
2020-05-13 12:43 ` Michael Ellerman
1 sibling, 0 replies; 3+ messages in thread
From: Aurelien Jarno @ 2020-05-10 22:15 UTC (permalink / raw)
To: Christophe Leroy; +Cc: linuxppc-dev, Paul Mackerras, linux-kernel
Hi,
On 2020-05-09 09:42, Christophe Leroy wrote:
> There are other clocks than the standard ones, for instance
> per process clocks. Therefore, being above the last standard clock
> doesn't mean it is a bad clock. So, fallback to syscall instead
> of returning -EINVAL inconditionaly.
>
> Fixes: e33ffc956b08 ("powerpc/vdso32: implement clock_getres entirely")
> Cc: stable@vger.kernel.org
> Reported-by: Aurelien Jarno <aurelien@aurel32.net>
> Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
> ---
> arch/powerpc/kernel/vdso32/gettimeofday.S | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/powerpc/kernel/vdso32/gettimeofday.S b/arch/powerpc/kernel/vdso32/gettimeofday.S
> index a3951567118a..e7f8f9f1b3f4 100644
> --- a/arch/powerpc/kernel/vdso32/gettimeofday.S
> +++ b/arch/powerpc/kernel/vdso32/gettimeofday.S
> @@ -218,11 +218,11 @@ V_FUNCTION_BEGIN(__kernel_clock_getres)
> blr
>
> /*
> - * invalid clock
> + * syscall fallback
> */
> 99:
> - li r3, EINVAL
> - crset so
> + li r0,__NR_clock_getres
> + sc
> blr
> .cfi_endproc
> V_FUNCTION_END(__kernel_clock_getres)
Thanks a lot for the fast answer. I have just tested this patch and I
confirm it fixes the issue.
Tested-by: Aurelien Jarno <aurelien@aurel32.net>
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH fixes] powerpc/vdso32: Fallback on getres syscall when clock is unknown
2020-05-09 9:42 [PATCH fixes] powerpc/vdso32: Fallback on getres syscall when clock is unknown Christophe Leroy
2020-05-10 22:15 ` Aurelien Jarno
@ 2020-05-13 12:43 ` Michael Ellerman
1 sibling, 0 replies; 3+ messages in thread
From: Michael Ellerman @ 2020-05-13 12:43 UTC (permalink / raw)
To: Aurelien Jarno, Michael Ellerman, Benjamin Herrenschmidt,
Paul Mackerras, Christophe Leroy
Cc: linuxppc-dev, linux-kernel
On Sat, 9 May 2020 09:42:14 +0000 (UTC), Christophe Leroy wrote:
> There are other clocks than the standard ones, for instance
> per process clocks. Therefore, being above the last standard clock
> doesn't mean it is a bad clock. So, fallback to syscall instead
> of returning -EINVAL inconditionaly.
Applied to powerpc/fixes.
[1/1] powerpc/vdso32: Fallback on getres syscall when clock is unknown
https://git.kernel.org/powerpc/c/e963b7a28b2bf2416304e1a15df967fcf662aff5
cheers
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-13 12:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-09 9:42 [PATCH fixes] powerpc/vdso32: Fallback on getres syscall when clock is unknown Christophe Leroy
2020-05-10 22:15 ` Aurelien Jarno
2020-05-13 12:43 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).