From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35C8AC54E4B for ; Tue, 12 May 2020 08:10:16 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A8FAC2078E for ; Tue, 12 May 2020 08:10:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A8FAC2078E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 49Lr835321zDqlS for ; Tue, 12 May 2020 18:10:11 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lst.de (client-ip=213.95.11.211; helo=verein.lst.de; envelope-from=hch@lst.de; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=lst.de Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 49Lr662bnrzDqlQ for ; Tue, 12 May 2020 18:08:28 +1000 (AEST) Received: by verein.lst.de (Postfix, from userid 2407) id 1BC1368BEB; Tue, 12 May 2020 10:08:21 +0200 (CEST) Date: Tue, 12 May 2020 10:08:20 +0200 From: Christoph Hellwig To: Dan Williams Subject: Re: remove a few uses of ->queuedata Message-ID: <20200512080820.GA2336@lst.de> References: <20200508161517.252308-1-hch@lst.de> <20200509082352.GB21834@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jens Axboe , linux-xtensa@linux-xtensa.org, linux-raid , Sergey Senozhatsky , linux-nvdimm , Geoff Levand , Linux Kernel Mailing List , Jim Paris , Joshua Morris , linux-block@vger.kernel.org, Minchan Kim , linux-m68k@lists.linux-m68k.org, Philip Kelleher , linux-bcache@vger.kernel.org, linuxppc-dev , Christoph Hellwig , Nitin Gupta , drbd-dev@lists.linbit.com Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Sat, May 09, 2020 at 08:07:14AM -0700, Dan Williams wrote: > > which are all used in the I/O submission path (generic_make_request / > > generic_make_request_checks). This is mostly a prep cleanup patch to > > also remove the pointless queue argument from ->make_request - then > > ->queue is an extra dereference and extra churn. > > Ah ok. If the changelogs had been filled in with something like "In > preparation for removing @q from make_request_fn, stop using > ->queuedata", I probably wouldn't have looked twice. > > For the nvdimm/ driver updates you can add: > > Reviewed-by: Dan Williams > > ...or just let me know if you want me to pick those up through the nvdimm tree. I'd love you to pick them up through the nvdimm tree. Do you want to fix up the commit message yourself?