From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 852B0C433E0 for ; Sat, 16 May 2020 05:24:17 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D369E206F4 for ; Sat, 16 May 2020 05:24:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OVKlP/qq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D369E206F4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 49PDGj6NVGzDr3k for ; Sat, 16 May 2020 15:24:13 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::743; helo=mail-qk1-x743.google.com; envelope-from=leobras.c@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=OVKlP/qq; dkim-atps=neutral Received: from mail-qk1-x743.google.com (mail-qk1-x743.google.com [IPv6:2607:f8b0:4864:20::743]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 49PDDf2l4hzDr2s for ; Sat, 16 May 2020 15:22:25 +1000 (AEST) Received: by mail-qk1-x743.google.com with SMTP id f83so4874707qke.13 for ; Fri, 15 May 2020 22:22:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=iGai4hOvcQ9X3rtvTu3xZbDmHCYKbPB2sPDJuutDN9E=; b=OVKlP/qqpZdmsf2tmTqEGRjDtoIzlzp7QDEAlSZJozB+bfjOEpv2EZPc3iSRlE4eFx BP0ajzFElW7XkBk+fLUuMj1p3nG4JmNugl+oNFgMuMZP+LqBNl+J8j0+dvhd+EcRuenv B9YgNDoRY/mLNlhBn32GouMCwFWokD2ahgaarRmnZMKqZkvqz5pRdkuF4Wk7eGzgQJ46 cb+f7/mqxuobpmyl3yoik2ji4SH65u1D6wigyqNngMPq6buJunXhJOD10O5rVTmeiQg/ h90TqTsrSIp9zmMET66Cmp+L3ZzZH4iqNv8US8oaP75AJB2DBQP3pU/bMimx5yEAqyC8 7ZsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=iGai4hOvcQ9X3rtvTu3xZbDmHCYKbPB2sPDJuutDN9E=; b=jeHpbatimuKR2lpfcUDRQMe7GmsT79aYgiiS/9uguwn8JwUuAgANanLi24qwk1lg15 GxkI0DRl0cjLFX98SrV20kIbs9vcoh2xeaV2z5ZptYKi0+nisltQMkRSiEj59AMool8X g5LYCYXOk3/A01HCWmU+m8r6ttZILTZMvJnEbz0VlxufBJ3yMDCiuKGhmehDOPBkj9Bg G1E95SmDC7VkOhXhR9GLKNHx9jhpsaXNvhGV+RbXlQI9sgMVuiUVvH8qAJQc+kRz/p6x ZYVvpUASMEhdQTsygLEbB1fY9pys+vMTcB1EPXOvMOf+utm0bbWfb7Nb1OzBkHmmtNsE +Xyg== X-Gm-Message-State: AOAM533EjoY82RVIalbACeryF3S/hdF4sN8VmE6skb50HmnH+MO07FfM 6G69oC4BsRHW8XXV1omxJvY= X-Google-Smtp-Source: ABdhPJyyPFsAmnSIf30NB7b8EAHziLzGnBKxyPDTj9U1kLHfm2i97HvSHeIU3NSBesChQIvVmdQ9fw== X-Received: by 2002:a37:4fd8:: with SMTP id d207mr6259763qkb.345.1589606541964; Fri, 15 May 2020 22:22:21 -0700 (PDT) Received: from LeoBras.aus.stglabs.ibm.com (179-125-143-209.dynamic.desktop.com.br. [179.125.143.209]) by smtp.gmail.com with ESMTPSA id u20sm3866721qtj.97.2020.05.15.22.22.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2020 22:22:21 -0700 (PDT) From: Leonardo Bras To: Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Allison Randal , Greg Kroah-Hartman , Thomas Gleixner , Nicholas Piggin , Leonardo Bras , Nathan Lynch , "Gautham R. Shenoy" , Nadav Amit Subject: [PATCH v5 0/2] Implement reentrant rtas call Date: Sat, 16 May 2020 02:21:35 -0300 Message-Id: <20200516052137.175881-1-leobras.c@gmail.com> X-Mailer: git-send-email 2.25.4 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Patch 2 implement rtas_call_reentrant() for reentrant rtas-calls: "ibm,int-on", "ibm,int-off",ibm,get-xive" and "ibm,set-xive", according to LoPAPR Version 1.1 (March 24, 2016). For that, it's necessary that every call uses a different rtas buffer (rtas_args). Paul Mackerras suggested using the PACA structure for creating a per-cpu buffer for these calls. Patch 1 was necessary to make PACA have a 'struct rtas_args' member. Reentrant rtas calls can be useful to avoid deadlocks in crashing, where rtas-calls are needed, but some other thread crashed holding the rtas.lock. This is a backtrace of a deadlock from a kdump testing environment: #0 arch_spin_lock #1 lock_rtas () #2 rtas_call (token=8204, nargs=1, nret=1, outputs=0x0) #3 ics_rtas_mask_real_irq (hw_irq=4100) #4 machine_kexec_mask_interrupts #5 default_machine_crash_shutdown #6 machine_crash_shutdown #7 __crash_kexec #8 crash_kexec #9 oops_end Signed-off-by: Leonardo Bras --- Changes since v4: - Insted of having the full buffer on PACA, adds only a pointer and allocate it during allocate_paca(), making sure it's in a memory range available for RTAS (32-bit). (Thanks Nick Piggin!) Changes since v3: - Adds protection from preemption and interruption Changes since v2: - Fixed build failure from ppc64e, by including spinlock_types.h on rtas-types.h - Improved commit messages Changes since v1: - Moved buffer from stack to PACA (as suggested by Paul Mackerras) - Added missing output bits - Improve documentation following kernel-doc format (as suggested by Nathan Lynch) Leonardo Bras (2): powerpc/rtas: Move type/struct definitions from rtas.h into rtas-types.h powerpc/rtas: Implement reentrant rtas call arch/powerpc/include/asm/paca.h | 2 + arch/powerpc/include/asm/rtas-types.h | 126 ++++++++++++++++++++++++++ arch/powerpc/include/asm/rtas.h | 119 +----------------------- arch/powerpc/kernel/rtas.c | 42 +++++++++ arch/powerpc/sysdev/xics/ics-rtas.c | 22 ++--- 5 files changed, 183 insertions(+), 128 deletions(-) create mode 100644 arch/powerpc/include/asm/rtas-types.h -- 2.25.4