* [PATCH] powerpc: Fix misleading small cores print
@ 2020-05-28 23:07 Michael Neuling
2020-06-02 14:52 ` Gautham R Shenoy
2020-06-09 5:29 ` Michael Ellerman
0 siblings, 2 replies; 3+ messages in thread
From: Michael Neuling @ 2020-05-28 23:07 UTC (permalink / raw)
To: mpe; +Cc: Gautham R . Shenoy, Michael Neuling, linuxppc-dev
Currently when we boot on a big core system, we get this print:
[ 0.040500] Using small cores at SMT level
This is misleading as we've actually detected big cores.
This patch clears up the print to say we've detect big cores but are
using small cores for scheduling.
Signed-off-by: Michael Neuling <mikey@neuling.org>
---
arch/powerpc/kernel/smp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c
index 6d2a3a3666..c820c95162 100644
--- a/arch/powerpc/kernel/smp.c
+++ b/arch/powerpc/kernel/smp.c
@@ -1383,7 +1383,7 @@ void __init smp_cpus_done(unsigned int max_cpus)
#ifdef CONFIG_SCHED_SMT
if (has_big_cores) {
- pr_info("Using small cores at SMT level\n");
+ pr_info("Big cores detected but using small core scheduling\n");
power9_topology[0].mask = smallcore_smt_mask;
powerpc_topology[0].mask = smallcore_smt_mask;
}
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] powerpc: Fix misleading small cores print
2020-05-28 23:07 [PATCH] powerpc: Fix misleading small cores print Michael Neuling
@ 2020-06-02 14:52 ` Gautham R Shenoy
2020-06-09 5:29 ` Michael Ellerman
1 sibling, 0 replies; 3+ messages in thread
From: Gautham R Shenoy @ 2020-06-02 14:52 UTC (permalink / raw)
To: Michael Neuling; +Cc: linuxppc-dev, Gautham R . Shenoy
On Fri, May 29, 2020 at 09:07:31AM +1000, Michael Neuling wrote:
> Currently when we boot on a big core system, we get this print:
> [ 0.040500] Using small cores at SMT level
>
> This is misleading as we've actually detected big cores.
>
> This patch clears up the print to say we've detect big cores but are
> using small cores for scheduling.
Thanks for making the print more meaningful.
>
> Signed-off-by: Michael Neuling <mikey@neuling.org>
FWIW,
Acked-by: Gautham R. Shenoy <ego@linux.vnet.ibm.com>
> ---
> arch/powerpc/kernel/smp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c
> index 6d2a3a3666..c820c95162 100644
> --- a/arch/powerpc/kernel/smp.c
> +++ b/arch/powerpc/kernel/smp.c
> @@ -1383,7 +1383,7 @@ void __init smp_cpus_done(unsigned int max_cpus)
>
> #ifdef CONFIG_SCHED_SMT
> if (has_big_cores) {
> - pr_info("Using small cores at SMT level\n");
> + pr_info("Big cores detected but using small core scheduling\n");
> power9_topology[0].mask = smallcore_smt_mask;
> powerpc_topology[0].mask = smallcore_smt_mask;
> }
> --
> 2.26.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] powerpc: Fix misleading small cores print
2020-05-28 23:07 [PATCH] powerpc: Fix misleading small cores print Michael Neuling
2020-06-02 14:52 ` Gautham R Shenoy
@ 2020-06-09 5:29 ` Michael Ellerman
1 sibling, 0 replies; 3+ messages in thread
From: Michael Ellerman @ 2020-06-09 5:29 UTC (permalink / raw)
To: mpe, Michael Neuling; +Cc: Gautham R . Shenoy, linuxppc-dev
On Fri, 29 May 2020 09:07:31 +1000, Michael Neuling wrote:
> Currently when we boot on a big core system, we get this print:
> [ 0.040500] Using small cores at SMT level
>
> This is misleading as we've actually detected big cores.
>
> This patch clears up the print to say we've detect big cores but are
> using small cores for scheduling.
Applied to powerpc/next.
[1/1] powerpc: Fix misleading small cores print
https://git.kernel.org/powerpc/c/82a7cebdd95cffa55449d6c1d97cc9b743a66056
cheers
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-06-09 6:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-28 23:07 [PATCH] powerpc: Fix misleading small cores print Michael Neuling
2020-06-02 14:52 ` Gautham R Shenoy
2020-06-09 5:29 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).