From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90F3CC433E0 for ; Wed, 3 Jun 2020 15:13:49 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4B7E7206E6 for ; Wed, 3 Jun 2020 15:13:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4B7E7206E6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 49cXVg1MFWzDqf4 for ; Thu, 4 Jun 2020 01:13:47 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=bootlin.com (client-ip=217.70.178.230; helo=relay10.mail.gandi.net; envelope-from=miquel.raynal@bootlin.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=bootlin.com Received: from relay10.mail.gandi.net (relay10.mail.gandi.net [217.70.178.230]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 49cVv91QSnzDqRX for ; Thu, 4 Jun 2020 00:01:24 +1000 (AEST) Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 07A2D24001B; Wed, 3 Jun 2020 14:01:18 +0000 (UTC) Date: Wed, 3 Jun 2020 16:01:17 +0200 From: Miquel Raynal To: Boris Brezillon Subject: Re: [PATCH 07/10] mtd: rawnand: fsl_upm: Inherit from nand_controller Message-ID: <20200603160117.5693606b@xps13> In-Reply-To: <20200603134922.1352340-8-boris.brezillon@collabora.com> References: <20200603134922.1352340-1-boris.brezillon@collabora.com> <20200603134922.1352340-8-boris.brezillon@collabora.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vignesh Raghavendra , Tudor Ambarus , Anton Vorontsov , Richard Weinberger , linux-mtd@lists.infradead.org, Paul Mackerras , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Boris Brezillon wrote on Wed, 3 Jun 2020 15:49:19 +0200: > Explicitly inherit from nand_controller instead of relying on the > nand_chip.legacy.dummy_controller field. > > Signed-off-by: Boris Brezillon > --- > drivers/mtd/nand/raw/fsl_upm.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/mtd/nand/raw/fsl_upm.c b/drivers/mtd/nand/raw/fsl_upm.c > index 977b7aad419b..9a63e36825d8 100644 > --- a/drivers/mtd/nand/raw/fsl_upm.c > +++ b/drivers/mtd/nand/raw/fsl_upm.c > @@ -24,6 +24,7 @@ > #define FSL_UPM_WAIT_WRITE_BUFFER 0x4 > > struct fsl_upm_nand { > + struct nand_controller base; > struct device *dev; > struct nand_chip chip; > int last_ctrl; > @@ -167,6 +168,7 @@ static int fun_chip_init(struct fsl_upm_nand *fun, > if (!fun->rnb_gpio[0]) > fun->chip.legacy.dev_ready = fun_chip_ready; > > + fun->chip.controller = &fun->base; > mtd->dev.parent = fun->dev; > > flash_np = of_get_next_child(upm_np, NULL); > @@ -268,6 +270,7 @@ static int fun_probe(struct platform_device *ofdev) > fun->wait_flags = FSL_UPM_WAIT_RUN_PATTERN | > FSL_UPM_WAIT_WRITE_BYTE; > > + nand_controller_init(&fun->base); > fun->dev = &ofdev->dev; > fun->last_ctrl = NAND_CLE; > Reviewed-by: Miquel Raynal