* [PATCH] powerpc/spufs: fix the type of ret in spufs_arch_write_note
@ 2020-06-10 8:55 Christoph Hellwig
2020-07-24 13:24 ` Michael Ellerman
0 siblings, 1 reply; 2+ messages in thread
From: Christoph Hellwig @ 2020-06-10 8:55 UTC (permalink / raw)
To: jk, arnd, mpe; +Cc: linuxppc-dev, kbuild test robot
Both the ->dump method and snprintf return an int. So switch to an
int and properly handle errors from ->dump.
Fixes: 5456ffdee666 ("powerpc/spufs: simplify spufs core dumping")
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
arch/powerpc/platforms/cell/spufs/coredump.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/cell/spufs/coredump.c b/arch/powerpc/platforms/cell/spufs/coredump.c
index 3b75e8f60609cb..014d1c045bc3cf 100644
--- a/arch/powerpc/platforms/cell/spufs/coredump.c
+++ b/arch/powerpc/platforms/cell/spufs/coredump.c
@@ -105,7 +105,7 @@ static int spufs_arch_write_note(struct spu_context *ctx, int i,
size_t sz = spufs_coredump_read[i].size;
char fullname[80];
struct elf_note en;
- size_t ret;
+ int ret;
sprintf(fullname, "SPU/%d/%s", dfd, spufs_coredump_read[i].name);
en.n_namesz = strlen(fullname) + 1;
--
2.26.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] powerpc/spufs: fix the type of ret in spufs_arch_write_note
2020-06-10 8:55 [PATCH] powerpc/spufs: fix the type of ret in spufs_arch_write_note Christoph Hellwig
@ 2020-07-24 13:24 ` Michael Ellerman
0 siblings, 0 replies; 2+ messages in thread
From: Michael Ellerman @ 2020-07-24 13:24 UTC (permalink / raw)
To: jk, arnd, Christoph Hellwig, mpe; +Cc: linuxppc-dev, kbuild test robot
On Wed, 10 Jun 2020 10:55:54 +0200, Christoph Hellwig wrote:
> Both the ->dump method and snprintf return an int. So switch to an
> int and properly handle errors from ->dump.
Applied to powerpc/next.
[1/1] powerpc/spufs: Fix the type of ret in spufs_arch_write_note
https://git.kernel.org/powerpc/c/7c7ff885c7bce40a487e41c68f1dac14dd2c8033
cheers
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-24 14:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-06-10 8:55 [PATCH] powerpc/spufs: fix the type of ret in spufs_arch_write_note Christoph Hellwig
2020-07-24 13:24 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).