From: Balamuruhan S <bala24@linux.ibm.com>
To: mpe@ellerman.id.au
Cc: ravi.bangoria@linux.ibm.com, jniethe5@gmail.com,
Balamuruhan S <bala24@linux.ibm.com>,
paulus@samba.org, sandipan@linux.ibm.com,
naveen.n.rao@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org
Subject: [PATCH 2/6] powerpc test_emulate_step: fix pr_info() to print 8-byte for prefixed instruction
Date: Mon, 22 Jun 2020 12:39:37 +0530 [thread overview]
Message-ID: <20200622070941.759307-3-bala24@linux.ibm.com> (raw)
In-Reply-To: <20200622070941.759307-1-bala24@linux.ibm.com>
On test failure, `pr_log()` prints 4 bytes instruction
irrespective of word/prefix instruction, fix it by printing
them appropriately.
Signed-off-by: Balamuruhan S <bala24@linux.ibm.com>
---
arch/powerpc/lib/test_emulate_step.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/lib/test_emulate_step.c b/arch/powerpc/lib/test_emulate_step.c
index d5902b7b4e5c..e3b1797adfae 100644
--- a/arch/powerpc/lib/test_emulate_step.c
+++ b/arch/powerpc/lib/test_emulate_step.c
@@ -1225,7 +1225,14 @@ static int __init emulate_compute_instr(struct pt_regs *regs,
if (analyse_instr(&op, regs, instr) != 1 ||
GETTYPE(op.type) != COMPUTE) {
- pr_info("emulation failed, instruction = 0x%08x\n", ppc_inst_val(instr));
+ if (!ppc_inst_prefixed(instr)) {
+ pr_info("emulation failed, instruction = 0x%08x\n",
+ ppc_inst_val(instr));
+ } else {
+ pr_info("emulation failed, instruction = 0x%08x 0x%08x\n",
+ ppc_inst_val(instr),
+ ppc_inst_suffix(instr));
+ }
return -EFAULT;
}
--
2.24.1
next prev parent reply other threads:[~2020-06-22 7:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-22 7:09 [PATCH 0/6] Prefixed instruction tests to cover negative cases Balamuruhan S
2020-06-22 7:09 ` [PATCH 1/6] powerpc test_emulate_step: update nip with patched instruction address Balamuruhan S
2020-06-22 23:41 ` Jordan Niethe
2020-06-22 7:09 ` Balamuruhan S [this message]
2020-06-22 23:49 ` [PATCH 2/6] powerpc test_emulate_step: fix pr_info() to print 8-byte for prefixed instruction Jordan Niethe
2020-06-22 7:09 ` [PATCH 3/6] powerpc test_emulate_step: enhancement to test negative scenarios Balamuruhan S
2020-06-22 9:34 ` Sandipan Das
2020-06-22 7:09 ` [PATCH 4/6] powerpc test_emulate_step: add negative tests for prefixed addi Balamuruhan S
2020-06-22 7:09 ` [PATCH 5/6] powerpc sstep: introduce macros to retrieve Prefix instruction operands Balamuruhan S
2020-06-22 7:09 ` [PATCH 6/6] powerpc test_emulate_step: move extern declaration to sstep.h Balamuruhan S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200622070941.759307-3-bala24@linux.ibm.com \
--to=bala24@linux.ibm.com \
--cc=jniethe5@gmail.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=paulus@samba.org \
--cc=ravi.bangoria@linux.ibm.com \
--cc=sandipan@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).