From: Nathan Chancellor <natechancellor@gmail.com>
To: Geoff Levand <geoff@infradead.org>
Cc: linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com,
Paul Mackerras <paulus@samba.org>, Joel Stanley <joel@jms.id.au>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/boot: Use address-of operator on section symbols
Date: Wed, 24 Jun 2020 19:22:28 -0700 [thread overview]
Message-ID: <20200625022228.GA2871607@ubuntu-n2-xlarge-x86> (raw)
In-Reply-To: <1bbb6956-d9de-e0c8-5b45-20b6fecc2189@infradead.org>
Hi Geoff,
On Wed, Jun 24, 2020 at 06:18:48PM -0700, Geoff Levand wrote:
> Hi Nathan,
>
> On 6/23/20 8:59 PM, Nathan Chancellor wrote:
> > These are not true arrays, they are linker defined symbols, which are
> > just addresses. Using the address of operator silences the warning
> > and does not change the resulting assembly with either clang/ld.lld
> > or gcc/ld (tested with diff + objdump -Dr).
>
> Thanks for your patch. I tested this patch applied to v5.8-rc2 on a
> PS3 and it seems OK.
>
> Tested-by: Geoff Levand <geoff@infradead.org>
Thanks a lot for the quick response and testing, I really appreciate it!
Cheers,
Nathan
next prev parent reply other threads:[~2020-06-25 2:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-24 3:59 [PATCH] powerpc/boot: Use address-of operator on section symbols Nathan Chancellor
2020-06-25 1:18 ` Geoff Levand
2020-06-25 2:22 ` Nathan Chancellor [this message]
2020-06-25 16:32 ` Nick Desaulniers
2020-07-18 9:13 ` Arnd Bergmann
2020-07-16 12:56 ` Michael Ellerman
2020-07-18 7:50 ` Geert Uytterhoeven
2020-07-18 15:31 ` Nathan Chancellor
2020-07-20 21:02 ` Segher Boessenkool
2020-08-03 10:06 ` Geert Uytterhoeven
2020-08-03 11:09 ` Michael Ellerman
2020-08-03 11:32 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200625022228.GA2871607@ubuntu-n2-xlarge-x86 \
--to=natechancellor@gmail.com \
--cc=clang-built-linux@googlegroups.com \
--cc=geoff@infradead.org \
--cc=joel@jms.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).