From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46BC0C433DF for ; Thu, 25 Jun 2020 20:48:55 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E72E82072E for ; Thu, 25 Jun 2020 20:48:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=fieldses.org header.i=@fieldses.org header.b="gj0MuGKT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E72E82072E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=fieldses.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 49tBv90fzFzDqx4 for ; Fri, 26 Jun 2020 06:48:53 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=fieldses.org (client-ip=2600:3c00:e000:2f7::1; helo=fieldses.org; envelope-from=bfields@fieldses.org; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=fieldses.org Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=fieldses.org header.i=@fieldses.org header.a=rsa-sha256 header.s=default header.b=gj0MuGKT; dkim-atps=neutral X-Greylist: delayed 336 seconds by postgrey-1.36 at bilbo; Fri, 26 Jun 2020 06:46:11 AEST Received: from fieldses.org (fieldses.org [IPv6:2600:3c00:e000:2f7::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 49tBr31T4jzDqd7 for ; Fri, 26 Jun 2020 06:46:10 +1000 (AEST) Received: by fieldses.org (Postfix, from userid 2815) id 1C8E879A1; Thu, 25 Jun 2020 16:40:29 -0400 (EDT) DKIM-Filter: OpenDKIM Filter v2.11.0 fieldses.org 1C8E879A1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fieldses.org; s=default; t=1593117629; bh=grAX8yggjJQZeEuTqT849+RECeUjWPrYL7L8CDwHWzM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gj0MuGKTpqfBnugVSHAllzwtU32mbRNrz5LhpqXoB8FX/dI6FdoUiXA6zXnyorll9 J8Wg0vYTe1AOKJQyhZwkkl/QiRqNB70nQBPja5EppPVNzeFep+Z8g/ySzPNxVjIaPi XVxnHn82AD79SvIa9xchcmtUWE/pnD9cata6TvZo= Date: Thu, 25 Jun 2020 16:40:29 -0400 From: Bruce Fields To: Chuck Lever Subject: Re: [PATCH v2] SUNRPC: Add missing definition of ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE Message-ID: <20200625204029.GD6605@fieldses.org> References: <9e9882a2fb57b6f9d98a0a5d8b6bf9cff9fcbd93.1592202173.git.christophe.leroy@csgroup.eu> <733E4CAF-A9E5-491F-B0C7-69CA84E5DFA5@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <733E4CAF-A9E5-491F-B0C7-69CA84E5DFA5@oracle.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux NFS Mailing List , netdev , Linux Kernel Mailing List , Trond Myklebust , Anna Schumaker , Jakub Kicinski , linuxppc-dev@lists.ozlabs.org, "David S. Miller" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, Jun 15, 2020 at 08:33:40AM -0400, Chuck Lever wrote: > > > > On Jun 15, 2020, at 2:25 AM, Christophe Leroy wrote: > > > > Even if that's only a warning, not including asm/cacheflush.h > > leads to svc_flush_bvec() being empty allthough powerpc defines > > ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE. > > > > CC net/sunrpc/svcsock.o > > net/sunrpc/svcsock.c:227:5: warning: "ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE" is not defined [-Wundef] > > #if ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE > > ^ > > > > Include linux/highmem.h so that asm/cacheflush.h will be included. > > > > Reported-by: Christophe Leroy > > Reported-by: kernel test robot > > Cc: Chuck Lever > > Fixes: ca07eda33e01 ("SUNRPC: Refactor svc_recvfrom()") > > Signed-off-by: Christophe Leroy > > LGTM. > > Acked-by: Chuck Lever Thanks, applying for 5.8.--b.