From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FCDCC433DF for ; Thu, 25 Jun 2020 21:37:55 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 784BD20791 for ; Thu, 25 Jun 2020 21:37:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FDoOD71A" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 784BD20791 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 49tCzh3RbrzDr0p for ; Fri, 26 Jun 2020 07:37:52 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::442; helo=mail-pf1-x442.google.com; envelope-from=shorne@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=FDoOD71A; dkim-atps=neutral Received: from mail-pf1-x442.google.com (mail-pf1-x442.google.com [IPv6:2607:f8b0:4864:20::442]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 49tCXn422szDqw0 for ; Fri, 26 Jun 2020 07:17:56 +1000 (AEST) Received: by mail-pf1-x442.google.com with SMTP id u5so3634115pfn.7 for ; Thu, 25 Jun 2020 14:17:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=CYdo0/N2hPQ38RsTOzG1HX78I9n3NR49FO824e6zLtQ=; b=FDoOD71AUBcdqMd1QpOGzqSOfHIfeqUX9WRT2uVYBig3mcL8Etxvpb8vKA19DXCEHk hGGyn1qQff5t9NyGd0lso3F1GiQRnyM9Thb1X3Q9nK5u7AM24Qpc5yMKBaX3ULrGDdmI aW3HUYFlAs8muNXQr2XbluBC6XcTXX0ykUXQ1EzqTydZoE90RxOfVwphYK6gTw5MJDP9 mgw88O7NpAvmCyIxt25IifP2Bt29eyhNzOX/15SZvv0sU/nuxlLY/V8fYEtI3N0b3pKT gp2NuMwvUxbTosGypDo6A5687Z6EsY8/j4IN6ojCLjAHh/Y+rVlTIkural2QcqlX4Tvf Rmrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=CYdo0/N2hPQ38RsTOzG1HX78I9n3NR49FO824e6zLtQ=; b=l3301WUVI4xp2doqWGzznAZEMVQqqQH0DXG12oUHciMkr15sGxhHY0EZ41Jk3A4K3F dwDFo8cCZL/PLuJ9SyoIvIuclzhagBG5aexaETjVshAK1z04AYSzPvYtnLa1Usvmrv6S 13K/oUsmSBshPXa9mggS+7fO1nWPzSEVwwT+cgZW8jIeVv3hIQcAHEBDu7LwcVNWRzHW XBc3yUIFCNmGq2T/71nhGGbahc/BfjswaASbiFjbSmIfv3DHi9q55a/9YMRBWSgs8zyv c2FTbLZvLuA2qAsCTgsmi04IvCXrRUVcFfN56RTO4gkTnKyTweEfjfYBI9AV+Gm+le58 VTKg== X-Gm-Message-State: AOAM5330OrULj1dxecVhiv94y53KT4urzL8MXWSbP/cIQ8ftWSfPTkzV G6MHD1ZDz45uYILzlFc+iiw= X-Google-Smtp-Source: ABdhPJzJyZJ3I3aIXnZZyRAyJOt5+B79P9o0RtXQJRVeujxKDOJjiVciYAKydYrmNHnRZVpci1OEig== X-Received: by 2002:a62:8c12:: with SMTP id m18mr36470728pfd.111.1593119872858; Thu, 25 Jun 2020 14:17:52 -0700 (PDT) Received: from localhost (g2.222-224-226.ppp.wakwak.ne.jp. [222.224.226.2]) by smtp.gmail.com with ESMTPSA id l2sm9885953pjl.34.2020.06.25.14.17.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2020 14:17:52 -0700 (PDT) Date: Fri, 26 Jun 2020 06:17:49 +0900 From: Stafford Horne To: Christian Brauner Subject: Re: [PATCH 17/17] arch: rename copy_thread_tls() back to copy_thread() Message-ID: <20200625211749.GH1401039@lianli.shorne-pla.net> References: <20200622234326.906346-1-christian.brauner@ubuntu.com> <20200622234326.906346-18-christian.brauner@ubuntu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200622234326.906346-18-christian.brauner@ubuntu.com> X-Mailman-Approved-At: Fri, 26 Jun 2020 07:36:16 +1000 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rich Felker , linux-sh@vger.kernel.org, "Peter Zijlstra \(Intel\)" , Catalin Marinas , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Max Filippov , Guo Ren , "Matthew Wilcox \(Oracle\)" , "H. Peter Anvin" , sparclinux@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-riscv@lists.infradead.org, Vincent Chen , Will Deacon , Anton Ivanov , Jonas Bonn , linux-s390@vger.kernel.org, linux-ia64@vger.kernel.org, linux-c6x-dev@linux-c6x.org, Brian Cain , linux-xtensa@linux-xtensa.org, Helge Deller , x86@kernel.org, Russell King , Ley Foon Tan , Christian Borntraeger , Ingo Molnar , Geert Uytterhoeven , linux-parisc@vger.kernel.org, Mark Salter , linux-csky@vger.kernel.org, Matt Turner , linux-snps-arc@lists.infradead.org, uclinux-h8-devel@lists.sourceforge.jp, Fenghua Yu , Albert Ou , Kees Cook , Jeff Dike , linux-alpha@vger.kernel.org, linux-um@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, Aurelien Jacquiot , linux-m68k@lists.linux-m68k.org, Thomas Bogendoerfer , Ivan Kokshaysky , Greentime Hu , Paul Walmsley , Thomas Gleixner , Stefan Kristiansson , Guan Xuetao , linux-arm-kernel@lists.infradead.org, Richard Henderson , Chris Zankel , Michal Simek , Tony Luck , Yoshinori Sato , Nick Hu , Vineet Gupta , linux-kernel@vger.kernel.org, openrisc@lists.librecores.org, Palmer Dabbelt , Richard Weinberger , Paul Mackerras , Linus Torvalds , "David S. Miller" , Al Viro Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, Jun 23, 2020 at 01:43:26AM +0200, Christian Brauner wrote: > diff --git a/arch/openrisc/kernel/process.c b/arch/openrisc/kernel/process.c > index d7010e72450c..19045a3efb8a 100644 > --- a/arch/openrisc/kernel/process.c > +++ b/arch/openrisc/kernel/process.c > @@ -116,7 +116,7 @@ void release_thread(struct task_struct *dead_task) > extern asmlinkage void ret_from_fork(void); > > /* > - * copy_thread_tls > + * copy_thread > * @clone_flags: flags > * @usp: user stack pointer or fn for kernel thread > * @arg: arg to fn for kernel thread; always NULL for userspace thread > @@ -147,7 +147,7 @@ extern asmlinkage void ret_from_fork(void); > */ > > int > -copy_thread_tls(unsigned long clone_flags, unsigned long usp, > +copy_thread(unsigned long clone_flags, unsigned long usp, > unsigned long arg, struct task_struct *p, unsigned long tls) > { For the OpenRISC bit. Acked-by: Stafford Horne Also, I would agree with what Kees mentioned about aligning the parameters. Sure that would be more work but it would be appreciated. -Stafford