From: Kees Cook <keescook@chromium.org>
To: Brendan Higgins <brendanhiggins@google.com>
Cc: linux-doc@vger.kernel.org, catalin.marinas@arm.com,
jcmvbkbc@gmail.com, will@kernel.org, paulus@samba.org,
linux-kselftest@vger.kernel.org, frowand.list@gmail.com,
anton.ivanov@cambridgegreys.com, linux-arch@vger.kernel.org,
richard@nod.at, rppt@linux.ibm.com, yzaikin@google.com,
linux-xtensa@linux-xtensa.org, arnd@arndb.de, jdike@addtoit.com,
linux-um@lists.infradead.org, linuxppc-dev@lists.ozlabs.org,
davidgow@google.com, skhan@linuxfoundation.org,
linux-arm-kernel@lists.infradead.org, kunit-dev@googlegroups.com,
chris@zankel.net, monstr@monstr.eu, sboyd@kernel.org,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
mcgrof@kernel.org, alan.maguire@oracle.com,
akpm@linux-foundation.org, logang@deltatee.com
Subject: Re: [PATCH v5 00/12] kunit: create a centralized executor to dispatch all KUnit tests
Date: Fri, 26 Jun 2020 14:52:37 -0700 [thread overview]
Message-ID: <202006261442.5C245709@keescook> (raw)
In-Reply-To: <20200626210917.358969-1-brendanhiggins@google.com>
On Fri, Jun 26, 2020 at 02:09:05PM -0700, Brendan Higgins wrote:
> This patchset adds a centralized executor to dispatch tests rather than
> relying on late_initcall to schedule each test suite separately along
> with a couple of new features that depend on it.
So, the new section looks fine to me (modulo the INIT_DATA change). The
plumbing to start the tests, though, I think is redundant. Why not just
add a sysctl that starts all known tests?
That way you don't need the plumbing into init/main.c, and you can have
a mode where builtin tests can be started on a fully booted system too.
i.e. boot with "sysctl.kernel.kunit=start" or when fully booted with
"echo start > /proc/sys/kernel/kunit"
And instead of the kunit-specific halt/reboot stuff, how about moving
/proc/sysrq-trigger into /proc/sys instead? Then you (or anything) could
do:
sysctl.kernel.kunit=start sysctl.kernel.sysrq-trigger=b
--
Kees Cook
next prev parent reply other threads:[~2020-06-26 21:56 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-26 21:09 [PATCH v5 00/12] kunit: create a centralized executor to dispatch all KUnit tests Brendan Higgins
2020-06-26 21:09 ` [PATCH v5 01/12] vmlinux.lds.h: add linker section for KUnit test suites Brendan Higgins
2020-06-26 21:20 ` Kees Cook
2020-06-26 21:22 ` Brendan Higgins
2020-07-08 4:31 ` Luis Chamberlain
2020-08-04 20:03 ` Brendan Higgins
2020-06-26 21:09 ` [PATCH v5 02/12] arch: arm64: " Brendan Higgins
2020-06-26 21:20 ` Kees Cook
2020-06-26 21:23 ` Brendan Higgins
2020-06-26 21:09 ` [PATCH v5 03/12] arch: microblaze: " Brendan Higgins
2020-06-26 21:09 ` [PATCH v5 04/12] arch: powerpc: " Brendan Higgins
2020-06-26 21:09 ` [PATCH v5 05/12] arch: um: " Brendan Higgins
2020-06-26 21:09 ` [PATCH v5 06/12] arch: xtensa: " Brendan Higgins
2020-06-26 21:30 ` Kees Cook
2020-06-26 21:09 ` [PATCH v5 07/12] kunit: test: create a single centralized executor for all tests Brendan Higgins
2020-06-26 21:29 ` Kees Cook
2020-08-04 20:06 ` Brendan Higgins
2020-06-26 21:09 ` [PATCH v5 08/12] init: main: add KUnit to kernel init Brendan Higgins
2020-06-26 21:33 ` Kees Cook
2020-07-08 4:38 ` Luis Chamberlain
2020-06-26 21:09 ` [PATCH v5 09/12] kunit: test: add test plan to KUnit TAP format Brendan Higgins
2020-06-26 21:35 ` Kees Cook
2020-08-04 20:10 ` Brendan Higgins
2020-06-26 21:09 ` [PATCH v5 10/12] kunit: Add 'kunit_shutdown' option Brendan Higgins
2020-06-26 21:40 ` Kees Cook
2020-08-04 20:18 ` Brendan Higgins
2020-06-26 21:09 ` [PATCH v5 11/12] Documentation: Add kunit_shutdown to kernel-parameters.txt Brendan Higgins
2020-06-26 21:09 ` [PATCH v5 12/12] Documentation: kunit: add a brief blurb about kunit_test_suite Brendan Higgins
2020-06-26 21:52 ` Kees Cook [this message]
2020-08-04 20:01 ` [PATCH v5 00/12] kunit: create a centralized executor to dispatch all KUnit tests Brendan Higgins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202006261442.5C245709@keescook \
--to=keescook@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=alan.maguire@oracle.com \
--cc=anton.ivanov@cambridgegreys.com \
--cc=arnd@arndb.de \
--cc=brendanhiggins@google.com \
--cc=catalin.marinas@arm.com \
--cc=chris@zankel.net \
--cc=davidgow@google.com \
--cc=frowand.list@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jcmvbkbc@gmail.com \
--cc=jdike@addtoit.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=logang@deltatee.com \
--cc=mcgrof@kernel.org \
--cc=monstr@monstr.eu \
--cc=paulus@samba.org \
--cc=richard@nod.at \
--cc=rppt@linux.ibm.com \
--cc=sboyd@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=will@kernel.org \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).