linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Boqun Feng <boqun.feng@gmail.com>,
	linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
	Michael Jeanson <mjeanson@efficios.com>
Subject: Re: Failure to build librseq on ppc
Date: Thu, 9 Jul 2020 15:31:18 -0500	[thread overview]
Message-ID: <20200709203118.GP3598@gate.crashing.org> (raw)
In-Reply-To: <1584179170.7410.1594316576293.JavaMail.zimbra@efficios.com>

On Thu, Jul 09, 2020 at 01:42:56PM -0400, Mathieu Desnoyers wrote:
> > That works fine then, for a testcase.  Using r17 is not a great idea for
> > performance (it increases the active register footprint, and causes more
> > registers to be saved in the prologue of the functions, esp. on older
> > compilers), and it is easier to just let the compiler choose a good
> > register to use.  But maybe you want to see r17 in the generated
> > testcases, as eyecatcher or something, dunno :-)
> 
> Just to make sure I understand your recommendation. So rather than
> hard coding r17 as the temporary registers, we could explicitly
> declare the temporary register as a C variable, pass it as an
> input operand to the inline asm, and then refer to it by operand
> name in the macros using it. This way the compiler would be free
> to perform its own register allocation.
> 
> If that is what you have in mind, then yes, I think it makes a
> lot of sense.

You write to it as well, so an inout register ("+r" or such).  And yes,
you use a local var for it (like "long tmp;").  And then you can refer
to it like anything else in your asm, like "%3" or like
"%[a_long_name]"; and the compiler sees it as any other register,
exactly.


Segher

  parent reply	other threads:[~2020-07-09 20:34 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-07 19:17 Failure to build librseq on ppc Mathieu Desnoyers
2020-07-08  0:59 ` Segher Boessenkool
2020-07-08 12:27   ` Michael Ellerman
2020-07-08 23:53     ` Segher Boessenkool
2020-07-09  0:01       ` Mathieu Desnoyers
2020-07-09  0:18         ` Segher Boessenkool
2020-07-09 13:43           ` Mathieu Desnoyers
2020-07-09 17:37             ` Segher Boessenkool
2020-07-09 17:42               ` Mathieu Desnoyers
2020-07-09 17:56                 ` Mathieu Desnoyers
2020-07-09 20:46                   ` Segher Boessenkool
2020-07-09 20:57                     ` Mathieu Desnoyers
2020-07-09 20:31                 ` Segher Boessenkool [this message]
2020-07-08 12:33   ` Mathieu Desnoyers
2020-07-08 14:00     ` Mathieu Desnoyers
2020-07-08 14:21       ` Christophe Leroy
2020-07-08 14:32         ` Mathieu Desnoyers
2020-07-08 16:11           ` Christophe Leroy
2020-07-09  0:15           ` Segher Boessenkool
2020-07-09  0:10       ` Segher Boessenkool
2020-07-09 13:33         ` Mathieu Desnoyers
2020-07-09 17:31           ` Segher Boessenkool

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200709203118.GP3598@gate.crashing.org \
    --to=segher@kernel.crashing.org \
    --cc=boqun.feng@gmail.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mjeanson@efficios.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).