From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A877C433E0 for ; Wed, 15 Jul 2020 06:41:12 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 29F0020663 for ; Wed, 15 Jul 2020 06:41:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="LSZT6nxj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 29F0020663 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4B677p3pNPzDqh2 for ; Wed, 15 Jul 2020 16:41:10 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linaro.org (client-ip=2a00:1450:4864:20::441; helo=mail-wr1-x441.google.com; envelope-from=lee.jones@linaro.org; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=LSZT6nxj; dkim-atps=neutral Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4B67261GFGzDqTq for ; Wed, 15 Jul 2020 16:36:13 +1000 (AEST) Received: by mail-wr1-x441.google.com with SMTP id z15so1148621wrl.8 for ; Tue, 14 Jul 2020 23:36:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=KDUw/p8DtJDnQnEVAJVG2yQivQjSwBAN+u3RJMI5C9M=; b=LSZT6nxj4ttqP+kcl0xXx7k4ieooPzTPhig26hkGekfVkTtaH2JHD7+dmxhRfBfbm9 uKPMX+hERxM6t42+4N6Xh0vvgnPAfsFn5um87k5Hky68u56FiBTANQ6c0XV9/ywqemtP CFHDRfgAs54jtev5fUuTHNM4XmDz+cyusdsqI8vFKQQipJSfmX8Cm9q8GsL8E/P6QhKi OlSqCFgn7c90mzyzrNpJBBX6xzzYbAhAWwoD8Q4p4gH4v4H0l4HxkwqNA2okUfvvEvek kJEW5+lu08HFJmq/k1o7p4bwNczt54wfoHeMEZaxoZ3WcW7Kt+Irk30DRPMp9W+2+k01 vKvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=KDUw/p8DtJDnQnEVAJVG2yQivQjSwBAN+u3RJMI5C9M=; b=W4HLcyjl5c85ir+sZKVsUfJxuLsApfzs650gjZqM+tVQaKNWWp8dyU6fE17cmjOdf+ /ZVBcbpSVR2FQwDyH42/F3dN1cMK14twxGfZdM8GyfLHOZEpyiEXtnTsF5+f49wivxxr 3cIDLGYi2WPhKq0Av5HEQoVBX6Djx55DE/6Uvs/e/+ELB6FFGkN5do+K/W/wcH1dKVb6 g3Vv4bXlB1eThRH2ply83P6MT6TF3kqiukM/g68RLDL0K3ln7bCmU6/Hjgli9s+0Pv+c n+o6fO2jVQXggyKtS358h8lPkig70k2gSmpRvO55zrxt6OgKw/VimyXGfKHNP7C/w3CT B5lw== X-Gm-Message-State: AOAM5329gtBXzeKCd1mOjAV2Rt83ZAfLOUaNPN91eC/zGZ5jGfeO8nPV t8BrLg1C9N1XWVgVEqYXx5zdmg== X-Google-Smtp-Source: ABdhPJwP41jKAMrf4wkPV4iNxv1bwG2M4VTNHS/q1DEIPWOuxYBzr/NmcFF3W0hhLv4v0tGbkjwtPQ== X-Received: by 2002:a5d:470b:: with SMTP id y11mr10046135wrq.101.1594794969893; Tue, 14 Jul 2020 23:36:09 -0700 (PDT) Received: from dell ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id k126sm2040627wmf.3.2020.07.14.23.36.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 23:36:09 -0700 (PDT) Date: Wed, 15 Jul 2020 07:36:07 +0100 From: Lee Jones To: Olof Johansson Subject: Re: [PATCH 05/13] cpufreq/arch: powerpc: pasemi: Move prototypes to shared header Message-ID: <20200715063607.GQ1398296@dell> References: <20200714145049.2496163-1-lee.jones@linaro.org> <20200714145049.2496163-6-lee.jones@linaro.org> <20200715030706.prxya7fyylscoy25@vireshk-i7> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pm@vger.kernel.org, "Rafael J. Wysocki" , Linux Kernel Mailing List , Paul Mackerras , Viresh Kumar , linuxppc-dev , Linux ARM Mailing List Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, 14 Jul 2020, Olof Johansson wrote: > On Tue, Jul 14, 2020 at 8:07 PM Viresh Kumar wrote: > > > > On 14-07-20, 15:50, Lee Jones wrote: > > > If function callers and providers do not share the same prototypes the > > > compiler complains of missing prototypes. Fix this by moving the > > > already existing prototypes out to a mutually convenient location. > > > > > > Fixes the following W=1 kernel build warning(s): > > > > > > drivers/cpufreq/pasemi-cpufreq.c:109:5: warning: no previous prototype for ‘check_astate’ [-Wmissing-prototypes] > > > 109 | int check_astate(void) > > > | ^~~~~~~~~~~~ > > > drivers/cpufreq/pasemi-cpufreq.c:114:6: warning: no previous prototype for ‘restore_astate’ [-Wmissing-prototypes] > > > 114 | void restore_astate(int cpu) > > > | ^~~~~~~~~~~~~~ > > > > > > Cc: Olof Johansson > > > Cc: Michael Ellerman > > > Cc: Benjamin Herrenschmidt > > > Cc: Paul Mackerras > > > Cc: linuxppc-dev@lists.ozlabs.org > > > Signed-off-by: Lee Jones > > > --- > > > arch/powerpc/platforms/pasemi/pasemi.h | 15 ------------ > > > > Is there no sane way we can include this file directly to the cpufreq > > file ? > > Yep. arch/powerpc seems to be in the search path for modules on powerpc, so: > > diff --git a/drivers/cpufreq/pasemi-cpufreq.c b/drivers/cpufreq/pasemi-cpufreq.c > index c66f566a854cb..815645170c4de 100644 > --- a/drivers/cpufreq/pasemi-cpufreq.c > +++ b/drivers/cpufreq/pasemi-cpufreq.c > @@ -22,6 +22,8 @@ > #include > #include > > +#include > + > #define SDCASR_REG 0x0100 > #define SDCASR_REG_STRIDE 0x1000 > #define SDCPWR_CFGA0_REG 0x0100 I searched for "include.*platforms/" in drivers/, and was scared off this method since no one else does this. But if it's a reasonable solution, great. Will fix. Thanks Olof. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog