From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58311C433E0 for ; Wed, 15 Jul 2020 07:34:56 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C4E2A206D5 for ; Wed, 15 Jul 2020 07:34:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="XLfbeliQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C4E2A206D5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4B68Kn4hv0zDql2 for ; Wed, 15 Jul 2020 17:34:53 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linaro.org (client-ip=2a00:1450:4864:20::441; helo=mail-wr1-x441.google.com; envelope-from=lee.jones@linaro.org; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=XLfbeliQ; dkim-atps=neutral Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4B68Hr5TwqzDqJK for ; Wed, 15 Jul 2020 17:33:10 +1000 (AEST) Received: by mail-wr1-x441.google.com with SMTP id s10so1253149wrw.12 for ; Wed, 15 Jul 2020 00:33:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=wmbKlH24uvS6PFbXX3LEAN6VBDJeDWBV7/Mc/Rg+Ty0=; b=XLfbeliQBIxfzuEdJ6BSJN0hTG5AH+Aps/ocThG1hmBXHOwiBv45/K/zlKEuf1FVGq pF1HSnrGly3PhOw2wqEuut+AP/2ABNiXyggcJ8kw6Jx1tqbL5UtDS2MJ48ewoqiLF/wo Y9IL+MpB5iy9hwA/cmHZP4PAzZBnCzMQcy4Qafg+NNzv2oog5elXkFBWQXXnj0kdqd7H k1/v3yGQBi0W8YHQtFhPYH5XbXxJyJzWNojpzTYGqkF/8Lkqqs5jGMd39PtNdoJx7LAb d4g3LSArT8GxnVpNKJYmmHQ/HNyaHNhbJ4wvGjujosza+LaHlG1FIksuYvHoL+9r9BMy R4JQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=wmbKlH24uvS6PFbXX3LEAN6VBDJeDWBV7/Mc/Rg+Ty0=; b=CLzLOAxdVelpTCGfPmSFgn8f16RiWYIUkblUpiLq+Lwv8k1smY4iIybM3bD70dillD SAt6UkdoMj5O8nqRfns5pKD4fBzlist3wrgGxIcpWKc6lSDVEBVBV+tZXOShSMAPLU1s HskPxkoFrVHJbo9hLu+pEHTYdXCbHq+y67TDS/EQIpxHSRI5oFFE/x5hDmu1kFmkgFDu 5/O2J5XfdpscIZdCs8mnRNVCT1A7JOPS6urJvalNI0crlXKRMW9QQ7Bb7RyxRMKHAVUz 1qVFdiWm6YlPoObv6FppLFHY0C/1m35NpXsoDUQ13MMLgZPD4YJDWwP0Iq1AorBCASPl c5oA== X-Gm-Message-State: AOAM5315Snyl9bQk+RPgq8WX84YjjvnQpqdAkt0w1KxYHH1WNrtxxVFE GFwf/JKfmMtbgn3eamNFxyUPxA== X-Google-Smtp-Source: ABdhPJx/db+3VnXHf7RP7JypvYwr4I9OcFDVh94EnRiCQpX8HDA6f6Aeq7Q8V2SEw5anyKtMc+TKsQ== X-Received: by 2002:adf:a111:: with SMTP id o17mr9606713wro.257.1594798388100; Wed, 15 Jul 2020 00:33:08 -0700 (PDT) Received: from dell ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id c194sm2143003wme.8.2020.07.15.00.33.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2020 00:33:07 -0700 (PDT) Date: Wed, 15 Jul 2020 08:33:05 +0100 From: Lee Jones To: Olof Johansson Subject: Re: [PATCH 05/13] cpufreq/arch: powerpc: pasemi: Move prototypes to shared header Message-ID: <20200715073305.GY1398296@dell> References: <20200714145049.2496163-1-lee.jones@linaro.org> <20200714145049.2496163-6-lee.jones@linaro.org> <20200715063311.GP1398296@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pm@vger.kernel.org, "Rafael J. Wysocki" , Linux Kernel Mailing List , Paul Mackerras , viresh kumar , linuxppc-dev , Linux ARM Mailing List Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, 14 Jul 2020, Olof Johansson wrote: > On Tue, Jul 14, 2020 at 11:33 PM Lee Jones wrote: > > > > On Tue, 14 Jul 2020, Olof Johansson wrote: > > > > > On Tue, Jul 14, 2020 at 7:50 AM Lee Jones wrote: > > > > > > > > If function callers and providers do not share the same prototypes the > > > > compiler complains of missing prototypes. Fix this by moving the > > > > already existing prototypes out to a mutually convenient location. > > > > > > > > Fixes the following W=1 kernel build warning(s): > > > > > > > > drivers/cpufreq/pasemi-cpufreq.c:109:5: warning: no previous prototype for ‘check_astate’ [-Wmissing-prototypes] > > > > 109 | int check_astate(void) > > > > | ^~~~~~~~~~~~ > > > > drivers/cpufreq/pasemi-cpufreq.c:114:6: warning: no previous prototype for ‘restore_astate’ [-Wmissing-prototypes] > > > > 114 | void restore_astate(int cpu) > > > > | ^~~~~~~~~~~~~~ > > > > > > > > Cc: Olof Johansson > > > > Cc: Michael Ellerman > > > > Cc: Benjamin Herrenschmidt > > > > Cc: Paul Mackerras > > > > Cc: linuxppc-dev@lists.ozlabs.org > > > > Signed-off-by: Lee Jones > > > > --- > > > > arch/powerpc/platforms/pasemi/pasemi.h | 15 ------------ > > > > arch/powerpc/platforms/pasemi/powersave.S | 2 ++ > > > > drivers/cpufreq/pasemi-cpufreq.c | 1 + > > > > include/linux/platform_data/pasemi.h | 28 +++++++++++++++++++++++ > > > > 4 files changed, 31 insertions(+), 15 deletions(-) > > > > create mode 100644 include/linux/platform_data/pasemi.h > > > > > > > > diff --git a/arch/powerpc/platforms/pasemi/pasemi.h b/arch/powerpc/platforms/pasemi/pasemi.h > > > > index 70b56048ed1be..528d81ef748ad 100644 > > > > --- a/arch/powerpc/platforms/pasemi/pasemi.h > > > > +++ b/arch/powerpc/platforms/pasemi/pasemi.h > > > > @@ -15,21 +15,6 @@ extern void __init pasemi_map_registers(void); > > > > extern void idle_spin(void); > > > > extern void idle_doze(void); > > > > > > > > -/* Restore astate to last set */ > > > > -#ifdef CONFIG_PPC_PASEMI_CPUFREQ > > > > -extern int check_astate(void); > > > > -extern void restore_astate(int cpu); > > > > -#else > > > > -static inline int check_astate(void) > > > > -{ > > > > - /* Always return >0 so we never power save */ > > > > - return 1; > > > > -} > > > > -static inline void restore_astate(int cpu) > > > > -{ > > > > -} > > > > -#endif > > > > - > > > > extern struct pci_controller_ops pasemi_pci_controller_ops; > > > > > > > > #endif /* _PASEMI_PASEMI_H */ > > > > diff --git a/arch/powerpc/platforms/pasemi/powersave.S b/arch/powerpc/platforms/pasemi/powersave.S > > > > index d0215d5329ca7..7747b48963286 100644 > > > > --- a/arch/powerpc/platforms/pasemi/powersave.S > > > > +++ b/arch/powerpc/platforms/pasemi/powersave.S > > > > @@ -5,6 +5,8 @@ > > > > * Maintained by: Olof Johansson > > > > */ > > > > > > > > +#include > > > > + > > > > #include > > > > #include > > > > #include > > > > diff --git a/drivers/cpufreq/pasemi-cpufreq.c b/drivers/cpufreq/pasemi-cpufreq.c > > > > index c66f566a854cb..c6bb3ecc90ef3 100644 > > > > --- a/drivers/cpufreq/pasemi-cpufreq.c > > > > +++ b/drivers/cpufreq/pasemi-cpufreq.c > > > > @@ -15,6 +15,7 @@ > > > > #include > > > > #include > > > > #include > > > > +#include > > > > > > > > #include > > > > #include > > > > diff --git a/include/linux/platform_data/pasemi.h b/include/linux/platform_data/pasemi.h > > > > new file mode 100644 > > > > index 0000000000000..3fed0687fcc9a > > > > --- /dev/null > > > > +++ b/include/linux/platform_data/pasemi.h > > > > @@ -0,0 +1,28 @@ > > > > +/* SPDX-License-Identifier: GPL-2.0-only */ > > > > +/* > > > > + * Copyright (C) 2020 Linaro Ltd. > > > > + * > > > > + * Author: Lee Jones > > > > + */ > > > > > > Absolutely not. It's neither your copyright, nor your authorship. > > > > The file was new. Anyway, the point is now moot. > > The contents was copied and pasted from other material, not originally > produced by you. > > I suggest you consult with Linaro lawyers on how to handle this if you > have to do something like it in the future. Very well. Thanks for the heads-up. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog