From: Balamuruhan S <bala24@linux.ibm.com>
To: linux-kernel@vger.kernel.org
Cc: pmladek@suse.com, ravi.bangoria@linux.ibm.com,
peterz@infradead.org, gpiccoli@canonical.com, rdna@fb.com,
Balamuruhan S <bala24@linux.ibm.com>,
Jisheng.Zhang@synaptics.com, viro@zeniv.linux.org.uk,
tglx@linutronix.de, linuxppc-dev@lists.ozlabs.org,
naveen.n.rao@linux.vnet.ibm.com, sandipan@linux.ibm.com
Subject: [PATCH] kernel/watchdog: fix warning -Wunused-variable for watchdog_allowed_mask in ppc64
Date: Fri, 14 Aug 2020 19:03:30 +0530 [thread overview]
Message-ID: <20200814133330.210093-1-bala24@linux.ibm.com> (raw)
In ppc64 config if `CONFIG_SOFTLOCKUP_DETECTOR` is not set then it
warns for unused declaration of `watchdog_allowed_mask` while building,
move the declaration inside ifdef later in the code.
```
kernel/watchdog.c:47:23: warning: ‘watchdog_allowed_mask’ defined but not used [-Wunused-variable]
static struct cpumask watchdog_allowed_mask __read_mostly;
```
Signed-off-by: Balamuruhan S <bala24@linux.ibm.com>
---
kernel/watchdog.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/watchdog.c b/kernel/watchdog.c
index 5abb5b22ad13..33c9b8a3d51b 100644
--- a/kernel/watchdog.c
+++ b/kernel/watchdog.c
@@ -44,7 +44,6 @@ int __read_mostly soft_watchdog_user_enabled = 1;
int __read_mostly watchdog_thresh = 10;
static int __read_mostly nmi_watchdog_available;
-static struct cpumask watchdog_allowed_mask __read_mostly;
struct cpumask watchdog_cpumask __read_mostly;
unsigned long *watchdog_cpumask_bits = cpumask_bits(&watchdog_cpumask);
@@ -166,6 +165,7 @@ int __read_mostly sysctl_softlockup_all_cpu_backtrace;
unsigned int __read_mostly softlockup_panic =
CONFIG_BOOTPARAM_SOFTLOCKUP_PANIC_VALUE;
+static struct cpumask watchdog_allowed_mask __read_mostly;
static bool softlockup_initialized __read_mostly;
static u64 __read_mostly sample_period;
base-commit: a3a28c4451dff698d0c7ef5a3e80423aa5774e2b
--
2.24.1
next reply other threads:[~2020-08-14 13:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-14 13:33 Balamuruhan S [this message]
2020-08-20 11:30 ` [PATCH] kernel/watchdog: fix warning -Wunused-variable for watchdog_allowed_mask in ppc64 Petr Mladek
-- strict thread matches above, loose matches on Subject: below --
2020-08-14 4:39 Balamuruhan S
2020-08-14 13:13 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200814133330.210093-1-bala24@linux.ibm.com \
--to=bala24@linux.ibm.com \
--cc=Jisheng.Zhang@synaptics.com \
--cc=gpiccoli@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=ravi.bangoria@linux.ibm.com \
--cc=rdna@fb.com \
--cc=sandipan@linux.ibm.com \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).