From: Allen Pais <allen.cryptic@gmail.com>
To: duncan.sands@free.fr, gregkh@linuxfoundation.org,
jacmet@sunsite.dk, balbi@kernel.org, leoyang.li@nxp.com,
johan@kernel.org
Cc: keescook@chromium.org, linux-usb@vger.kernel.org,
Allen Pais <allen.lkml@gmail.com>,
linux-kernel@vger.kernel.org,
Romain Perier <romain.perier@gmail.com>,
linuxppc-dev@lists.ozlabs.org
Subject: [PATCH 5/7] usb/gadget: fsl_qe_udc: convert tasklets to use new tasklet_setup() API
Date: Mon, 17 Aug 2020 14:32:07 +0530 [thread overview]
Message-ID: <20200817090209.26351-6-allen.cryptic@gmail.com> (raw)
In-Reply-To: <20200817090209.26351-1-allen.cryptic@gmail.com>
From: Allen Pais <allen.lkml@gmail.com>
In preparation for unconditionally passing the
struct tasklet_struct pointer to all tasklet
callbacks, switch to using the new tasklet_setup()
and from_tasklet() to pass the tasklet pointer explicitly.
Signed-off-by: Romain Perier <romain.perier@gmail.com>
Signed-off-by: Allen Pais <allen.lkml@gmail.com>
---
drivers/usb/gadget/udc/fsl_qe_udc.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/gadget/udc/fsl_qe_udc.c b/drivers/usb/gadget/udc/fsl_qe_udc.c
index 2707be628298..fa66449b3907 100644
--- a/drivers/usb/gadget/udc/fsl_qe_udc.c
+++ b/drivers/usb/gadget/udc/fsl_qe_udc.c
@@ -923,9 +923,9 @@ static int qe_ep_rxframe_handle(struct qe_ep *ep)
return 0;
}
-static void ep_rx_tasklet(unsigned long data)
+static void ep_rx_tasklet(struct tasklet_struct *t)
{
- struct qe_udc *udc = (struct qe_udc *)data;
+ struct qe_udc *udc = from_tasklet(udc, t, rx_tasklet);
struct qe_ep *ep;
struct qe_frame *pframe;
struct qe_bd __iomem *bd;
@@ -2553,8 +2553,7 @@ static int qe_udc_probe(struct platform_device *ofdev)
DMA_TO_DEVICE);
}
- tasklet_init(&udc->rx_tasklet, ep_rx_tasklet,
- (unsigned long)udc);
+ tasklet_setup(&udc->rx_tasklet, ep_rx_tasklet);
/* request irq and disable DR */
udc->usb_irq = irq_of_parse_and_map(np, 0);
if (!udc->usb_irq) {
--
2.17.1
next prev parent reply other threads:[~2020-08-17 12:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-17 9:02 [PATCH 0/7] usb: convert tasklets to use new tasklet_setup() Allen Pais
2020-08-17 9:02 ` [PATCH 1/7] usb: atm: convert tasklets to use new tasklet_setup() API Allen Pais
2020-08-17 9:02 ` [PATCH 2/7] usb: c67x00: " Allen Pais
2020-08-17 9:02 ` [PATCH 3/7] usb: hcd: " Allen Pais
2020-08-17 9:02 ` [PATCH 4/7] usb/gadget: f_midi: " Allen Pais
2020-08-17 9:02 ` Allen Pais [this message]
2020-08-17 9:02 ` [PATCH 6/7] usb: xhci: " Allen Pais
2020-08-17 9:02 ` [PATCH 7/7] usb: mos7720: " Allen Pais
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200817090209.26351-6-allen.cryptic@gmail.com \
--to=allen.cryptic@gmail.com \
--cc=allen.lkml@gmail.com \
--cc=balbi@kernel.org \
--cc=duncan.sands@free.fr \
--cc=gregkh@linuxfoundation.org \
--cc=jacmet@sunsite.dk \
--cc=johan@kernel.org \
--cc=keescook@chromium.org \
--cc=leoyang.li@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=romain.perier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).