From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37862C433E1 for ; Fri, 21 Aug 2020 05:47:20 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DA0D2204EA for ; Fri, 21 Aug 2020 05:47:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="i4twJXEI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DA0D2204EA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4BXrBY5mByzDq9y for ; Fri, 21 Aug 2020 15:47:17 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=casper.srs.infradead.org (client-ip=2001:8b0:10b:1236::1; helo=casper.infradead.org; envelope-from=batv+a718def99972ac67df6e+6207+infradead.org+hch@casper.srs.infradead.org; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=casper.20170209 header.b=i4twJXEI; dkim-atps=neutral Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4BXr8S2RwNzDqwF for ; Fri, 21 Aug 2020 15:45:26 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=WaEdaKZ9Jv/QnxXxEOWWfi60iYosVWWRHu3++tbASqo=; b=i4twJXEIVwSlfld6iIvFef/uqg y9UKKflerwqRH5AmnCIyXg1N5elyS3i9zqg92AqxKo7cQJ4rSCU5dRoPrjlIWCwBmq6f84ynWcMbk UzwC6VuCzjDB+Q3tRfcTy4PzDPuLJ+ncoi8YrLKkHX611e76E9Pv4Tm8nqYtiJYy/3UBhp3Yol2p/ 1FPvgIBlCfb0Whxsa7T31/HHg5WCBgPIOROEw8U5+0WAiDtMY6SC00sAPaxNJInpDmy4leg8QYuX/ 5O+ifcPc4kaSC4dnZo+YJT7hIDRh6wUC8dnrDYNW/gmnTlFUoDYAaf8Ycj9ebe/prEpWrTLD8zycE 7CFDF7hg==; Received: from hch by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1k8zrQ-0007Um-WD; Fri, 21 Aug 2020 05:45:09 +0000 Date: Fri, 21 Aug 2020 06:45:08 +0100 From: Christoph Hellwig To: Nicholas Piggin Subject: Re: [PATCH v5 3/8] mm/vmalloc: rename vmap_*_range vmap_pages_*_range Message-ID: <20200821054508.GA28291@infradead.org> References: <20200821044427.736424-1-npiggin@gmail.com> <20200821044427.736424-4-npiggin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200821044427.736424-4-npiggin@gmail.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Zefan Li , Jonathan Cameron , Andrew Morton , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, Aug 21, 2020 at 02:44:22PM +1000, Nicholas Piggin wrote: > The vmalloc mapper operates on a struct page * array rather than a > linear physical address, re-name it to make this distinction clear. > > Signed-off-by: Nicholas Piggin > --- > mm/vmalloc.c | 28 ++++++++++++---------------- > 1 file changed, 12 insertions(+), 16 deletions(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 49f225b0f855..3a1e45fd1626 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -190,9 +190,8 @@ void unmap_kernel_range_noflush(unsigned long start, unsigned long size) > arch_sync_kernel_mappings(start, end); > } > > -static int vmap_pte_range(pmd_t *pmd, unsigned long addr, > - unsigned long end, pgprot_t prot, struct page **pages, int *nr, > - pgtbl_mod_mask *mask) > +static int vmap_pages_pte_range(pmd_t *pmd, unsigned long addr, unsigned long end, > + pgprot_t prot, struct page **pages, int *nr, pgtbl_mod_mask *mask) Please don't add > 80 lines without any good reason.