From: Segher Boessenkool <segher@kernel.crashing.org>
To: Guohua Zhong <zhongguohua1@huawei.com>
Cc: wangle6@huawei.com, gregkh@linuxfoundation.org,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, paulus@samba.org, nixiaoming@huawei.com
Subject: Re: Re：Re: [PATCH] powerpc: Fix a bug in __div64_32 if divisor is zero
Date: Sat, 22 Aug 2020 19:11:01 -0500 [thread overview]
Message-ID: <20200823001101.GO28786@gate.crashing.org> (raw)
In-Reply-To: <20200822165433.58228-1-zhongguohua1@huawei.com>
On Sun, Aug 23, 2020 at 12:54:33AM +0800, Guohua Zhong wrote:
> Yet, I have noticed that there is no checking of 'base' in these functions.
> But I am not sure how to check is better.As we know that the result is
> undefined when divisor is zero. It maybe good to print error and dump stack.
> Let the process to know that the divisor is zero by sending SIGFPE.
That is now what the PowerPC integer divide insns do: they just leave
the result undefined (and they can set the overflow flag then, but no
one uses that).
Segher
next prev parent reply other threads:[~2020-08-23 0:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-20 13:10 [PATCH] powerpc: Fix a bug in __div64_32 if divisor is zero Guohua Zhong
2020-08-20 17:02 ` Christophe Leroy
2020-08-22 16:29 ` Guohua Zhong
2020-08-20 18:23 ` Christophe Leroy
2020-08-22 16:54 ` Re：Re: " Guohua Zhong
2020-08-22 17:25 ` Gabriel Paubert
2020-08-24 13:25 ` Guohua Zhong
2020-08-24 15:05 ` David Laight
2020-08-23 0:11 ` Segher Boessenkool [this message]
2020-08-24 11:54 ` Guohua Zhong
2020-08-24 18:17 ` Segher Boessenkool
2020-08-22 16:06 ` Guohua Zhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200823001101.GO28786@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nixiaoming@huawei.com \
--cc=paulus@samba.org \
--cc=stable@vger.kernel.org \
--cc=wangle6@huawei.com \
--cc=zhongguohua1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).