From: David Miller <davem@davemloft.net>
To: drt@linux.ibm.com
Cc: netdev@vger.kernel.org, mmc@linux.vnet.ibm.com,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH net v2] ibmvnic fix NULL tx_pools and rx_tools issue at do_reset
Date: Tue, 25 Aug 2020 10:08:05 -0700 (PDT) [thread overview]
Message-ID: <20200825.100805.388932748785591114.davem@davemloft.net> (raw)
In-Reply-To: <20200825165606.806674-1-drt@linux.ibm.com>
From: Dany Madden <drt@linux.ibm.com>
Date: Tue, 25 Aug 2020 12:56:06 -0400
> @@ -2011,7 +2017,10 @@ static int do_reset(struct ibmvnic_adapter *adapter,
> adapter->req_rx_add_entries_per_subcrq !=
> old_num_rx_slots ||
> adapter->req_tx_entries_per_subcrq !=
> - old_num_tx_slots) {
> + old_num_tx_slots ||
> + !adapter->rx_pool ||
> + !adapter->tso_pool ||
> + !adapter->tx_pool) {
Please don't over indent these new lines, indent them identically as the
lines above where you are adding new conditions.
Thank you.
prev parent reply other threads:[~2020-08-25 17:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 16:56 [PATCH net v2] ibmvnic fix NULL tx_pools and rx_tools issue at do_reset Dany Madden
2020-08-25 17:08 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200825.100805.388932748785591114.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=drt@linux.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mmc@linux.vnet.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox