From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: David Hildenbrand <david@redhat.com>
Cc: linux-hyperv@vger.kernel.org, Michal Hocko <mhocko@suse.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
Pingfan Liu <kernelfans@gmail.com>,
virtualization@lists.linux-foundation.org, linux-mm@kvack.org,
Paul Mackerras <paulus@samba.org>,
"K. Y. Srinivasan" <kys@microsoft.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
linux-s390@vger.kernel.org, Wei Liu <wei.liu@kernel.org>,
Stefano Stabellini <sstabellini@kernel.org>,
Dave Jiang <dave.jiang@intel.com>, Baoquan He <bhe@redhat.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
linux-acpi@vger.kernel.org, xen-devel@lists.xenproject.org,
Heiko Carstens <hca@linux.ibm.com>, Len Brown <lenb@kernel.org>,
Nathan Lynch <nathanl@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Leonardo Bras <leobras.c@gmail.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
Dan Williams <dan.j.williams@intel.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Juergen Gross <jgross@suse.com>,
Pankaj Gupta <pankaj.gupta.linux@gmail.com>,
Libor Pechacek <lpechacek@suse.cz>,
linux-nvdimm@lists.01.org,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-kernel@vger.kernel.org,
Wei Yang <richardw.yang@linux.intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Oliver O'Halloran <oohall@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2 3/7] mm/memory_hotplug: prepare passing flags to add_memory() and friends
Date: Wed, 9 Sep 2020 09:17:59 +0200 [thread overview]
Message-ID: <20200909071759.GD435421@kroah.com> (raw)
In-Reply-To: <20200908201012.44168-4-david@redhat.com>
On Tue, Sep 08, 2020 at 10:10:08PM +0200, David Hildenbrand wrote:
> We soon want to pass flags, e.g., to mark added System RAM resources.
> mergeable. Prepare for that.
What are these random "flags", and how do we know what should be passed
to them?
Why not make this an enumerated type so that we know it all works
properly, like the GPF_* flags are? Passing around a random unsigned
long feels very odd/broken...
thanks,
greg k-h
next prev parent reply other threads:[~2020-09-09 7:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200908201012.44168-1-david@redhat.com>
2020-09-08 20:10 ` [PATCH v2 3/7] mm/memory_hotplug: prepare passing flags to add_memory() and friends David Hildenbrand
2020-09-09 5:18 ` Jürgen Groß
2020-09-09 7:17 ` Greg Kroah-Hartman [this message]
2020-09-09 7:28 ` David Hildenbrand
2020-09-09 11:24 ` Michael Ellerman
2020-09-09 11:37 ` David Hildenbrand
2020-09-09 11:51 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200909071759.GD435421@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=boris.ostrovsky@oracle.com \
--cc=borntraeger@de.ibm.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=david@redhat.com \
--cc=gor@linux.ibm.com \
--cc=haiyangz@microsoft.com \
--cc=hca@linux.ibm.com \
--cc=jasowang@redhat.com \
--cc=jgg@ziepe.ca \
--cc=jgross@suse.com \
--cc=kernelfans@gmail.com \
--cc=kys@microsoft.com \
--cc=lenb@kernel.org \
--cc=leobras.c@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-s390@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lpechacek@suse.cz \
--cc=mhocko@suse.com \
--cc=mst@redhat.com \
--cc=nathanl@linux.ibm.com \
--cc=oohall@gmail.com \
--cc=pankaj.gupta.linux@gmail.com \
--cc=paulus@samba.org \
--cc=richardw.yang@linux.intel.com \
--cc=rjw@rjwysocki.net \
--cc=sstabellini@kernel.org \
--cc=sthemmin@microsoft.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=vishal.l.verma@intel.com \
--cc=wei.liu@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).