From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D72D5C43461 for ; Tue, 15 Sep 2020 19:45:34 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 19ADD206C9 for ; Tue, 15 Sep 2020 19:45:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 19ADD206C9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=davemloft.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4BrYcB6rQmzDqSQ for ; Wed, 16 Sep 2020 05:45:30 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=davemloft.net (client-ip=2620:137:e000::1:9; helo=shards.monkeyblade.net; envelope-from=davem@davemloft.net; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=davemloft.net Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4BrYYW19WmzDqSt for ; Wed, 16 Sep 2020 05:43:07 +1000 (AEST) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 9299113678364; Tue, 15 Sep 2020 12:26:08 -0700 (PDT) Date: Tue, 15 Sep 2020 12:42:54 -0700 (PDT) Message-Id: <20200915.124254.1657521903825160294.davem@davemloft.net> To: npiggin@gmail.com Subject: Re: [PATCH v2 3/4] sparc64: remove mm_cpumask clearing to fix kthread_use_mm race From: David Miller In-Reply-To: <1600139445.qwycwjuwdq.astroid@bobo.none> References: <20200914045219.3736466-4-npiggin@gmail.com> <20200914.125942.5644261129883859.davem@davemloft.net> <1600139445.qwycwjuwdq.astroid@bobo.none> X-Mailer: Mew version 6.8 on Emacs 27.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [2620:137:e000::1:9]); Tue, 15 Sep 2020 12:26:09 -0700 (PDT) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: axboe@kernel.dk, linux-arch@vger.kernel.org, peterz@infradead.org, aneesh.kumar@linux.ibm.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, sparclinux@vger.kernel.org, akpm@linux-foundation.org, linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" From: Nicholas Piggin Date: Tue, 15 Sep 2020 13:24:07 +1000 > Excerpts from David Miller's message of September 15, 2020 5:59 am: >> From: Nicholas Piggin >> Date: Mon, 14 Sep 2020 14:52:18 +1000 >> >> ... >>> The basic fix for sparc64 is to remove its mm_cpumask clearing code. The >>> optimisation could be effectively restored by sending IPIs to mm_cpumask >>> members and having them remove themselves from mm_cpumask. This is more >>> tricky so I leave it as an exercise for someone with a sparc64 SMP. >>> powerpc has a (currently similarly broken) example. >>> >>> Signed-off-by: Nicholas Piggin >> >> Sad to see this optimization go away, but what can I do: >> >> Acked-by: David S. Miller >> > > Thanks Dave, any objection if we merge this via the powerpc tree > to keep the commits together? No objection.