From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD9A3C43461 for ; Thu, 17 Sep 2020 17:00:29 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A158C2064B for ; Thu, 17 Sep 2020 17:00:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="MJLfb4lm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A158C2064B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4Bsjrn5cyJzDqfD for ; Fri, 18 Sep 2020 03:00:25 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=198.145.29.99; helo=mail.kernel.org; envelope-from=helgaas@kernel.org; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=default header.b=MJLfb4lm; dkim-atps=neutral Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4BsjnM4FjSzDqd9 for ; Fri, 18 Sep 2020 02:57:27 +1000 (AEST) Received: from localhost (52.sub-72-107-123.myvzw.com [72.107.123.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 818A72064B; Thu, 17 Sep 2020 16:57:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600361844; bh=nu7RsY28LVyN+IsFpaXaxIpemXjC7Q2RYaAJUnnZ2r8=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=MJLfb4lmVitwKrAl4tGM9ILl8JGYXcXszpcpnzFEb6k8oJ5ax0iNsfFS8e9FxKUZ0 C+tYyN/wTuiXpcH172VU1aywBGTfhiTyQoi/GkH/kglPqRuVr8iRxX5dmmGUpJsFdS AJ9Faia/pQLEdUCrc/vdPrdf69lvmoVPAZPBsylY= Date: Thu, 17 Sep 2020 11:57:23 -0500 From: Bjorn Helgaas To: Qinglang Miao Subject: Re: [PATCH -next] PCI: rpadlpar: use for_each_child_of_node() and for_each_node_by_name Message-ID: <20200917165723.GA1708462@bjorn-Precision-5520> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200916062128.190819-1-miaoqinglang@huawei.com> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tyrel Datwyler , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Paul Mackerras , Bjorn Helgaas , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Wed, Sep 16, 2020 at 02:21:28PM +0800, Qinglang Miao wrote: > Use for_each_child_of_node() and for_each_node_by_name macro > instead of open coding it. > > Signed-off-by: Qinglang Miao Applied to pci/hotplug for v5.10, thanks! > --- > drivers/pci/hotplug/rpadlpar_core.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/pci/hotplug/rpadlpar_core.c b/drivers/pci/hotplug/rpadlpar_core.c > index f979b7098..0a3c80ba6 100644 > --- a/drivers/pci/hotplug/rpadlpar_core.c > +++ b/drivers/pci/hotplug/rpadlpar_core.c > @@ -40,13 +40,13 @@ static DEFINE_MUTEX(rpadlpar_mutex); > static struct device_node *find_vio_slot_node(char *drc_name) > { > struct device_node *parent = of_find_node_by_name(NULL, "vdevice"); > - struct device_node *dn = NULL; > + struct device_node *dn; > int rc; > > if (!parent) > return NULL; > > - while ((dn = of_get_next_child(parent, dn))) { > + for_each_child_of_node(parent, dn) { > rc = rpaphp_check_drc_props(dn, drc_name, NULL); > if (rc == 0) > break; > @@ -60,10 +60,10 @@ static struct device_node *find_vio_slot_node(char *drc_name) > static struct device_node *find_php_slot_pci_node(char *drc_name, > char *drc_type) > { > - struct device_node *np = NULL; > + struct device_node *np; > int rc; > > - while ((np = of_find_node_by_name(np, "pci"))) { > + for_each_node_by_name(np, "pci") { > rc = rpaphp_check_drc_props(np, drc_name, drc_type); > if (rc == 0) > break; > -- > 2.23.0 >