* [PATCH -next] tty: hvc: fix link error with CONFIG_SERIAL_CORE_CONSOLE=n
@ 2020-09-18 9:20 Yang Yingliang
2020-09-18 11:17 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Yang Yingliang @ 2020-09-18 9:20 UTC (permalink / raw)
To: linuxppc-dev, linux-kernel; +Cc: gregkh
Fix the link error by selecting SERIAL_CORE_CONSOLE.
aarch64-linux-gnu-ld: drivers/tty/hvc/hvc_dcc.o: in function `dcc_early_write':
hvc_dcc.c:(.text+0x164): undefined reference to `uart_console_write'
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/tty/hvc/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/tty/hvc/Kconfig b/drivers/tty/hvc/Kconfig
index d1b27b0522a3..8d60e0ff67b4 100644
--- a/drivers/tty/hvc/Kconfig
+++ b/drivers/tty/hvc/Kconfig
@@ -81,6 +81,7 @@ config HVC_DCC
bool "ARM JTAG DCC console"
depends on ARM || ARM64
select HVC_DRIVER
+ select SERIAL_CORE_CONSOLE
help
This console uses the JTAG DCC on ARM to create a console under the HVC
driver. This console is used through a JTAG only on ARM. If you don't have
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH -next] tty: hvc: fix link error with CONFIG_SERIAL_CORE_CONSOLE=n
2020-09-18 9:20 [PATCH -next] tty: hvc: fix link error with CONFIG_SERIAL_CORE_CONSOLE=n Yang Yingliang
@ 2020-09-18 11:17 ` Greg KH
2020-09-19 2:48 ` Yang Yingliang
0 siblings, 1 reply; 4+ messages in thread
From: Greg KH @ 2020-09-18 11:17 UTC (permalink / raw)
To: Yang Yingliang; +Cc: linuxppc-dev, linux-kernel
On Fri, Sep 18, 2020 at 05:20:30PM +0800, Yang Yingliang wrote:
> Fix the link error by selecting SERIAL_CORE_CONSOLE.
>
> aarch64-linux-gnu-ld: drivers/tty/hvc/hvc_dcc.o: in function `dcc_early_write':
> hvc_dcc.c:(.text+0x164): undefined reference to `uart_console_write'
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> drivers/tty/hvc/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/tty/hvc/Kconfig b/drivers/tty/hvc/Kconfig
> index d1b27b0522a3..8d60e0ff67b4 100644
> --- a/drivers/tty/hvc/Kconfig
> +++ b/drivers/tty/hvc/Kconfig
> @@ -81,6 +81,7 @@ config HVC_DCC
> bool "ARM JTAG DCC console"
> depends on ARM || ARM64
> select HVC_DRIVER
> + select SERIAL_CORE_CONSOLE
> help
> This console uses the JTAG DCC on ARM to create a console under the HVC
> driver. This console is used through a JTAG only on ARM. If you don't have
> --
> 2.25.1
>
Same question here, what caused this problem to happen?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] tty: hvc: fix link error with CONFIG_SERIAL_CORE_CONSOLE=n
2020-09-18 11:17 ` Greg KH
@ 2020-09-19 2:48 ` Yang Yingliang
2020-09-19 5:40 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Yang Yingliang @ 2020-09-19 2:48 UTC (permalink / raw)
To: Greg KH; +Cc: linuxppc-dev, linux-kernel
On 2020/9/18 19:17, Greg KH wrote:
> On Fri, Sep 18, 2020 at 05:20:30PM +0800, Yang Yingliang wrote:
>> Fix the link error by selecting SERIAL_CORE_CONSOLE.
>>
>> aarch64-linux-gnu-ld: drivers/tty/hvc/hvc_dcc.o: in function `dcc_early_write':
>> hvc_dcc.c:(.text+0x164): undefined reference to `uart_console_write'
>>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
>> ---
>> drivers/tty/hvc/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/tty/hvc/Kconfig b/drivers/tty/hvc/Kconfig
>> index d1b27b0522a3..8d60e0ff67b4 100644
>> --- a/drivers/tty/hvc/Kconfig
>> +++ b/drivers/tty/hvc/Kconfig
>> @@ -81,6 +81,7 @@ config HVC_DCC
>> bool "ARM JTAG DCC console"
>> depends on ARM || ARM64
>> select HVC_DRIVER
>> + select SERIAL_CORE_CONSOLE
>> help
>> This console uses the JTAG DCC on ARM to create a console under the HVC
>> driver. This console is used through a JTAG only on ARM. If you don't have
>> --
>> 2.25.1
>>
> Same question here, what caused this problem to happen?
Fixes: d1a1af2cdf19 ("hvc: dcc: Add earlycon support")
>
> thanks,
>
> greg k-h
> .
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] tty: hvc: fix link error with CONFIG_SERIAL_CORE_CONSOLE=n
2020-09-19 2:48 ` Yang Yingliang
@ 2020-09-19 5:40 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2020-09-19 5:40 UTC (permalink / raw)
To: Yang Yingliang; +Cc: linuxppc-dev, linux-kernel
On Sat, Sep 19, 2020 at 10:48:41AM +0800, Yang Yingliang wrote:
>
> On 2020/9/18 19:17, Greg KH wrote:
> > On Fri, Sep 18, 2020 at 05:20:30PM +0800, Yang Yingliang wrote:
> > > Fix the link error by selecting SERIAL_CORE_CONSOLE.
> > >
> > > aarch64-linux-gnu-ld: drivers/tty/hvc/hvc_dcc.o: in function `dcc_early_write':
> > > hvc_dcc.c:(.text+0x164): undefined reference to `uart_console_write'
> > >
> > > Reported-by: Hulk Robot <hulkci@huawei.com>
> > > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> > > ---
> > > drivers/tty/hvc/Kconfig | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/tty/hvc/Kconfig b/drivers/tty/hvc/Kconfig
> > > index d1b27b0522a3..8d60e0ff67b4 100644
> > > --- a/drivers/tty/hvc/Kconfig
> > > +++ b/drivers/tty/hvc/Kconfig
> > > @@ -81,6 +81,7 @@ config HVC_DCC
> > > bool "ARM JTAG DCC console"
> > > depends on ARM || ARM64
> > > select HVC_DRIVER
> > > + select SERIAL_CORE_CONSOLE
> > > help
> > > This console uses the JTAG DCC on ARM to create a console under the HVC
> > > driver. This console is used through a JTAG only on ARM. If you don't have
> > > --
> > > 2.25.1
> > >
> > Same question here, what caused this problem to happen?
> Fixes: d1a1af2cdf19 ("hvc: dcc: Add earlycon support")
Great, can you resend with that added please?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-09-19 5:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-18 9:20 [PATCH -next] tty: hvc: fix link error with CONFIG_SERIAL_CORE_CONSOLE=n Yang Yingliang
2020-09-18 11:17 ` Greg KH
2020-09-19 2:48 ` Yang Yingliang
2020-09-19 5:40 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).