From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1362C4727E for ; Wed, 23 Sep 2020 00:17:04 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B9E2A2085B for ; Wed, 23 Sep 2020 00:17:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=ozlabs.org header.i=@ozlabs.org header.b="sdKZOkYR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B9E2A2085B Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=ozlabs.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4BwzJF24vgzDqZl for ; Wed, 23 Sep 2020 10:17:01 +1000 (AEST) Received: from ozlabs.org (bilbo.ozlabs.org [203.11.71.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Bwz9m50wFzDqMW for ; Wed, 23 Sep 2020 10:11:24 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=ozlabs.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=ozlabs.org header.i=@ozlabs.org header.a=rsa-sha256 header.s=201707 header.b=sdKZOkYR; dkim-atps=neutral Received: by ozlabs.org (Postfix, from userid 1003) id 4Bwz9m14d4z9sR4; Wed, 23 Sep 2020 10:11:24 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ozlabs.org; s=201707; t=1600819884; bh=rWARqAru4qieupMXGoqJaSPE7lRV5D0L38P/lAtaAP4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sdKZOkYR0rZjeYjTGtnRQkazm9LarORFj4x50iwaAAOgDzLJD5BKYEWLA39m1OZ0w oHa7nB23TauTLnVUt81dZx23jD0iY2yd/xpS5tdq1iqKOBzRWUQQew2fYgJ+gBPEWv tdiHt9xf8NNDiVmTiHpDsDfau7AoZjoMa0IJaN/IC1zAcjr03OxGEX/C8nWPiFT161 ZofrSkpvDJHW8WjN6vcSJsh9jweOb2A7tH8egKoypwRHIjpFTkRa6sR/C980F2BFQd SPshSZSXDg41Skk7+7uZ5lDBe28hkKw91CBdmf6oTJQf+fMbpqnA/7zFYlHmrAQX7e EzidUx+Ahui8Q== Date: Wed, 23 Sep 2020 10:09:47 +1000 From: Paul Mackerras To: Fabiano Rosas Subject: Re: [PATCH] KVM: PPC: Book3S HV: Do not allocate HPT for a nested guest Message-ID: <20200923000947.GE531519@thinks.paulus.ozlabs.org> References: <20200911041607.198092-1-farosas@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200911041607.198092-1-farosas@linux.ibm.com> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, david@gibson.dropbear.id.au Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, Sep 11, 2020 at 01:16:07AM -0300, Fabiano Rosas wrote: > The current nested KVM code does not support HPT guests. This is > informed/enforced in some ways: > > - Hosts < P9 will not be able to enable the nested HV feature; > > - The nested hypervisor MMU capabilities will not contain > KVM_CAP_PPC_MMU_HASH_V3; > > - QEMU reflects the MMU capabilities in the > 'ibm,arch-vec-5-platform-support' device-tree property; > > - The nested guest, at 'prom_parse_mmu_model' ignores the > 'disable_radix' kernel command line option if HPT is not supported; > > - The KVM_PPC_CONFIGURE_V3_MMU ioctl will fail if trying to use HPT. > > There is, however, still a way to start a HPT guest by using > max-compat-cpu=power8 at the QEMU machine options. This leads to the > guest being set to use hash after QEMU calls the KVM_PPC_ALLOCATE_HTAB > ioctl. > > With the guest set to hash, the nested hypervisor goes through the > entry path that has no knowledge of nesting (kvmppc_run_vcpu) and > crashes when it tries to execute an hypervisor-privileged (mtspr > HDEC) instruction at __kvmppc_vcore_entry: > > root@L1:~ $ qemu-system-ppc64 -machine pseries,max-cpu-compat=power8 ... > > > [ 538.543303] CPU: 83 PID: 25185 Comm: CPU 0/KVM Not tainted 5.9.0-rc4 #1 > [ 538.543355] NIP: c00800000753f388 LR: c00800000753f368 CTR: c0000000001e5ec0 > [ 538.543417] REGS: c0000013e91e33b0 TRAP: 0700 Not tainted (5.9.0-rc4) > [ 538.543470] MSR: 8000000002843033 CR: 22422882 XER: 20040000 > [ 538.543546] CFAR: c00800000753f4b0 IRQMASK: 3 > GPR00: c0080000075397a0 c0000013e91e3640 c00800000755e600 0000000080000000 > GPR04: 0000000000000000 c0000013eab19800 c000001394de0000 00000043a054db72 > GPR08: 00000000003b1652 0000000000000000 0000000000000000 c0080000075502e0 > GPR12: c0000000001e5ec0 c0000007ffa74200 c0000013eab19800 0000000000000008 > GPR16: 0000000000000000 c00000139676c6c0 c000000001d23948 c0000013e91e38b8 > GPR20: 0000000000000053 0000000000000000 0000000000000001 0000000000000000 > GPR24: 0000000000000001 0000000000000001 0000000000000000 0000000000000001 > GPR28: 0000000000000001 0000000000000053 c0000013eab19800 0000000000000001 > [ 538.544067] NIP [c00800000753f388] __kvmppc_vcore_entry+0x90/0x104 [kvm_hv] > [ 538.544121] LR [c00800000753f368] __kvmppc_vcore_entry+0x70/0x104 [kvm_hv] > [ 538.544173] Call Trace: > [ 538.544196] [c0000013e91e3640] [c0000013e91e3680] 0xc0000013e91e3680 (unreliable) > [ 538.544260] [c0000013e91e3820] [c0080000075397a0] kvmppc_run_core+0xbc8/0x19d0 [kvm_hv] > [ 538.544325] [c0000013e91e39e0] [c00800000753d99c] kvmppc_vcpu_run_hv+0x404/0xc00 [kvm_hv] > [ 538.544394] [c0000013e91e3ad0] [c0080000072da4fc] kvmppc_vcpu_run+0x34/0x48 [kvm] > [ 538.544472] [c0000013e91e3af0] [c0080000072d61b8] kvm_arch_vcpu_ioctl_run+0x310/0x420 [kvm] > [ 538.544539] [c0000013e91e3b80] [c0080000072c7450] kvm_vcpu_ioctl+0x298/0x778 [kvm] > [ 538.544605] [c0000013e91e3ce0] [c0000000004b8c2c] sys_ioctl+0x1dc/0xc90 > [ 538.544662] [c0000013e91e3dc0] [c00000000002f9a4] system_call_exception+0xe4/0x1c0 > [ 538.544726] [c0000013e91e3e20] [c00000000000d140] system_call_common+0xf0/0x27c > [ 538.544787] Instruction dump: > [ 538.544821] f86d1098 60000000 60000000 48000099 e8ad0fe8 e8c500a0 e9264140 75290002 > [ 538.544886] 7d1602a6 7cec42a6 40820008 7d0807b4 <7d164ba6> 7d083a14 f90d10a0 480104fd > [ 538.544953] ---[ end trace 74423e2b948c2e0c ]--- > > This patch makes the KVM_PPC_ALLOCATE_HTAB ioctl fail when running in > the nested hypervisor, causing QEMU to abort. > > Reported-by: Satheesh Rajendran > Signed-off-by: Fabiano Rosas Thanks, applied. Paul.