From: Andrew Lunn <andrew@lunn.ch>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"Madalin Bucur \(OSS\)" <madalin.bucur@oss.nxp.com>,
Radu-andrei Bulie <radu-andrei.bulie@nxp.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"fido_max@inbox.ru" <fido_max@inbox.ru>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"paulus@samba.org" <paulus@samba.org>,
Vladimir Oltean <olteanv@gmail.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH v2 devicetree 2/2] powerpc: dts: t1040rdb: add ports for Seville Ethernet switch
Date: Tue, 29 Sep 2020 22:10:48 +0200 [thread overview]
Message-ID: <20200929201048.GG3996795@lunn.ch> (raw)
In-Reply-To: <20200929193953.rgibttgt6lh5huef@skbuf>
On Tue, Sep 29, 2020 at 07:39:54PM +0000, Vladimir Oltean wrote:
> On Tue, Sep 29, 2020 at 09:11:53PM +0200, Andrew Lunn wrote:
> > > +&seville_port0 {
> > > + managed = "in-band-status";
> > > + phy-handle = <&phy_qsgmii_0>;
> > > + phy-mode = "qsgmii";
> > > + /* ETH4 written on chassis */
> > > + label = "swp4";
> >
> > If ETH4 is on the chassis why not use ETH4?
>
> You mean all-caps, just like that?
Yes.
DSA is often used in WiFI access point, etc. The user is not a
computer professional. If the WebGUI says ETH4, and the label on the
front says ETH4, they probably think the two are the same, and are
happy.
I have one box which does not have an labels on the front panels, but
the industrial sockets for Ethernet are colour coded. So the interface
names are red, blue, green, to match the socket colour, and the cable
set is also colour coded the same.
So long as it is unique, the kernel does not care. So make it easy for
the user.
Andrew
next prev parent reply other threads:[~2020-09-29 20:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-29 11:32 [PATCH v2 devicetree 0/2] Add Seville Ethernet switch to T1040RDB Vladimir Oltean
2020-09-29 11:32 ` [PATCH v2 devicetree 1/2] powerpc: dts: t1040: add bindings for Seville Ethernet switch Vladimir Oltean
2020-09-29 13:12 ` Maxim Kochetkov
2020-09-29 11:32 ` [PATCH v2 devicetree 2/2] powerpc: dts: t1040rdb: add ports " Vladimir Oltean
2020-09-29 13:12 ` Maxim Kochetkov
2020-09-29 19:11 ` Andrew Lunn
2020-09-29 19:39 ` Vladimir Oltean
2020-09-29 20:10 ` Andrew Lunn [this message]
2020-09-29 20:33 ` Vladimir Oltean
2020-09-29 13:11 ` [PATCH v2 devicetree 0/2] Add Seville Ethernet switch to T1040RDB Maxim Kochetkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200929201048.GG3996795@lunn.ch \
--to=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=fido_max@inbox.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=madalin.bucur@oss.nxp.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=paulus@samba.org \
--cc=radu-andrei.bulie@nxp.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).