From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01A19C433DF for ; Wed, 14 Oct 2020 21:20:03 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4CFD9221FF for ; Wed, 14 Oct 2020 21:20:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4CFD9221FF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baikalelectronics.ru Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4CBQKr0dDzzDr43 for ; Thu, 15 Oct 2020 08:20:00 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=baikalelectronics.ru (client-ip=94.125.187.42; helo=mail.baikalelectronics.ru; envelope-from=sergey.semin@baikalelectronics.ru; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=baikalelectronics.ru Received: from mail.baikalelectronics.ru (ns2.baikalelectronics.ru [94.125.187.42]) by lists.ozlabs.org (Postfix) with ESMTP id 4CBFPN3kWpzDqnV for ; Thu, 15 Oct 2020 01:37:28 +1100 (AEDT) Received: from localhost (unknown [127.0.0.1]) by mail.baikalelectronics.ru (Postfix) with ESMTP id 0C2A5803073E; Wed, 14 Oct 2020 14:37:25 +0000 (UTC) X-Virus-Scanned: amavisd-new at baikalelectronics.ru Received: from mail.baikalelectronics.ru ([127.0.0.1]) by localhost (mail.baikalelectronics.ru [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id f5w4yWjMzAZv; Wed, 14 Oct 2020 17:37:23 +0300 (MSK) Date: Wed, 14 Oct 2020 17:37:20 +0300 From: Serge Semin To: Felipe Balbi Subject: Re: [PATCH 20/20] arch: dts: Fix DWC USB3 DT nodes name Message-ID: <20201014143720.yny3jco5pkb7dr4b@mobilestation> References: <20201014101402.18271-1-Sergey.Semin@baikalelectronics.ru> <20201014101402.18271-21-Sergey.Semin@baikalelectronics.ru> <878sc8lx0e.fsf@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <878sc8lx0e.fsf@kernel.org> X-ClientProxiedBy: MAIL.baikal.int (192.168.51.25) To mail (192.168.51.25) X-Mailman-Approved-At: Thu, 15 Oct 2020 07:49:49 +1100 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , linux-usb@vger.kernel.org, Neil Armstrong , Tony Lindgren , Bjorn Andersson , Wei Xu , linux-samsung-soc@vger.kernel.org, Kevin Hilman , Gregory Clement , Krzysztof Kozlowski , Chen-Yu Tsai , Kukjin Kim , Andy Gross , linux-arm-msm@vger.kernel.org, linux-snps-arc@lists.infradead.org, Sebastian Hesselbarth , devicetree@vger.kernel.org, Jason Cooper , Mathias Nyman , linux-kernel@vger.kernel.org, Lad Prabhakar , Maxime Ripard , Alexey Malahov , Rob Herring , Santosh Shilimkar , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Roger Quadros , linux-mips@vger.kernel.org, Greg Kroah-Hartman , Yoshihiro Shimoda , linuxppc-dev@lists.ozlabs.org, Patrice Chotard , Serge Semin , Li Yang , Manu Gautam , =?utf-8?Q?Beno=C3=AEt?= Cousson , Shawn Guo , Pavel Parkhomenko Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Wed, Oct 14, 2020 at 05:09:37PM +0300, Felipe Balbi wrote: > > Hi Serge, > > Serge Semin writes: > > In accordance with the DWC USB3 bindings the corresponding node name is > > suppose to comply with Generic USB HCD DT schema, which requires the USB > > DWC3 is not a simple HDC, though. Yeah, strictly speaking it is equipped with a lot of vendor-specific stuff, which are tuned by the DWC USB3 driver in the kernel. But after that the controller is registered as xhci-hcd device so it's serviced by the xHCI driver, which then registers the HCD device so the corresponding DT node is supposed to be compatible with the next bindings: usb/usb-hcd.yaml, usb/usb-xhci.yaml and usb/snps,dwc3,yaml. I've created the later one so to validate the denoted compatibility. > > > nodes to have the name acceptable by the regexp: "^usb(@.*)?" . But a lot > > of the DWC USB3-compatible nodes defined in the ARM/ARM64 DTS files have > > name as "^dwc3@.*" or "^usb[1-3]@.*" or even "^dwusb@.*", which will cause > > the dtbs_check procedure failure. Let's fix the nodes naming to be > > compatible with the DWC USB3 DT schema to make dtbs_check happy. > > > > Note we don't change the DWC USB3-compatible nodes names of > > arch/arm64/boot/dts/apm/{apm-storm.dtsi,apm-shadowcat.dtsi} since the > > in-source comment says that the nodes name need to be preserved as > > "^dwusb@.*" for some backward compatibility. > > interesting, compatibility with what? Some debugfs files, perhaps? :-) Don't really know.) In my experience the worst type of such compatibility is connected with some bootloader magic, which may add/remove/modify properties to nodes with pre-defined names. -Sergey > > In any case, I don't have any problems with this, so I'll let other > folks comment. > > -- > balbi