From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: linuxppc-dev@ozlabs.org, rdunlap@infradead.org
Subject: Re: [PATCH 1/3] powerpc: Make NUMA depend on SMP
Date: Wed, 25 Nov 2020 10:00:08 +0530 [thread overview]
Message-ID: <20201125043008.GD528281@linux.vnet.ibm.com> (raw)
In-Reply-To: <20201124120547.1940635-1-mpe@ellerman.id.au>
* Michael Ellerman <mpe@ellerman.id.au> [2020-11-24 23:05:45]:
> Our Kconfig allows NUMA to be enabled without SMP, but none of
> our defconfigs use that combination. This means it can easily be
> broken inadvertently by code changes, which has happened recently.
>
> Although it's theoretically possible to have a machine with a single
> CPU and multiple memory nodes, I can't think of any real systems where
> that's the case. Even so if such a system exists, it can just run an
> SMP kernel anyway.
>
> So to avoid the need to add extra #ifdefs and/or build breaks, make
> NUMA depend on SMP.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Looks good to me.
Reviewed-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
> ---
> arch/powerpc/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
> index e9f13fe08492..a22db3db6b96 100644
> --- a/arch/powerpc/Kconfig
> +++ b/arch/powerpc/Kconfig
> @@ -660,7 +660,7 @@ config IRQ_ALL_CPUS
>
> config NUMA
> bool "NUMA support"
> - depends on PPC64
> + depends on PPC64 && SMP
> default y if SMP && PPC_PSERIES
>
> config NODES_SHIFT
> --
> 2.25.1
>
--
Thanks and Regards
Srikar Dronamraju
next prev parent reply other threads:[~2020-11-25 4:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-24 12:05 [PATCH 1/3] powerpc: Make NUMA depend on SMP Michael Ellerman
2020-11-24 12:05 ` [PATCH 2/3] powerpc: Make NUMA default y for powernv Michael Ellerman
2020-11-25 4:30 ` Srikar Dronamraju
2020-11-24 12:05 ` [PATCH 3/3] powerpc: Update NUMA Kconfig description & help text Michael Ellerman
2020-11-24 19:47 ` Randy Dunlap
2020-11-24 19:46 ` [PATCH 1/3] powerpc: Make NUMA depend on SMP Randy Dunlap
2020-11-25 4:30 ` Srikar Dronamraju [this message]
2020-12-10 11:30 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201125043008.GD528281@linux.vnet.ibm.com \
--to=srikar@linux.vnet.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).