* [PATCH v2 -next] misc: ocxl: use DEFINE_MUTEX() for mutex lock
@ 2020-12-24 13:24 Zheng Yongjun
2021-01-04 8:50 ` Frederic Barrat
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Zheng Yongjun @ 2020-12-24 13:24 UTC (permalink / raw)
To: linuxppc-dev, linux-kernel; +Cc: fbarrat, gregkh, ajd, arnd, Zheng Yongjun
mutex lock can be initialized automatically with DEFINE_MUTEX()
rather than explicitly calling mutex_init().
Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
---
drivers/misc/ocxl/file.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/misc/ocxl/file.c b/drivers/misc/ocxl/file.c
index 4d1b44de1492..e70525eedaae 100644
--- a/drivers/misc/ocxl/file.c
+++ b/drivers/misc/ocxl/file.c
@@ -15,7 +15,7 @@
static dev_t ocxl_dev;
static struct class *ocxl_class;
-static struct mutex minors_idr_lock;
+static DEFINE_MUTEX(minors_idr_lock);
static struct idr minors_idr;
static struct ocxl_file_info *find_and_get_file_info(dev_t devno)
@@ -588,7 +588,6 @@ int ocxl_file_init(void)
{
int rc;
- mutex_init(&minors_idr_lock);
idr_init(&minors_idr);
rc = alloc_chrdev_region(&ocxl_dev, 0, OCXL_NUM_MINORS, "ocxl");
--
2.22.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2 -next] misc: ocxl: use DEFINE_MUTEX() for mutex lock
2020-12-24 13:24 [PATCH v2 -next] misc: ocxl: use DEFINE_MUTEX() for mutex lock Zheng Yongjun
@ 2021-01-04 8:50 ` Frederic Barrat
2021-01-05 21:53 ` Andrew Donnellan
2021-02-03 11:40 ` Michael Ellerman
2 siblings, 0 replies; 4+ messages in thread
From: Frederic Barrat @ 2021-01-04 8:50 UTC (permalink / raw)
To: Zheng Yongjun, linuxppc-dev, linux-kernel; +Cc: gregkh, ajd, arnd
On 24/12/2020 14:24, Zheng Yongjun wrote:
> mutex lock can be initialized automatically with DEFINE_MUTEX()
> rather than explicitly calling mutex_init().
>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
> ---
Thanks!
Acked-by: Frederic Barrat <fbarrat@linux.ibm.com>
> drivers/misc/ocxl/file.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/misc/ocxl/file.c b/drivers/misc/ocxl/file.c
> index 4d1b44de1492..e70525eedaae 100644
> --- a/drivers/misc/ocxl/file.c
> +++ b/drivers/misc/ocxl/file.c
> @@ -15,7 +15,7 @@
>
> static dev_t ocxl_dev;
> static struct class *ocxl_class;
> -static struct mutex minors_idr_lock;
> +static DEFINE_MUTEX(minors_idr_lock);
> static struct idr minors_idr;
>
> static struct ocxl_file_info *find_and_get_file_info(dev_t devno)
> @@ -588,7 +588,6 @@ int ocxl_file_init(void)
> {
> int rc;
>
> - mutex_init(&minors_idr_lock);
> idr_init(&minors_idr);
>
> rc = alloc_chrdev_region(&ocxl_dev, 0, OCXL_NUM_MINORS, "ocxl");
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2 -next] misc: ocxl: use DEFINE_MUTEX() for mutex lock
2020-12-24 13:24 [PATCH v2 -next] misc: ocxl: use DEFINE_MUTEX() for mutex lock Zheng Yongjun
2021-01-04 8:50 ` Frederic Barrat
@ 2021-01-05 21:53 ` Andrew Donnellan
2021-02-03 11:40 ` Michael Ellerman
2 siblings, 0 replies; 4+ messages in thread
From: Andrew Donnellan @ 2021-01-05 21:53 UTC (permalink / raw)
To: Zheng Yongjun, linuxppc-dev, linux-kernel; +Cc: fbarrat, gregkh, arnd
On 25/12/20 12:24 am, Zheng Yongjun wrote:
> mutex lock can be initialized automatically with DEFINE_MUTEX()
> rather than explicitly calling mutex_init().
>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
Acked-by: Andrew Donnellan <ajd@linux.ibm.com>
--
Andrew Donnellan OzLabs, ADL Canberra
ajd@linux.ibm.com IBM Australia Limited
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 -next] misc: ocxl: use DEFINE_MUTEX() for mutex lock
2020-12-24 13:24 [PATCH v2 -next] misc: ocxl: use DEFINE_MUTEX() for mutex lock Zheng Yongjun
2021-01-04 8:50 ` Frederic Barrat
2021-01-05 21:53 ` Andrew Donnellan
@ 2021-02-03 11:40 ` Michael Ellerman
2 siblings, 0 replies; 4+ messages in thread
From: Michael Ellerman @ 2021-02-03 11:40 UTC (permalink / raw)
To: linuxppc-dev, linux-kernel, Zheng Yongjun; +Cc: fbarrat, gregkh, ajd, arnd
On Thu, 24 Dec 2020 21:24:46 +0800, Zheng Yongjun wrote:
> mutex lock can be initialized automatically with DEFINE_MUTEX()
> rather than explicitly calling mutex_init().
Applied to powerpc/next.
[1/1] ocxl: use DEFINE_MUTEX() for mutex lock
https://git.kernel.org/powerpc/c/52f6b0a90bcf573ba8a33e97544c7b6f292376a4
cheers
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-02-03 13:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-24 13:24 [PATCH v2 -next] misc: ocxl: use DEFINE_MUTEX() for mutex lock Zheng Yongjun
2021-01-04 8:50 ` Frederic Barrat
2021-01-05 21:53 ` Andrew Donnellan
2021-02-03 11:40 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).