LinuxPPC-Dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Cédric Le Goater" <clg@kaod.org>
To: linuxppc-dev@lists.ozlabs.org
Cc: "Christophe Leroy" <christophe.leroy@c-s.fr>,
	"Cédric Le Goater" <clg@kaod.org>
Subject: [PATCH v2 06/23] powerpc/setup_64: Make some routines static
Date: Mon,  4 Jan 2021 15:31:49 +0100	[thread overview]
Message-ID: <20210104143206.695198-7-clg@kaod.org> (raw)
In-Reply-To: <20210104143206.695198-1-clg@kaod.org>

The following routines are only called by local services and do not
need to be external symbols.

It fixes these W=1 errors :

../arch/powerpc/kernel/setup_64.c:261:13: error: no previous prototype for ‘record_spr_defaults’ [-Werror=missing-prototypes]
  261 | void __init record_spr_defaults(void)
      |             ^~~~~~~~~~~~~~~~~~~
../arch/powerpc/kernel/setup_64.c:1011:6: error: no previous prototype for ‘entry_flush_enable’ [-Werror=missing-prototypes]
 1011 | void entry_flush_enable(bool enable)
      |      ^~~~~~~~~~~~~~~~~~
../arch/powerpc/kernel/setup_64.c:1023:6: error: no previous prototype for ‘uaccess_flush_enable’ [-Werror=missing-prototypes]
 1023 | void uaccess_flush_enable(bool enable)
      |      ^~~~~~~~~~~~~~~~~~~~

Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
 arch/powerpc/kernel/setup_64.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/arch/powerpc/kernel/setup_64.c b/arch/powerpc/kernel/setup_64.c
index c28e949cc222..560ed8b975e7 100644
--- a/arch/powerpc/kernel/setup_64.c
+++ b/arch/powerpc/kernel/setup_64.c
@@ -67,6 +67,7 @@
 #include <asm/kup.h>
 #include <asm/early_ioremap.h>
 #include <asm/pgalloc.h>
+#include <asm/asm-prototypes.h>
 
 #include "setup.h"
 
@@ -258,7 +259,7 @@ static void cpu_ready_for_interrupts(void)
 
 unsigned long spr_default_dscr = 0;
 
-void __init record_spr_defaults(void)
+static void __init record_spr_defaults(void)
 {
 	if (early_cpu_has_feature(CPU_FTR_DSCR))
 		spr_default_dscr = mfspr(SPRN_DSCR);
@@ -1008,7 +1009,7 @@ void rfi_flush_enable(bool enable)
 	rfi_flush = enable;
 }
 
-void entry_flush_enable(bool enable)
+static void entry_flush_enable(bool enable)
 {
 	if (enable) {
 		do_entry_flush_fixups(enabled_flush_types);
@@ -1020,7 +1021,7 @@ void entry_flush_enable(bool enable)
 	entry_flush = enable;
 }
 
-void uaccess_flush_enable(bool enable)
+static void uaccess_flush_enable(bool enable)
 {
 	if (enable) {
 		do_uaccess_flush_fixups(enabled_flush_types);
-- 
2.26.2


  parent reply	other threads:[~2021-01-04 15:16 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-04 14:31 [PATCH v2 00/23] powerpc: Fix W=1 compile errors Cédric Le Goater
2021-01-04 14:31 ` [PATCH v2 01/23] powerpc/mm: Include __find_linux_pte() prototype Cédric Le Goater
2021-01-04 14:31 ` [PATCH v2 02/23] powerpc/pseries/ras: Remove unused variable 'status' Cédric Le Goater
2021-01-04 14:31 ` [PATCH v2 03/23] powerpc/pseries/eeh: Make pseries_pcibios_bus_add_device() static Cédric Le Goater
2021-01-04 14:31 ` [PATCH v2 04/23] powerpc/pseries/ras: Make init_ras_hotplug_IRQ() static Cédric Le Goater
2021-01-04 14:31 ` [PATCH v2 05/23] powerpc/pmem: Include pmem prototypes Cédric Le Goater
2021-01-04 14:31 ` Cédric Le Goater [this message]
2021-01-04 14:31 ` [PATCH v2 07/23] powerpc/mce: Include prototypes Cédric Le Goater
2021-01-04 14:31 ` [PATCH v2 08/23] powerpc/smp: Include tick_broadcast() prototype Cédric Le Goater
2021-01-04 14:31 ` [PATCH v2 09/23] powerpc/smp: Make debugger_ipi_callback() static Cédric Le Goater
2021-01-04 14:31 ` [PATCH v2 10/23] powerpc/optprobes: Remove unused routine patch_imm32_load_insns() Cédric Le Goater
2021-01-04 14:31 ` [PATCH v2 11/23] powerpc/optprobes: Make patch_imm64_load_insns() static Cédric Le Goater
2021-01-04 14:31 ` [PATCH v2 12/23] powerpc/mm: Declare some prototypes Cédric Le Goater
2021-01-04 14:31 ` [PATCH v2 13/23] powerpc/mm: Move hpte_insert_repeating() prototype Cédric Le Goater
2021-01-04 14:31 ` [PATCH v2 14/23] powerpc/mm: Declare preload_new_slb_context() prototype Cédric Le Goater
2021-01-04 14:31 ` [PATCH v2 15/23] powerpc/mm/hugetlb: Make pseries_alloc_bootmem_huge_page() static Cédric Le Goater
2021-01-04 14:31 ` [PATCH v2 16/23] powerpc/mm: Declare arch_report_meminfo() prototype Cédric Le Goater
2021-01-04 14:32 ` [PATCH v2 17/23] powerpc/watchdog: Declare soft_nmi_interrupt() prototype Cédric Le Goater
2021-01-04 14:32 ` [PATCH v2 18/23] KVM: PPC: Make the VMX instruction emulation routines static Cédric Le Goater
2021-01-04 14:32 ` [PATCH v2 19/23] KVM: PPC: Book3S HV: Include prototypes Cédric Le Goater
2021-01-04 14:32 ` [PATCH v2 20/23] KVM: PPC: Book3S HV: Declare some prototypes Cédric Le Goater
2021-01-04 14:32 ` [PATCH v2 21/23] powerpc/pseries: Make IOV setup routines static Cédric Le Goater
2021-01-04 14:32 ` [PATCH v2 22/23] powerpc/pcidn: " Cédric Le Goater
2021-01-04 14:32 ` [PATCH v2 23/23] powerpc/pseries/eeh: Make pseries_send_allow_unfreeze() static Cédric Le Goater
2021-02-03 11:40 ` [PATCH v2 00/23] powerpc: Fix W=1 compile errors Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210104143206.695198-7-clg@kaod.org \
    --to=clg@kaod.org \
    --cc=christophe.leroy@c-s.fr \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox