From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59B9AC433E0 for ; Wed, 13 Jan 2021 16:50:22 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 944102339D for ; Wed, 13 Jan 2021 16:50:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 944102339D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4DGD2f4XM6zDrf6 for ; Thu, 14 Jan 2021 03:50:18 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=198.145.29.99; helo=mail.kernel.org; envelope-from=sashal@kernel.org; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=Pkt1JARf; dkim-atps=neutral Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4DGD0c5W2ZzDqxL for ; Thu, 14 Jan 2021 03:48:32 +1100 (AEDT) Received: by mail.kernel.org (Postfix) with ESMTPSA id EEAC3233F6; Wed, 13 Jan 2021 16:48:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1610556510; bh=DnL73vKlQSXlWUYZg/eWP8NDNE5x28qj3Gv+Ku3NoTo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Pkt1JARf98QPcGtbmKSASRKHfIk/DDZqSGH/Ea6KdL1TrPgS1tVUCvpA9nS+EbYF0 qRri12p1oAw6iljdnizhmnxTMTBMv1vSLMmzmW1BsDXnOLLWc9SffaIGwDBSZ9r3D4 UICd50FGkKfHNxkKMJdW6Il71G+UfH7J1L0TWu5kRQKV2KAEq/ynHMgMis7KFEkFcp oqkW38Qy5qmJLmnglO9YCoxAbpPyWNq5n5v6MhFCf+hnEi0IkllNrMa8SWJ8l+fqvO MbZCADTuC8e+CsVAxdOhxEk9G0/Xhaq52GtdqPKZeQRH9by3FlbrWA8b1xObyQCNR6 BRX0ICm1+A96g== Date: Wed, 13 Jan 2021 11:48:28 -0500 From: Sasha Levin To: Christophe Leroy Subject: Re: [PATCH for 4.9/4.14] powerpc: Fix incorrect stw{, ux, u, x} instructions in __set_pte_at Message-ID: <20210113164828.GQ4035784@sasha-vm> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Wed, Jan 13, 2021 at 07:12:44AM +0000, Christophe Leroy wrote: >From: Mathieu Desnoyers > >Backport for 4.9 and 4.14 > >(cherry picked from commit d85be8a49e733dcd23674aa6202870d54bf5600d) > >The placeholder for instruction selection should use the second >argument's operand, which is %1, not %0. This could generate incorrect >assembly code if the memory addressing of operand %0 is a different >form from that of operand %1. > >Also remove the %Un placeholder because having %Un placeholders >for two operands which are based on the same local var (ptep) doesn't >make much sense. By the way, it doesn't change the current behaviour >because "<>" constraint is missing for the associated "=m". > >[chleroy: revised commit log iaw segher's comments and removed %U0] > >Fixes: 9bf2b5cdc5fe ("powerpc: Fixes for CONFIG_PTE_64BIT for SMP support") >Cc: # v2.6.28+ >Signed-off-by: Mathieu Desnoyers >Signed-off-by: Christophe Leroy >Acked-by: Segher Boessenkool >Signed-off-by: Michael Ellerman >Link: https://lore.kernel.org/r/96354bd77977a6a933fe9020da57629007fdb920.1603358942.git.christophe.leroy@csgroup.eu I took this and the 4.4 backport, thanks! -- Thanks, Sasha