From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55B77C433DB for ; Fri, 15 Jan 2021 11:40:25 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C13E92313E for ; Fri, 15 Jan 2021 11:40:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C13E92313E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4DHK462fyVzDsgC for ; Fri, 15 Jan 2021 22:40:22 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=arm.com (client-ip=217.140.110.172; helo=foss.arm.com; envelope-from=lorenzo.pieralisi@arm.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=arm.com Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lists.ozlabs.org (Postfix) with ESMTP id 4DHK0Q5tYfzDsTD for ; Fri, 15 Jan 2021 22:37:05 +1100 (AEDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 52ABFD6E; Fri, 15 Jan 2021 03:37:01 -0800 (PST) Received: from e121166-lin.cambridge.arm.com (e121166-lin.cambridge.arm.com [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 02E983F719; Fri, 15 Jan 2021 03:36:59 -0800 (PST) Date: Fri, 15 Jan 2021 11:36:54 +0000 From: Lorenzo Pieralisi To: Bjorn Helgaas Subject: Re: [PATCH -next] pci/controller/dwc: convert comma to semicolon Message-ID: <20210115113654.GA22508@e121166-lin.cambridge.arm.com> References: <20201216131944.14990-1-zhengyongjun3@huawei.com> <20210106190722.GA1327553@bjorn-Precision-5520> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210106190722.GA1327553@bjorn-Precision-5520> User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: robh@kernel.org, roy.zang@nxp.com, minghuan.Lian@nxp.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Zheng Yongjun , linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, mingkai.hu@nxp.com Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Wed, Jan 06, 2021 at 01:07:22PM -0600, Bjorn Helgaas wrote: > On Wed, Dec 16, 2020 at 09:19:44PM +0800, Zheng Yongjun wrote: > > Replace a comma between expression statements by a semicolon. > > Looks like a good fix, but read this about the changelog title: > > https://lore.kernel.org/r/20171026223701.GA25649@bhelgaas-glaptop.roam.corp.google.com I would request NXP maintainers to take this patch, rewrite it as Bjorn requested and resend it as fast as possible, this is a very relevant fix. Thanks, Lorenzo > > Signed-off-by: Zheng Yongjun > > --- > > drivers/pci/controller/dwc/pci-layerscape-ep.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c b/drivers/pci/controller/dwc/pci-layerscape-ep.c > > index 84206f265e54..917ba8d254fc 100644 > > --- a/drivers/pci/controller/dwc/pci-layerscape-ep.c > > +++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c > > @@ -178,7 +178,7 @@ static int __init ls_pcie_ep_probe(struct platform_device *pdev) > > pci->dev = dev; > > pci->ops = pcie->drvdata->dw_pcie_ops; > > > > - ls_epc->bar_fixed_64bit = (1 << BAR_2) | (1 << BAR_4), > > + ls_epc->bar_fixed_64bit = (1 << BAR_2) | (1 << BAR_4); > > > > pcie->pci = pci; > > pcie->ls_epc = ls_epc; > > -- > > 2.22.0 > > > > > > _______________________________________________ > > linux-arm-kernel mailing list > > linux-arm-kernel@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel